build: use nyc for test coverage

Author: dougwilson

.github/workflows/ci.yml

@@ -34,41 +34,43 @@ jobs:
         - name: Node.js 0.8
           node-version: "0.8"
           npm-i: [email protected] [email protected]
-          npm-rm: istanbul
+          npm-rm: nyc
 
         - name: Node.js 0.10
           node-version: "0.10"
-          npm-i: [email protected] [email protected]
+          npm-i: [email protected] [email protected] [email protected]
 
         - name: Node.js 0.12
           node-version: "0.12"
-          npm-i: [email protected] [email protected]
+          npm-i: [email protected] [email protected] [email protected]
 
         - name: io.js 1.x
           node-version: "1.8"
-          npm-i: [email protected] [email protected]
+          npm-i: [email protected] [email protected] [email protected]
 
         - name: io.js 2.x
           node-version: "2.5"
-          npm-i: [email protected] [email protected]
+          npm-i: [email protected] [email protected] [email protected]
 
         - name: io.js 3.x
           node-version: "3.3"
-          npm-i: [email protected] [email protected]
+          npm-i: [email protected] [email protected] [email protected]
 
         - name: Node.js 4.x
           node-version: "4.9"
-          npm-i: [email protected] [email protected]
+          npm-i: [email protected] [email protected] [email protected]
 
         - name: Node.js 5.x
           node-version: "5.12"
-          npm-i: [email protected] [email protected]
+          npm-i: [email protected] [email protected] [email protected]
 
         - name: Node.js 6.x
           node-version: "6.17"
+          npm-i: [email protected]
 
         - name: Node.js 7.x
           node-version: "7.10"
+          npm-i: [email protected]
 
         - name: Node.js 8.x
           node-version: "8.16"
@@ -150,7 +152,7 @@ jobs:
     - name: Run tests
       shell: bash
       run: |
-        if npm -ps ls istanbul | grep -q istanbul; then
+        if npm -ps ls nyc | grep -q nyc; then
           npm run test-ci
         else
           npm test
@@ -162,7 +164,7 @@ jobs:
 
     - name: Collect code coverage
       uses: coverallsapp/github-action@master
-      if: steps.list_env.outputs.istanbul != ''
+      if: steps.list_env.outputs.nyc != ''
       with:
         github-token: ${{ secrets.GITHUB_TOKEN }}
         flag-name: run-${{ matrix.test_number }}

.gitignore

@@ -1,3 +1,4 @@
+.nyc_output/
 coverage
 node_modules
 npm-debug.log

package.json

@@ -26,8 +26,8 @@
     "eslint-plugin-node": "9.2.0",
     "eslint-plugin-promise": "4.2.1",
     "eslint-plugin-standard": "4.0.1",
-    "istanbul": "0.4.5",
     "mocha": "6.2.3",
+    "nyc": "15.1.0",
     "supertest": "4.0.2"
   },
   "files": [
@@ -41,7 +41,7 @@
   "scripts": {
     "lint": "eslint --plugin markdown --ext js,md .",
     "test": "mocha --check-leaks --reporter spec --bail",
-    "test-ci": "istanbul cover node_modules/mocha/bin/_mocha --report lcovonly -- --check-leaks --reporter spec",
-    "test-cov": "istanbul cover node_modules/mocha/bin/_mocha -- --check-leaks --reporter dot"
+    "test-ci": "nyc --reporter=lcovonly --reporter=text npm test",
+    "test-cov": "nyc --reporter=html --reporter=text npm test"
   }
 }