tests: use after module for flow control

Author: dougwilson

package.json

@@ -18,6 +18,7 @@
     "vary": "~1.1.2"
   },
   "devDependencies": {
+    "after": "0.8.2",
     "eslint": "4.19.0",
     "eslint-config-standard": "11.0.0",
     "eslint-plugin-import": "2.9.0",

test/compression.js

@@ -1,3 +1,4 @@
+var after = require('after')
 var assert = require('assert')
 var Buffer = require('safe-buffer').Buffer
 var bytes = require('bytes')
@@ -157,6 +158,7 @@ describe('compression()', function () {
 
   it('should back-pressure when compressed', function (done) {
     var buf
+    var cb = after(2, done)
     var client
     var drained = false
     var resp
@@ -171,19 +173,13 @@ describe('compression()', function () {
       res.write('start')
       pressure()
     })
-    var wait = 2
 
     crypto.pseudoRandomBytes(1024 * 128, function (err, chunk) {
       if (err) return done(err)
       buf = chunk
       pressure()
     })
 
-    function complete () {
-      if (--wait !== 0) return
-      done()
-    }
-
     function pressure () {
       if (!buf || !resp || !client) return
 
@@ -198,7 +194,7 @@ describe('compression()', function () {
         resp.end()
       })
 
-      resp.on('finish', complete)
+      resp.on('finish', cb)
       client.resume()
     }
 
@@ -209,14 +205,15 @@ describe('compression()', function () {
         client = res
         assert.equal(res.headers['content-encoding'], 'gzip')
         res.pause()
-        res.on('end', complete)
+        res.on('end', cb)
         pressure()
       })
       .end()
   })
 
   it('should back-pressure when uncompressed', function (done) {
     var buf
+    var cb = after(2, done)
     var client
     var drained = false
     var resp
@@ -231,19 +228,13 @@ describe('compression()', function () {
       res.write('start')
       pressure()
     })
-    var wait = 2
 
     crypto.pseudoRandomBytes(1024 * 128, function (err, chunk) {
       if (err) return done(err)
       buf = chunk
       pressure()
     })
 
-    function complete () {
-      if (--wait !== 0) return
-      done()
-    }
-
     function pressure () {
       if (!buf || !resp || !client) return
 
@@ -256,7 +247,7 @@ describe('compression()', function () {
         assert.ok(resp.write('end'))
         resp.end()
       })
-      resp.on('finish', complete)
+      resp.on('finish', cb)
       client.resume()
     }
 
@@ -267,7 +258,7 @@ describe('compression()', function () {
         client = res
         shouldNotHaveHeader('Content-Encoding')(res)
         res.pause()
-        res.on('end', complete)
+        res.on('end', cb)
         pressure()
       })
       .end()