Use safe-buffer for improved Buffer API

Author: dougwilson

HISTORY.md

@@ -1,6 +1,7 @@
 unreleased
 ==========
 
+  * Use `safe-buffer` for improved Buffer API
   * deps: [email protected]
   * deps: compressible@~2.0.10
     - Fix regex fallback to not override `compressible: false` in db

index.js

@@ -15,6 +15,7 @@
  */
 
 var accepts = require('accepts')
+var Buffer = require('safe-buffer').Buffer
 var bytes = require('bytes')
 var compressible = require('compressible')
 var debug = require('debug')('compression')
@@ -84,7 +85,7 @@ function compression (options) {
       }
 
       return stream
-        ? stream.write(new Buffer(chunk, encoding))
+        ? stream.write(Buffer.from(chunk, encoding))
         : _write.call(this, chunk, encoding)
     }
 
@@ -111,7 +112,7 @@ function compression (options) {
 
       // write Buffer for Node.js 0.8
       return chunk
-        ? stream.end(new Buffer(chunk, encoding))
+        ? stream.end(Buffer.from(chunk, encoding))
         : stream.end()
     }
 

package.json

@@ -14,6 +14,7 @@
     "compressible": "~2.0.10",
     "debug": "2.6.8",
     "on-headers": "~1.0.1",
+    "safe-buffer": "5.1.1",
     "vary": "~1.1.1"
   },
   "devDependencies": {

test/compression.js

@@ -1,4 +1,5 @@
 var assert = require('assert')
+var Buffer = require('safe-buffer').Buffer
 var bytes = require('bytes')
 var crypto = require('crypto')
 var http = require('http')
@@ -268,14 +269,12 @@ describe('compression()', function () {
 
   it('should transfer large bodies', function (done) {
     var len = bytes('1mb')
-    var buf = new Buffer(len)
+    var buf = Buffer.alloc(len, '.')
     var server = createServer({ threshold: 0 }, function (req, res) {
       res.setHeader('Content-Type', 'text/plain')
       res.end(buf)
     })
 
-    buf.fill('.')
-
     request(server)
     .get('/')
     .set('Accept-Encoding', 'gzip')
@@ -287,7 +286,7 @@ describe('compression()', function () {
 
   it('should transfer large bodies with multiple writes', function (done) {
     var len = bytes('40kb')
-    var buf = new Buffer(len)
+    var buf = Buffer.alloc(len, '.')
     var server = createServer({ threshold: 0 }, function (req, res) {
       res.setHeader('Content-Type', 'text/plain')
       res.write(buf)
@@ -296,8 +295,6 @@ describe('compression()', function () {
       res.end(buf)
     })
 
-    buf.fill('.')
-
     request(server)
     .get('/')
     .set('Accept-Encoding', 'gzip')
@@ -326,7 +323,7 @@ describe('compression()', function () {
       var server = createServer({ threshold: '1kb' }, function (req, res) {
         res.setHeader('Content-Type', 'text/plain')
         res.setHeader('Content-Length', '2048')
-        res.end(new Buffer(2048))
+        res.end(Buffer.alloc(2048))
       })
 
       request(server)
@@ -371,9 +368,9 @@ describe('compression()', function () {
       var server = createServer({ threshold: '1kb' }, function (req, res) {
         res.setHeader('Content-Type', 'text/plain')
         res.setHeader('Content-Length', '2048')
-        res.write(new Buffer(1024))
+        res.write(Buffer.alloc(1024))
         setTimeout(function () {
-          res.end(new Buffer(1024))
+          res.end(Buffer.alloc(1024))
         }, 10)
       })
 
@@ -584,7 +581,7 @@ describe('compression()', function () {
       var chunks = 0
       var next
       var server = createServer({ threshold: 0 }, function (req, res) {
-        next = writeAndFlush(res, 2, new Buffer(1024))
+        next = writeAndFlush(res, 2, Buffer.alloc(1024))
         res.setHeader('Content-Type', 'text/plain')
         res.setHeader('Content-Length', '2048')
         next()
@@ -608,7 +605,7 @@ describe('compression()', function () {
       var chunks = 0
       var next
       var server = createServer({ threshold: 0 }, function (req, res) {
-        next = writeAndFlush(res, 2, new Buffer('..'))
+        next = writeAndFlush(res, 2, Buffer.from('..'))
         res.setHeader('Content-Type', 'text/plain')
         next()
       })
@@ -631,7 +628,7 @@ describe('compression()', function () {
       var chunks = 0
       var next
       var server = createServer({ threshold: 0 }, function (req, res) {
-        next = writeAndFlush(res, 2, new Buffer('..'))
+        next = writeAndFlush(res, 2, Buffer.from('..'))
         res.setHeader('Content-Type', 'text/plain')
         next()
       })