@@ -10,7 +10,7 @@ var http2 = require('http2')
1010var compression = require ( '..' )
1111
1212describe ( 'compression()' , function ( ) {
13- describe ( 'should work with valid types (string, Buffer, Uint8Array)' , function ( ) {
13+ describe ( 'should work end and write with valid types (string, Buffer, Uint8Array)' , function ( ) {
1414 it ( 'res.write(string)' , function ( done ) {
1515 var server = createServer ( { threshold : 0 } , function ( req , res ) {
1616 res . setHeader ( 'Content-Type' , 'text/plain' )
@@ -78,13 +78,13 @@ describe('compression()', function () {
7878 } )
7979 } )
8080
81- var run = / ^ v 0 \. 1 2 \. / . test ( process . version ) ? it : it . skip
82- run ( 'res.write(Uint8Array)' , function ( done ) {
81+ it ( 'res.write(Uint8Array)' , function ( done ) {
8382 var server = createServer ( { threshold : 0 } , function ( req , res ) {
8483 res . setHeader ( 'Content-Type' , 'text/plain' )
8584 res . end ( new Uint8Array ( 1 ) )
8685 } )
8786
87+ // TODO: see body response
8888 request ( server )
8989 . get ( '/' )
9090 . set ( 'Accept-Encoding' , 'gzip' )
@@ -173,8 +173,7 @@ describe('compression()', function () {
173173 . expect ( 200 , done )
174174 } )
175175
176- var run = / ^ v 0 \. 1 2 \. / . test ( process . version ) ? it : it . skip
177- run ( 'res.write() should call callback if passsed' , function ( done ) {
176+ it ( 'res.write() should call callback if passsed' , function ( done ) {
178177 var server = createServer ( { threshold : 0 } , function ( req , res ) {
179178 res . setHeader ( 'Content-Type' , 'text/plain' )
180179
@@ -191,8 +190,7 @@ describe('compression()', function () {
191190 . expect ( 200 , done )
192191 } )
193192
194- run = / ^ v 0 \. 1 2 \. / . test ( process . version ) ? it : it . skip
195- run ( 'res.write() should call callback with error after end' , function ( done ) {
193+ it ( 'res.write() should call callback with error after end' , function ( done ) {
196194 var onErrorCalled = false
197195 var onError = function ( err ) {
198196 assert . ok ( err . toString ( ) . indexOf ( 'write after end' ) > - 1 || err . code === 'ERR_STREAM_WRITE_AFTER_END' )
@@ -623,9 +621,9 @@ describe('compression()', function () {
623621 . expect ( 'Content-Encoding' , 'gzip' , done )
624622 } )
625623
624+ // TODO: why no set Content-Length?
626625 // res.end(str, encoding) broken in node.js 0.8
627- var run = / ^ v 0 \. 8 \. / . test ( process . version ) ? it . skip : it
628- run ( 'should handle writing hex data' , function ( done ) {
626+ it ( 'should handle writing hex data' , function ( done ) {
629627 var server = createServer ( { threshold : 6 } , function ( req , res ) {
630628 res . setHeader ( 'Content-Type' , 'text/plain' )
631629 res . end ( '2e2e2e2e' , 'hex' )
0 commit comments