Improve detection of zero-length body without Content-Length

Author: dougwilson

HISTORY.md

@@ -1,6 +1,7 @@
 unreleased
 ==========
 
+  * Improve detection of zero-length body without `Content-Length`
   * deps: accepts@~1.2.9
     - deps: mime-types@~2.1.1
     - perf: avoid argument reassignment & argument slice

index.js

@@ -217,7 +217,7 @@ function addListeners(stream, on, listeners) {
 
 function chunkLength(chunk, encoding) {
   if (!chunk) {
-    return
+    return 0
   }
 
   return !Buffer.isBuffer(chunk)

test/compression.js

@@ -395,6 +395,19 @@ describe('compression()', function(){
       .expect(200, '....', done)
     })
 
+    it('should consider res.end() as 0 length', function(done){
+      var server = createServer({ threshold: 1 }, function (req, res) {
+        res.setHeader('Content-Type', 'text/plain')
+        res.end()
+      })
+
+      request(server)
+      .get('/')
+      .set('Accept-Encoding', 'gzip')
+      .expect(shouldNotHaveHeader('Content-Encoding'))
+      .expect(200, '', done)
+    })
+
     it('should work with res.end(null)', function (done) {
       var server = createServer({ threshold: 1000 }, function (req, res) {
         res.setHeader('Content-Type', 'text/plain')
@@ -404,6 +417,7 @@ describe('compression()', function(){
       request(server)
       .get('/')
       .set('Accept-Encoding', 'gzip')
+      .expect(shouldNotHaveHeader('Content-Encoding'))
       .expect(200, '', done)
     })
   })