Deprecated route handler

[MasterProvider]

Deprecated error for app.all('*', (req, res) => nextHandler(req, res));
after I upgrade from v4 to express 5

 ⨯ unhandledRejection: TypeError: Missing parameter name at 1: https://git.new/pathToRegexpError
    at lexer.next (<anonymous>)
    at Array.map (<anonymous>)
    at <unknown> (server\server.mjs:1028:9)
 ⨯ unhandledRejection:  TypeError: Missing parameter name at 1: https://git.new/pathToRegexpError
    at lexer.next (<anonymous>)
    at Array.map (<anonymous>)
    at <unknown> (server\server.mjs:1028:9)

Snippet

const hostname = 'localhost'
const port = 3005;
const dev = process.env.NODE_ENV !== "production";
const nextApp = next({ dev, hostname, port });
const nextHandler = nextApp.getRequestHandler();

nextApp.prepare().then(async() => {
    const app = express();
    const server = http.createServer(app);

   app.post('/action/create-message',upload.none(), async(req, res) => {
     //[...]
   });

    app.all('*', (req, res) => nextHandler(req, res));


    server.listen(port, () => {
        console.log(`> Ready on http://${hostname}:${port}`)
    });
});

[krzysdz]

To make this path work in Express 5.x change '*' to '/{*splat}'.

This is described in:

• path-to-regexp readme: https://git.new/pathToRegexpError
• Express 5 migration guide: https://expressjs.com/en/guide/migrating-5.html#path-syntax
• pinned issue: TypeError: Missing parameter name at 2: https://git.new/pathToRegexpError #6428
• a couple more issues: [DEPLOY-ERROR] - TypeError: Missing parameter name at 1: https://git.new/pathToRegexpError - Firebase Functions Project - Updated to Version 5 - Firebase Deploy Failed #5936, throw new TypeError(Missing parameter name at ${i}: ${DEBUG_URL}); at node_modules/path-to-regexp/dist/index.js:73 #6038, TypeError: Missing parameter name #6441

[MasterProvider]

Thanks it's work

[nidegen]

I have a similar issue:

I want to migrate /:collection(foo|bar)/:id? to 5.

As I understand, it should be /:collection(foo|bar){/:id}.

But the ( seems to break anyways. Am I missing sth?

TypeError: Unexpected ( at 12, expected END: https://git.new/pathToRegexpError
    at Iter.consume (/Users/nicolas/Developer/echolabs/Server/node_modules/.pnpm/[email protected]/node_modules/path-to-regexp/dist/index.js:123:15)
    at consume (/Users/nicolas/Developer/echolabs/Server/node_modules/.pnpm/[email protected]/node_modules/path-to-regexp/dist/index.js:179:16)
    at parse (/Users/nicolas/Developer/echolabs/Server/node_modules/.pnpm/[email protected]/node_modules/path-to-regexp/dist/index.js:183:20)
    at /Users/nicolas/Developer/echolabs/Server/node_modules/.pnpm/[email protected]/node_modules/path-to-regexp/dist/index.js:294:74
    at Array.map (<anonymous>)
    at pathToRegexp (/Users/nicolas/Developer/echolabs/Server/node_modules/.pnpm/[email protected]/node_modules/path-to-regexp/dist/index.js:294:25)
    at Object.match (/Users/nicolas/Developer/echolabs/Server/node_modules/.pnpm/[email protected]/node_modules/path-to-regexp/dist/index.js:264:30)
    at matcher (/Users/nicolas/Developer/echolabs/Server/node_modules/.pnpm/[email protected]/node_modules/router/lib/layer.js:86:23)
    at new Layer (/Users/nicolas/Developer/echolabs/Server/node_modules/.pnpm/[email protected]/node_modules/router/lib/layer.js:93:62)
    at Function.route (/Users/nicolas/Developer/echolabs/Server/node_modules/.pnpm/[email protected]/node_modules/router/index.js:428:17)

[krzysdz]

()[]+! are no longer supported and have been marked as reserved to prevent mistakes (see https://git.new/pathToRegexpError).

I think that there is no way to restrict a segment to one of several options, because there is no replacement for (). You can either:

• drop (foo|bar) completely - '/:collection{/:id}' and verify req.params.collection in route handler, or
• mount your handler using two different paths ['/foo{/:id}', '/bar{/:id}'], but then you have no req.params.collection.

[nidegen]

Thanks for the explanation! I agree it is not too important and ok to get removed, but it would have been handy for my little hacky egdecase:)