Documentation of "route" property of Request #2026
machineghost
started this conversation in
Content
Replies: 1 comment
-
Yes I think this is a correct change, and a PR to that effect would be great. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
This was moved from: expressjs/express#4033
It is regarding: http://expressjs.com/en/4x/api.html#req.route
The current description of the route property says (emphasis added):
However, it then shows "Example output from the previous snippet", and that previous snippet had only a single
console.log
in it:console.log(req.route)
.One would expect to see a string logged, but what's logged instead is clearly an object:
It seems like of the two must be incorrect, and that the documentation should most likely say something like:
I'd be happy to PR this, but I don't know this property at all so I don't know if that is the correct fix.
Beta Was this translation helpful? Give feedback.
All reactions