-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Open
Description
@paulhiggs in expressjs/express#6479 reported that express.text()
is missing from 5.x docs.
express.text()
and express.raw()
were added in Express 4.17.0. The 4.x documentation reflects that (18dfac1, 958e581, b49ab1b), but 5.x documentation has not been updated after changes from 4.17.0/4.17.1 were merged into 5.0/5.x branches (expressjs/express@121fe99).
TODO:
- Add
express.text()
to 5.x API docs (Reflect body-parser changes in 5.x API docs and include those that where missing #1883) - Add
express.raw()
to 5.x API docs (Reflect body-parser changes in 5.x API docs and include those that where missing #1883) - Review 4.x documentation changes and check if more changes to late 4.x versions that were later included in 5.x are missing in 5.x docs (it has already been tracked in Review and Update v5.x Documentation against v4.x #1479)
- 4.18 added
priority
option tores.cookie()
androot
option tores.download()
(5c98ee4) (Update 5x API docs with missing 4x changes #1886) - Added documentation for calling acceptsLanguages without argument #1402 improved
req.acceptsLanguages()
docs, but only the 4.x version (Update 5x API docs with missing 4x changes #1886) - 5e918ea added warning boxes to
res.render()
andapp.render()
(Update 5x API docs with missing 4x changes #1886) - fcaca7f added warnings about
locals
(Update 5x API docs with missing 4x changes #1886) - Added docs for res.cookie partitioned option #1456 documented the
partitioned
option ofres.cookie()
(Update 5x API docs with missing 4x changes #1886) - 4.x and 5.x had slightly different (and incompatible) examples for
router.param(fn)
, which doesn't even exist in Express 5 (Remove router.param(fn) from 5.x docs #1884) - a5ca5b0 changed
req.body
documentation (4.x), removing references tomulter
andbody-parser
and presenting built-in middleware. (Update 5x API docs with missing 4x changes #1886) - Update res.cookie for setting multiple cookies in a single response #1063 expanded
res.cookie()
docs, showing how to set multiple cookies (Update 5x API docs with missing 4x changes #1886)
- 4.18 added
Other differences include:
- Admonitions are used inconsistently (e.g. in 4.x
express.static()
, but not in 5.x; there are still many.doc-box
<div>
s) - One warning about open redirect was removed in 5.x
res.location()
in docs: add deprecation note for 'back' redirect in res-redirect.md and res-location.md v4 #1835 - In 4.x most strings in comments use single quotes, but in 5.x many more use double quotes (and one in
res.type()
has a typo) - In some 5x docs available in Express 4.?? onwards or similar notes have been removed (or never added), but in most places those still exist
Metadata
Metadata
Assignees
Labels
No labels