ci: run test for windows and linux

Author: ShubhamOulkar

.github/workflows/ci.yml

@@ -1,21 +1,38 @@
 name: ci
 
 on:
-- pull_request
-- push
+  push:
+    branches:
+      - main
+    paths-ignore:
+      - '*.md'
+  pull_request:
+    paths-ignore:
+      - '*.md'
 
 permissions:
   contents: read
-
 jobs:
-  test:
-    permissions:
-      checks: write  # for coverallsapp/github-action to create new checks
-      contents: read  # for actions/checkout to fetch code
+  lint:
+    name: Lint
     runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - name: Setup Node.js
+        uses: actions/setup-node@v4
+        with:
+          node-version: 'lts/*'
+
+      - name: Install dependencies
+        run: npm install --ignore-scripts --include=dev
+
+      - name: Run lint
+        run: npm run lint
+  test:
     strategy:
       fail-fast: false
       matrix:
+        os: [ubuntu-latest, windows-latest]
         name:
         - Node.js 10.x
         - Node.js 11.x
@@ -55,23 +72,23 @@ jobs:
           npm-i: [email protected]
 
         - name: Node.js 15.x
-          node-version: "15.14"
+          node-version: "15.14.0"
           npm-i: [email protected]
 
         - name: Node.js 16.x
-          node-version: "16.20"
+          node-version: "16.20.2"
 
         - name: Node.js 17.x
-          node-version: "17.9"
+          node-version: "17.9.1"
 
         - name: Node.js 18.x
-          node-version: "18.18"
+          node-version: "18.20.8"
 
         - name: Node.js 19.x
-          node-version: "19.9"
+          node-version: "19.9.0"
 
         - name: Node.js 20.x
-          node-version: "20.9"
+          node-version: "20.19.2"
 
         - name: Node.js 21.x
           node-version: "21"
@@ -85,26 +102,16 @@ jobs:
         - name: Node.js 24.x
           node-version: "24"
 
+    runs-on: ${{ matrix.os }}
     steps:
-    - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
-
-    - name: Install Node.js ${{ matrix.node-version }}
-      shell: bash -eo pipefail -l {0}
-      run: |
-        nvm install --default ${{ matrix.node-version }}
-        if [[ "${{ matrix.node-version }}" == 0.* && "$(cut -d. -f2 <<< "${{ matrix.node-version }}")" -lt 10 ]]; then
-          nvm install --alias=npm 0.10
-          nvm use ${{ matrix.node-version }}
-          if [[ "$(npm -v)" == 1.1.* ]]; then
-            nvm exec npm npm install -g [email protected]
-            ln -fs "$(which npm)" "$(dirname "$(nvm which npm)")/npm"
-          else
-            sed -i '1s;^.*$;'"$(printf '#!%q' "$(nvm which npm)")"';' "$(readlink -f "$(which npm)")"
-          fi
-          npm config set strict-ssl false
-        fi
-        dirname "$(nvm which ${{ matrix.node-version }})" >> "$GITHUB_PATH"
+    - uses: actions/checkout@v4
+      with:
+        persist-credentials: false
 
+    - name: Setup Node.js ${{ matrix.node-version }}
+      uses: actions/setup-node@v4
+      with:
+        node-version: ${{ matrix.node-version }}
     - name: Remove npm module(s) ${{ matrix.npm-rm }}
       run: npm rm --silent --save-dev ${{ matrix.npm-rm }}
       if: matrix.npm-rm != ''
@@ -116,43 +123,41 @@ jobs:
     - name: Install Node.js dependencies
       run: npm install
 
-    - name: List environment
-      id: list_env
-      shell: bash
-      run: |
-        echo "node@$(node -v)"
-        echo "npm@$(npm -v)"
-        npm -s ls ||:
-        (npm -s ls --depth=0 ||:) | awk -F'[ @]' 'NR>1 && $2 { print $2 "=" $3 }' >> "$GITHUB_OUTPUT"
-
-    - name: Lint code
-      run: npm run lint
-
     - name: Run tests
       shell: bash
-      run: |
-        if npm -ps ls nyc | grep -q nyc; then
-          npm run test-ci
-        else
-          npm test
-        fi
+      run: npm run test-ci
 
-    - name: Collect code coverage
-      uses: coverallsapp/github-action@09b709cf6a16e30b0808ba050c7a6e8a5ef13f8d # master
-      if: steps.list_env.outputs.nyc != ''
+    - name: Upload code coverage
+      uses: actions/upload-artifact@v4
       with:
-        github-token: ${{ secrets.GITHUB_TOKEN }}
-        flag-name: run-${{ matrix.test_number }}
-        parallel: true
+        name: coverage-node-${{ matrix.node-version }}-${{ matrix.os }}
+        path: ./coverage/lcov.info
+        retention-days: 1
 
   coverage:
-    permissions:
-      checks: write  # for coverallsapp/github-action to create new checks
-    needs: test
-    runs-on: ubuntu-latest
-    steps:
-    - name: Upload code coverage
-      uses: coverallsapp/github-action@09b709cf6a16e30b0808ba050c7a6e8a5ef13f8d # master
-      with:
-        github-token: ${{ secrets.GITHUB_TOKEN }}
-        parallel-finished: true
+      needs: test
+      runs-on: ubuntu-latest
+      permissions:
+        contents: read
+        checks: write
+      steps:
+        - uses: actions/checkout@v4
+  
+        - name: Install lcov
+          shell: bash
+          run: sudo apt-get -y install lcov
+  
+        - name: Collect coverage reports
+          uses: actions/download-artifact@v4
+          with:
+            path: ./coverage
+            pattern: coverage-node-*
+  
+        - name: Merge coverage reports
+          shell: bash
+          run: find ./coverage -name lcov.info -exec printf '-a %q\n' {} \; | xargs lcov -o ./lcov.info
+  
+        - name: Upload coverage report
+          uses: coverallsapp/github-action@v2
+          with:
+            file: ./lcov.info

test/disk-storage.js

@@ -10,7 +10,7 @@ var temp = require('fs-temp')
 var rimraf = require('rimraf')
 var FormData = require('form-data')
 
-function assertFileProperties(file, name) {
+function assertFileProperties (file, name) {
   const expectedSize = util.fileSizeByName(name)
   assert.strictEqual(file.fieldname, path.parse(name).name)
   assert.strictEqual(file.originalname, name)
@@ -44,7 +44,7 @@ describe('Disk Storage', function () {
 
     util.submitForm(parser, form, function (err, req) {
       assert.ifError(err)
-      
+
       assert.strictEqual(req.body.name, 'Multer')
 
       assertFileProperties(req.file, 'small0.dat')
@@ -117,7 +117,7 @@ describe('Disk Storage', function () {
       assertFileProperties(req.files.small1[0], 'small1.dat')
       assertFileProperties(req.files.medium[0], 'medium.dat')
       assertFileProperties(req.files.large[0], 'large.jpg')
-      
+
       done()
     })
   })

test/express-integration.js

@@ -70,7 +70,9 @@ describe('Express Integration', function () {
 
   it('should work when receiving error from fileFilter', function (done) {
     function fileFilter (req, file, cb) {
-      cb(new Error('TEST'))
+      if (file.mimetype !== 'image/png') {
+        return cb(new Error('Only PNG files are allowed'))
+      }
     }
 
     var upload = multer({ fileFilter: fileFilter })
@@ -80,15 +82,15 @@ describe('Express Integration', function () {
     var routeCalled = 0
     var errorCalled = 0
 
-    form.append('avatar', util.file('large.jpg'))
+    form.append('avatar', util.file('small0.dat'))
 
     router.post('/profile', upload.single('avatar'), function (req, res, next) {
       routeCalled++
       res.status(200).end('SUCCESS')
     })
 
     router.use(function (err, req, res, next) {
-      assert.strictEqual(err.message, 'TEST')
+      assert.strictEqual(err.message, 'Only PNG files are allowed')
 
       errorCalled++
       res.status(500).end('ERROR')

test/functionality.js

@@ -128,7 +128,7 @@ describe('Functionality', function () {
 
     util.submitForm(parser, form, function (err, req) {
       assert.ifError(err)
-      
+
       assert.strictEqual(req.files.length, 2)
       assert.ok(req.files[0].path.indexOf(`${path.sep}testforme-`) >= 0)
       assert.ok(req.files[1].path.indexOf(`${path.sep}testforme-`) >= 0)

test/memory-storage.js

@@ -7,7 +7,7 @@ var util = require('./_util')
 var multer = require('../')
 var FormData = require('form-data')
 
-function assertFileProperties(file, name) {
+function assertFileProperties (file, name) {
   const expectedSize = util.fileSizeByName(name)
   assert.strictEqual(file.fieldname, path.parse(name).name)
   assert.strictEqual(file.originalname, name)
@@ -69,7 +69,7 @@ describe('Memory Storage', function () {
       assert(deepEqual(req.body.checkboxempty, ['', '']))
 
       assertFileProperties(req.file, 'empty.dat')
-      
+
       done()
     })
   })