Resolve relative paths at middleware setup

Author: dougwilson

History.md

@@ -1,3 +1,7 @@
+HEAD
+
+  * Resolve relative paths at middleware setup
+
 1.0.3 / 2014-03-20
 ==================
 

index.js

@@ -10,6 +10,7 @@
  * Module dependencies.
  */
 
+var resolve = require('path').resolve;
 var send = require('send');
 var url = require('url');
 
@@ -48,6 +49,9 @@ exports = module.exports = function(root, options){
   // root required
   if (!root) throw new TypeError('root path required');
 
+  // resolve root to absolute
+  root = resolve(root);
+
   // default redirect
   var redirect = false !== options.redirect;
 

test/test.js

@@ -3,10 +3,14 @@ process.env.NODE_ENV = 'test';
 
 var connect = require('connect');
 var http = require('http');
+var path = require('path');
 var request = require('supertest');
 var serveStatic = require('..');
 
 var fixtures = __dirname + '/fixtures';
+var relative = path.relative(process.cwd(), fixtures);
+
+var skipRelative = ~relative.indexOf('..') || path.resolve(relative) === relative;
 
 describe('serveStatic()', function(){
   describe('basic operations', function(){
@@ -120,6 +124,23 @@ describe('serveStatic()', function(){
     });
   });
 
+  (skipRelative ? describe.skip : describe)('current dir', function(){
+    var server;
+    before(function () {
+      server = createServer('.');
+    });
+    after(function (done) {
+      server.close(done);
+    });
+
+    it('should be served with "."', function(done){
+      var dest = relative.split(path.sep).join('/');
+      request(server)
+      .get('/' + dest + '/todo.txt')
+      .expect(200, '- groceries', done);
+    })
+  })
+
   describe('hidden files', function(){
     var server;
     before(function () {