Skip to content

Commit 4d027d6

Browse files
committed
1 parent cb1a1eb commit 4d027d6

File tree

3 files changed

+11
-3
lines changed

3 files changed

+11
-3
lines changed

HISTORY.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@ unreleased
22
==========
33

44
* Fix redirect loop in Node.js 0.11.14
5+
6+
- Fix root path disclosure
57

68
1.8.0 / 2015-01-05
79
==================

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
"dependencies": {
99
"escape-html": "1.0.1",
1010
"parseurl": "~1.3.0",
11-
"send": "0.11.0",
11+
"send": "0.11.1",
1212
"utils-merge": "1.0.0"
1313
},
1414
"devDependencies": {

test/test.js

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -320,7 +320,7 @@ describe('serveStatic()', function(){
320320
})
321321
})
322322

323-
describe('when traversing passed root', function(){
323+
describe('when traversing past root', function(){
324324
var server;
325325
before(function () {
326326
server = createServer();
@@ -336,7 +336,13 @@ describe('serveStatic()', function(){
336336
request(server)
337337
.get('/users/%2e%2e/%2e%2e/todo.txt')
338338
.expect(403, done);
339-
});
339+
})
340+
341+
it('should not allow root path disclosure', function (done) {
342+
request(server)
343+
.get('/users/../../fixtures/todo.txt')
344+
.expect(403, done);
345+
})
340346
});
341347

342348
describe('on ENOENT', function(){

0 commit comments

Comments
 (0)