Skip to content

Commit 6fe44a0

Browse files
committed
1 parent 0b0f00b commit 6fe44a0

File tree

3 files changed

+9
-23
lines changed

3 files changed

+9
-23
lines changed

History.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ unreleased
33

44
* Fix parsing of weird `req.originalUrl` values
55
* deps: parseurl@~1.3.0
6+
67

78
1.5.0 / 2014-08-05
89
==================

index.js

Lines changed: 6 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
*/
1212

1313
var escapeHtml = require('escape-html');
14+
var merge = require('utils-merge');
1415
var parseurl = require('parseurl');
1516
var resolve = require('path').resolve;
1617
var send = require('send');
@@ -24,11 +25,12 @@ var url = require('url');
2425
*/
2526

2627
exports = module.exports = function(root, options){
27-
options = extend({}, options);
28-
2928
// root required
3029
if (!root) throw new TypeError('root path required');
3130

31+
// copy options object
32+
options = merge({}, options)
33+
3234
// resolve root to absolute
3335
root = resolve(root);
3436

@@ -49,7 +51,8 @@ exports = module.exports = function(root, options){
4951

5052
return function staticMiddleware(req, res, next) {
5153
if ('GET' != req.method && 'HEAD' != req.method) return next();
52-
var opts = extend({}, options);
54+
55+
var opts = merge({}, options)
5356
var originalUrl = parseurl.original(req);
5457
var path = parseurl(req).pathname;
5558

@@ -101,22 +104,3 @@ exports = module.exports = function(root, options){
101104
*/
102105

103106
exports.mime = send.mime;
104-
105-
/**
106-
* Shallow clone a single object.
107-
*
108-
* @param {Object} obj
109-
* @param {Object} source
110-
* @return {Object}
111-
* @api private
112-
*/
113-
114-
function extend(obj, source) {
115-
if (!source) return obj;
116-
117-
for (var prop in source) {
118-
obj[prop] = source[prop];
119-
}
120-
121-
return obj;
122-
};

package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,8 @@
88
"dependencies": {
99
"escape-html": "1.0.1",
1010
"parseurl": "~1.3.0",
11-
"send": "0.8.1"
11+
"send": "0.8.1",
12+
"utils-merge": "1.0.0"
1213
},
1314
"devDependencies": {
1415
"istanbul": "0.3.0",

0 commit comments

Comments
 (0)