deps: [email protected]

Author: dougwilson

History.md

@@ -2,6 +2,8 @@ unreleased
 ==========
 
   * Include HTML link in redirect response
+  * deps: [email protected]
+    - Accept string for `maxAge` (converted by `ms`)
 
 1.2.3 / 2014-06-11
 ==================

Readme.md

@@ -28,7 +28,7 @@ Options:
 
 - `hidden` Allow transfer of hidden files. defaults to `false`
 - `index` Default file name, defaults to `'index.html'`
-- `maxAge` Browser cache maxAge in milliseconds. defaults to `0`
+- `maxAge` Browser cache maxAge in milliseconds. This can also be a string accepted by the [ms](https://www.npmjs.org/package/ms#readme) module. defaults to `0`
 - `redirect` Redirect to trailing "/" when the pathname is a dir. defaults to `true`
 
 ## Examples

package.json

@@ -8,7 +8,7 @@
   "dependencies": {
     "escape-html": "1.0.1",
     "parseurl": "1.0.1",
-    "send": "0.4.3"
+    "send": "0.5.0"
   },
   "devDependencies": {
     "istanbul": "0.2.13",

test/test.js

@@ -128,13 +128,15 @@ describe('serveStatic()', function(){
   })
 
   describe('maxAge', function(){
-    var server;
-    before(function () {
-      server = createServer(fixtures, {'maxAge': Infinity});
-    });
+    it('should accept string', function(done){
+      request(createServer(fixtures, {'maxAge': '30d'}))
+      .get('/todo.txt')
+      .expect('cache-control', 'public, max-age=' + 60*60*24*30)
+      .expect(200, done)
+    })
 
     it('should be reasonable when infinite', function(done){
-      request(server)
+      request(createServer(fixtures, {'maxAge': Infinity}))
       .get('/todo.txt')
       .expect('cache-control', 'public, max-age=' + 60*60*24*365)
       .expect(200, done)