[WIP] Dependency map for the types of Express

[bjohansebas]

List of Express dependencies in general with their priority list.

Priority 1: Necessary to unlock the integration of the other types.
Priority 2: A direct dependency of Express and required for the types, but depends on those in Priority 1.
Priority 3: Not required to achieve the Express types but would be nice to have for the ecosystem. :)

• Express
  • expressjs/body-parser (Priority 2)
    • raw-body
    • iconv-lite (We need to update it)
    • qs (How do we want to achieve this? It’s not governed by Express, but since we don’t want to add the types as a dependency, let’s create a new issue to discuss it)
    • types-is
  • pillarjs/finalhandler (Priority 2)
  • expressjs/serve-static (Priority 1)
  • pillarjs/router (Priority 1)
    • pillarjs/parseurl
    • pillarjs/path-to-regexp
  • jshttp/vary (Priority 2)
  • jshttp/content-disposition (Priority 2)
  • jshttp/cookie v0 (Priority 2)
  • jshttp/proxy-addr (Priority 2)
    • jshttp/forwarded (Priority 2)

Note: I don't have time to finish this right now. If anyone feels like completing it, please comment on this issue and I will update it later. Or, if you have sufficient permissions to edit the issue, go ahead and do it

[malja]

Hi, I've reviewed the dependencies of the Express package, and this is a comprehensive list of them, along with their TS status:

Dependencies

Package	Types	Priority
accepts	✅ Yes	?
body-parser	✅ Yes	?
content-disposition	✅ Yes	?
content-type	✅ Yes	?
cookie	✅ Yes, natively	?
cookie-signature	✅ Yes	?
debug	✅ Yes	?
depd	✅ Yes	?
encodeurl	✅ Yes	?
fresh	✅ Yes	?
http-errors	✅ Yes	?
merge-descriptors	✅ Yes, natively	?
mime-types	✅ Yes	?
on-finished	✅ Yes	?
once	✅ Yes	?
parseurl	✅ Yes	?
proxy-addr	✅ Yes	?
qs	✅ Yes	?
range-parser	✅ Yes	?
router	❌ No	Used a lot, likely prio 1?
send	✅ Yes	?
serve-static	✅ Yes	?
statuses	✅ Yes	?
type-is	✅ Yes	?
vary	✅ Yes	?

Dev dependencies

Package	Types	Priority
after	❌ No	Part of tests, would be good
connect-redis	✅ Yes, natively	?
cookie-parser	✅ Yes	?
cookie-session	✅ Yes	?
ejs	✅ Yes	?
eslint	✅ Yes, natively	?
express-session	✅ Yes	?
hbs	✅ Yes	?
marked	✅ Yes, natively	?
method-override	✅ Yes	?
mocha	✅ Yes	?
morgan	✅ Yes	?
nyc	❌ No	Command line tool, likely not important
pbkdf2-password	❌ No	Part of examples, likely just nice to have
supertest	✅ Yes	?
vhost	✅ Yes	?

[reteps]

Is there anything to help out here? It looks like pillarjs/router#48 is open, and it's not clear whether the types will be upstreamed there or contributed to definitely-typed.

It looks like the types for after will have to be contributed directly to definitely-typed, given the age of the project. I started this in DefinitelyTyped/DefinitelyTyped#73716.