fix: revert OS specific logic for rust_sitrep() (#448)

* fix: revert OS specific logic for `rust_sitrep()`

`rust_sitrep()` no long need osx specific logic as per rustup 1.28.
Fixes #447

* tests: remove osx specific test for `rust_sitrep()` and it's snapshot

Author: albersonmiranda

R/rust_sitrep.R

@@ -115,15 +115,9 @@ rustup_toolchain_target <- function() {
   # ----------------
   #
   # stable-x86_64-pc-windows-msvc (default)
-  host <- if (is_osx() && is.na(try_exec_cmd("rustup", "show"))) {
-    output <- try_exec_cmd("rustc", c("--version", "--verbose"))
-    host_index <- grep("host:", output)
-    gsub("host: ", "", output[host_index])
-  } else {
-    try_exec_cmd("rustup", "show") |>
-      stringi::stri_sub(from = 15L) |>
-      vctrs::vec_slice(1L)
-  }
+  host <- try_exec_cmd("rustup", "show") |>
+    stringi::stri_sub(from = 15L) |>
+    vctrs::vec_slice(1L)
 
   # > rustup toolchain list
   # stable-x86_64-pc-windows-msvc

tests/testthat/_snaps/rust-sitrep.md

@@ -104,20 +104,7 @@
       ! Target required-target is required on this host machine
       i Run `rustup target add required-target` to install it
 
-# Detects host when default toolchain is not set on OSX
-
-    Code
-      rust_sitrep()
-    Message
-      Rust infrastructure sitrep:
-      v "rustup": 1.0.0 (0000000 0000-00-00)
-      v "cargo": 1.0.0 (0000000 0000-00-00)
-      i host: aarch64-apple-darwin
-      i toolchain: stable-aarch64-apple-darwin
-      ! This toolchain should be default: stable-aarch64-apple-darwin
-      i Run e.g. `rustup default stable-aarch64-apple-darwin`
-
-# Detects host when default toolchain is not set on non-OSX
+# Detects host when default toolchain is not set
 
     Code
       rust_sitrep()

tests/testthat/test-rust-sitrep.R

@@ -130,32 +130,7 @@ test_that("Required target is not available", {
   expect_snapshot(rust_sitrep())
 })
 
-test_that("Detects host when default toolchain is not set on OSX", {
-  local_mocked_bindings(is_osx = function() TRUE)
-
-  local_mocked_bindings(try_exec_cmd = function(cmd, args) {
-    if (cmd == "cargo") {
-      "cargo 1.0.0 (0000000 0000-00-00)"
-    } else if (cmd == "rustup" & all(args %in% "--version")) {
-      "rustup 1.0.0 (0000000 0000-00-00)"
-    } else if (cmd == "rustc") {
-      "host: aarch64-apple-darwin"
-    } else if (all(args %in% "--version")) {
-      "rustup 1.0.0 (0000000 0000-00-00)"
-      NA_character_
-    } else if (all(args %in% c("toolchain", "list"))) {
-      "stable-aarch64-apple-darwin"
-    } else if (all(args %in% c("target", "list", "--installed"))) {
-      NA_character_
-    } else {
-      NA_character_
-    }
-  })
-  expect_snapshot(rust_sitrep())
-})
-
-test_that("Detects host when default toolchain is not set on non-OSX", {
-  local_mocked_bindings(is_osx = function() FALSE)
+test_that("Detects host when default toolchain is not set", {
 
   local_mocked_bindings(try_exec_cmd = function(cmd, args) {
     if (cmd == "cargo") {