Skip to content

Commit 5d8aadf

Browse files
committed
fixes #137 Invalid tag metrics (percentages)
1 parent 0aac847 commit 5d8aadf

File tree

3 files changed

+40
-4
lines changed

3 files changed

+40
-4
lines changed
Lines changed: 35 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,35 @@
1+
using AventStack.ExtentReports.Model;
2+
using NUnit.Framework;
3+
4+
namespace AventStack.ExtentReports.Tests.Core
5+
{
6+
public class ExtentReportsMetricsTest
7+
{
8+
9+
private ExtentReports _extent;
10+
11+
[SetUp]
12+
public void Setup()
13+
{
14+
_extent = new ExtentReports();
15+
}
16+
17+
[Test]
18+
public void ExtentTestWithAttributeCount()
19+
{
20+
_extent.CreateTest("Test1").AssignCategory("Tag1").Pass();
21+
_extent.CreateTest("Test2").AssignCategory("Tag2").Pass();
22+
_extent.CreateTest("Test3").AssignCategory("Tag1").Fail();
23+
_extent.CreateTest("Test4").AssignCategory("Tag2").Skip();
24+
_extent.Flush();
25+
26+
var tag1Ctx = _extent.Report.CategoryCtx.Context["Tag1"];
27+
Assert.AreEqual(1, tag1Ctx.Passed);
28+
Assert.AreEqual(1, tag1Ctx.Failed);
29+
30+
var tag2Ctx = _extent.Report.CategoryCtx.Context["Tag2"];
31+
Assert.AreEqual(1, tag2Ctx.Passed);
32+
Assert.AreEqual(1, tag2Ctx.Skipped);
33+
}
34+
}
35+
}

ExtentReports.Tests/Reporter/SparkOutputTagTest.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,8 @@ public void Setup()
2222
[Test]
2323
public void TestTag()
2424
{
25-
_extent.CreateTest("Test").AssignCategory(Tag);
25+
_extent.CreateTest("Test1").AssignCategory(Tag).Pass();
26+
_extent.CreateTest("Test2").AssignCategory(Tag).Fail();
2627
_extent.Flush();
2728
var text = File.ReadAllText(Path);
2829
Assert.True(text.Contains(Tag));

ExtentReports/Views/Spark/Partials/SparkDashboardSPA.cshtml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -200,7 +200,7 @@
200200
<td>@x.Value.Failed</td>
201201
<td>@x.Value.Skipped</td>
202202
<td>@x.Value.Others</td>
203-
<td>@((x.Value.Passed/x.Value.Tests.Count)*100)%</td>
203+
<td>@((int)Math.Round((double)(100 * x.Value.Passed) / ((double)x.Value.Tests.Count)))%</td>
204204
</tr>
205205
}
206206
</tbody>
@@ -223,7 +223,7 @@
223223
<td>@x.Value.Failed</td>
224224
<td>@x.Value.Skipped</td>
225225
<td>@x.Value.Others</td>
226-
<td>@((x.Value.Passed/x.Value.Tests.Count)*100)%</td>
226+
<td>@((int)Math.Round((double)(100 * x.Value.Passed) / ((double)x.Value.Tests.Count)))%</td>
227227
</tr>
228228
}
229229
</tbody>
@@ -247,7 +247,7 @@
247247
<td>@x.Value.Failed</td>
248248
<td>@x.Value.Skipped</td>
249249
<td>@x.Value.Others</td>
250-
<td>@((x.Value.Passed/x.Value.Tests.Count)*100)%</td>
250+
<td>@((int)Math.Round((double)(100 * x.Value.Passed) / ((double)x.Value.Tests.Count)))%</td>
251251
</tr>
252252
}
253253
</tbody>

0 commit comments

Comments
 (0)