CWE-404: Improper Resource Shutdown or Release fix. (#208)

sudheshg · web-flow · commit 9a5f76488452 · 2024-06-20T16:11:55.000+05:30
diff --git a/ExtentReports/Reporter/Config/InteractiveReporterConfig.cs b/ExtentReports/Reporter/Config/InteractiveReporterConfig.cs
@@ -25,8 +25,11 @@ public class InteractiveReporterConfig : FileReporterConfig
         protected void SaveResourceToDisk(string resourceStreamPath, string savePath)
         {
             var stream = this.GetType().Assembly.GetManifestResourceStream(resourceStreamPath);
-            var text = new StreamReader(stream).ReadToEnd();
-            File.WriteAllText(savePath, text);
+            using (var sr = new StreamReader(stream))
+            {
+                var text = sr.ReadToEnd();
+                File.WriteAllText(savePath, text);
+            }
         }
 
         protected void SaveBinaryResourceToDisk(string resourceStreamPath, string savePath)

Original file line number	Diff line number	Diff line change
`@@ -25,8 +25,11 @@ public class InteractiveReporterConfig : FileReporterConfig`
`25`	`25`	`protected void SaveResourceToDisk(string resourceStreamPath, string savePath)`
`26`	`26`	`{`
`27`	`27`	`var stream = this.GetType().Assembly.GetManifestResourceStream(resourceStreamPath);`
`28`		`- var text = new StreamReader(stream).ReadToEnd();`
`29`		`- File.WriteAllText(savePath, text);`
	`28`	`+ using (var sr = new StreamReader(stream))`
	`29`	`+ {`
	`30`	`+ var text = sr.ReadToEnd();`
	`31`	`+ File.WriteAllText(savePath, text);`
	`32`	`+ }`
`30`	`33`	`}`
`31`	`34`
`32`	`35`	`protected void SaveBinaryResourceToDisk(string resourceStreamPath, string savePath)`