fixes #211 NPE on RemoveTest that does not exist

Author: anshooarora

ExtentReports.Tests/Core/ExtentReportsRemoveTestTest.cs

@@ -19,23 +19,30 @@ public void Setup()
         [Test]
         public void RemoveTest()
         {
+            _extent.RemoveTest(_test);
+            Assert.AreEqual(0, _extent.Report.Tests.Count);
+        }
+
+        [Test]
+        public void RemoveTestThatDoesNotExist()
+        {
+            _extent.RemoveTest("Default");
             Assert.AreEqual(1, _extent.Report.Tests.Count);
+            
             _extent.RemoveTest(_test);
             Assert.AreEqual(0, _extent.Report.Tests.Count);
         }
 
         [Test]
         public void RemoveTestByName()
         {
-            Assert.AreEqual(1, _extent.Report.Tests.Count);
             _extent.RemoveTest("Test");
             Assert.AreEqual(0, _extent.Report.Tests.Count);
         }
 
         [Test]
         public void RemoveTestByID()
         {
-            Assert.AreEqual(1, _extent.Report.Tests.Count);
             _extent.RemoveTest(_test.Test.Id);
             Assert.AreEqual(0, _extent.Report.Tests.Count);
         }
@@ -51,6 +58,22 @@ public void RemoveNode()
             Assert.AreEqual(0, _extent.Report.Tests.ToList()[0].Children.Count);
         }
 
+        [Test]
+        public void RemoveNodeThatDoesNotExist()
+        {
+            var node = _test.CreateNode("Node");
+            Assert.AreEqual(1, _extent.Report.Tests.Count);
+            Assert.AreEqual(1, _extent.Report.Tests.ToList()[0].Children.Count);
+
+            _extent.RemoveTest("DefaultNode");
+            Assert.AreEqual(1, _extent.Report.Tests.Count);
+            Assert.AreEqual(1, _extent.Report.Tests.ToList()[0].Children.Count);
+
+            _extent.RemoveTest(node);
+            Assert.AreEqual(1, _extent.Report.Tests.Count);
+            Assert.AreEqual(0, _extent.Report.Tests.ToList()[0].Children.Count);
+        }
+
         [Test]
         public void RemoveNodeByName()
         {

ExtentReports.Tests/Reporter/SparkReporterTest.cs

@@ -140,7 +140,7 @@ public void SparkOffline()
         [Test]
         public void SparkXMLConfig()
         {
-            var xmlConfigPath = Path.Combine(@"..\..\..\..\", @"config\spark-config.xml");
+            var xmlConfigPath = Path.Combine(@"../../../../", @"config/spark-config.xml");
             var spark = new ExtentSparkReporter("Spark.html");
             spark.LoadXMLConfig(xmlConfigPath);
             Assert.AreEqual(spark.Config.Theme, Theme.Standard);
@@ -151,7 +151,7 @@ public void SparkXMLConfig()
         [Test]
         public void SparkJSONConfig()
         {
-            var xmlConfigPath = Path.Combine(@"..\..\..\..\", @"config\spark-config.json");
+            var xmlConfigPath = Path.Combine(@"../../../../", @"config/spark-config.json");
             var spark = new ExtentSparkReporter("Spark.html");
             spark.LoadJSONConfig(xmlConfigPath);
             Assert.AreEqual(spark.Config.Theme, Theme.Standard);

ExtentReports/Core/AbstractProcessor.cs

@@ -45,7 +45,7 @@ protected internal void OnMediaAdded(Media m, Log log, Test test)
 
         private void TryResolveMediaPath(Media media)
         {
-            if (_mediaResolverPath == null || (media is ScreenCapture && ((ScreenCapture)media).Base64 != null))
+            if (_mediaResolverPath == null || (media is ScreenCapture capture && capture.Base64 != null))
             {
                 return;
             }

ExtentReports/Model/Report.cs

@@ -74,9 +74,14 @@ public void AddTest(Test test)
 
         public void RemoveTest(IList<Test> tests, Test test, bool deep = true)
         {
-            var item = tests.SingleOrDefault(x => x.Id == test.Id);
+            if (test == null) 
+            {
+                return;
+            } 
+
+            var match = tests.Any(x => x.Id == test.Id);
 
-            if (item == null && deep)
+            if (!match && deep)
             {
                 foreach (Test t in tests)
                 {