Skip to content

Commit dc5d081

Browse files
committed
fixes #235
1 parent c3e999c commit dc5d081

File tree

4 files changed

+17
-10
lines changed

4 files changed

+17
-10
lines changed

reporters/klov/src/main/java/com/aventstack/extentreports/reporter/ExtentKlovReporter.java

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -656,7 +656,7 @@ public synchronized void onLogAdded(Test test, Log log) {
656656
exceptionCollection.updateOne(new Document("_id", docException.getObjectId("_id")),
657657
new Document("$set", doc));
658658
doc = new Document("exception", exceptionNameObjectIdCollection.get(ex.getName()))
659-
.append("exceptionName", ex.getName());
659+
.append("exceptionName", ex.getName());
660660
testCollection.updateOne(new Document("_id", test.getInfoMap().get(ID_KEY)), new Document("$set", doc));
661661
updateTestDesc(test);
662662
}
@@ -704,10 +704,10 @@ public void onSubscribe(Disposable d) {
704704
@Override
705705
public void onNext(MediaEntity value) {
706706
try {
707-
if (value.getTest() != null)
708-
onScreenCaptureAdded(value.getTest(), (ScreenCapture) value.getMedia());
709707
if (value.getLog() != null)
710-
onScreenCaptureAdded(value.getLog(), (ScreenCapture) value.getMedia());
708+
onScreenCaptureAdded(value.getLog(), value.getTest(), (ScreenCapture) value.getMedia());
709+
else if (value.getTest() != null)
710+
onScreenCaptureAdded(value.getTest(), (ScreenCapture) value.getMedia());
711711
} catch (IOException e) {
712712
e.printStackTrace();
713713
}
@@ -728,8 +728,12 @@ public void onScreenCaptureAdded(Test test, ScreenCapture screenCapture) throws
728728
saveScreenCapture(test, screenCapture);
729729
}
730730

731-
public void onScreenCaptureAdded(Log log, ScreenCapture screenCapture) throws IOException {
731+
public void onScreenCaptureAdded(Log log, Test test, ScreenCapture screenCapture) throws IOException {
732732
screenCapture.getInfoMap().put(LOG_ID_KEY, log.getInfoMap().get(ID_KEY));
733+
screenCapture.getInfoMap().put(TEST_ID_KEY, test.getInfoMap().get(ID_KEY));
734+
logCollection.updateOne(
735+
new Document("_id", log.getInfoMap().get(ID_KEY)),
736+
new Document("$set", new Document("mediaCount", 1)));
733737
saveScreenCapture(log, screenCapture);
734738
}
735739

src/main/java/com/aventstack/extentreports/AbstractProcessor.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,9 +53,9 @@ protected void onMediaAdded(Media m, Test test) {
5353
}
5454

5555
@Override
56-
protected void onMediaAdded(Media m, Log log) {
56+
protected void onMediaAdded(Media m, Log log, Test test) {
5757
tryResolvePath(m);
58-
super.onMediaAdded(m, log);
58+
super.onMediaAdded(m, log, test);
5959
}
6060

6161
private void tryResolvePath(Media m) {

src/main/java/com/aventstack/extentreports/ExtentTest.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -364,11 +364,14 @@ public ExtentTest log(Status status, String details, Throwable t, Media media) {
364364
.build();
365365
ExceptionInfo exceptionInfo = ExceptionInfoService.createExceptionInfo(t);
366366
log.setException(exceptionInfo);
367-
log.addMedia(media);
368367
if (exceptionInfo != null)
369368
model.getExceptions().add(exceptionInfo);
370369
model.addLog(log);
371370
extent.onLogCreated(log, model);
371+
if (media != null) {
372+
log.addMedia(media);
373+
extent.onMediaAdded(media, log, model);
374+
}
372375
return this;
373376
}
374377

src/main/java/com/aventstack/extentreports/ReactiveSubject.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,8 +75,8 @@ protected void onMediaAdded(Media m, Test test) {
7575
mediaSubject.onNext(MediaEntity.builder().media(m).test(test).build());
7676
}
7777

78-
protected void onMediaAdded(Media m, Log log) {
79-
mediaSubject.onNext(MediaEntity.builder().media(m).log(log).build());
78+
protected void onMediaAdded(Media m, Log log, Test test) {
79+
mediaSubject.onNext(MediaEntity.builder().media(m).test(test).log(log).build());
8080
}
8181

8282
protected void onFlush() {

0 commit comments

Comments
 (0)