Skip to content

Commit 3672a17

Browse files
committed
fixes #2
1 parent 642992d commit 3672a17

File tree

3 files changed

+30
-10
lines changed

3 files changed

+30
-10
lines changed

src/main/java/com/aventstack/extentreports/service/ExtentTestManager.java

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
import org.testng.ITestResult;
99

1010
import com.aventstack.extentreports.ExtentTest;
11+
import com.aventstack.extentreports.Status;
1112
import com.aventstack.extentreports.model.Test;
1213
import com.aventstack.extentreports.testng.listener.commons.ExtentTestCommons;
1314

@@ -94,5 +95,28 @@ private static synchronized ExtentTest createTest(ITestResult result, ExtentTest
9495
ExtentTestCommons.assignGroups(test, groups);
9596
return test;
9697
}
98+
99+
public static synchronized void log(ITestResult result) {
100+
String msg = "Test ";
101+
Status status = Status.PASS;
102+
switch (result.getStatus()) {
103+
case ITestResult.SKIP:
104+
status = Status.SKIP;
105+
msg += "skipped";
106+
break;
107+
case ITestResult.FAILURE:
108+
status = Status.FAIL;
109+
msg += "failed";
110+
break;
111+
default:
112+
msg += "passed";
113+
break;
114+
}
115+
if (result.getThrowable() != null) {
116+
ExtentTestManager.getTest(result).log(status, result.getThrowable());
117+
return;
118+
}
119+
ExtentTestManager.getTest(result).log(status, msg);
120+
}
97121

98122
}

src/main/java/com/aventstack/extentreports/testng/listener/ExtentITestListenerAdapter.java

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -27,21 +27,17 @@ public synchronized void onTestStart(ITestResult result) {
2727

2828
@Override
2929
public synchronized void onTestSuccess(ITestResult result) {
30-
ExtentTestManager.getTest(result).pass("Test passed");
30+
ExtentTestManager.log(result);
3131
}
3232

3333
@Override
3434
public synchronized void onTestFailure(ITestResult result) {
35-
ExtentTestManager.getTest(result).fail(result.getThrowable());
35+
ExtentTestManager.log(result);
3636
}
3737

3838
@Override
3939
public synchronized void onTestSkipped(ITestResult result) {
40-
if (result.getThrowable() == null) {
41-
ExtentTestManager.getTest(result).skip("Test skipped");
42-
return;
43-
}
44-
ExtentTestManager.getTest(result).skip(result.getThrowable());
40+
ExtentTestManager.log(result);
4541
}
4642

4743
@Override

src/main/java/com/aventstack/extentreports/testng/listener/ExtentITestListenerClassAdapter.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,17 +27,17 @@ public synchronized void onTestStart(ITestResult result) {
2727

2828
@Override
2929
public synchronized void onTestSuccess(ITestResult result) {
30-
ExtentTestManager.getTest(result).pass("Test passed");
30+
ExtentTestManager.log(result);
3131
}
3232

3333
@Override
3434
public synchronized void onTestFailure(ITestResult result) {
35-
ExtentTestManager.getTest(result).fail(result.getThrowable());
35+
ExtentTestManager.log(result);
3636
}
3737

3838
@Override
3939
public synchronized void onTestSkipped(ITestResult result) {
40-
ExtentTestManager.getTest(result).skip(result.getThrowable());
40+
ExtentTestManager.log(result);
4141
}
4242

4343
@Override

0 commit comments

Comments
 (0)