Skip to content

Commit 6641f02

Browse files
committed
fixes #17
1 parent 799eb25 commit 6641f02

File tree

3 files changed

+12
-49
lines changed

3 files changed

+12
-49
lines changed

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
<groupId>com.aventstack</groupId>
77
<artifactId>extentreports-testng-adapter</artifactId>
8-
<version>1.2.0</version>
8+
<version>1.2.1-SNAPSHOT</version>
99
<name>extentreports-testng-adapter</name>
1010
<url>http://extentreports.com</url>
1111
<description>TestNG adapter for Extent Framework</description>
Lines changed: 4 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
package com.aventstack.extentreports.testng.listener;
22

3-
import org.testng.IInvokedMethod;
4-
import org.testng.IInvokedMethodListener;
53
import org.testng.ITestContext;
64
import org.testng.ITestListener;
75
import org.testng.ITestResult;
@@ -10,9 +8,7 @@
108
import com.aventstack.extentreports.service.ExtentService;
119
import com.aventstack.extentreports.service.ExtentTestManager;
1210

13-
public class ExtentITestListenerAdapter implements ITestListener, IInvokedMethodListener {
14-
15-
private Boolean createdMethodBeforeInvocation = false;
11+
public class ExtentITestListenerAdapter implements ITestListener {
1612

1713
@Override
1814
public synchronized void onStart(ITestContext context) {
@@ -26,8 +22,7 @@ public synchronized void onFinish(ITestContext context) {
2622

2723
@Override
2824
public synchronized void onTestStart(ITestResult result) {
29-
if (!createdMethodBeforeInvocation)
30-
ExtentTestManager.createMethod(result);
25+
ExtentTestManager.createMethod(result);
3126
}
3227

3328
@Override
@@ -42,27 +37,11 @@ public synchronized void onTestFailure(ITestResult result) {
4237

4338
@Override
4439
public synchronized void onTestSkipped(ITestResult result) {
45-
if (result.wasRetried()) {
46-
ExtentService.getInstance().removeTest(result.getName());
47-
} else
48-
ExtentTestManager.log(result);
40+
ExtentTestManager.log(result);
4941
}
5042

5143
@Override
5244
public synchronized void onTestFailedButWithinSuccessPercentage(ITestResult result) {
5345
}
5446

55-
@Override
56-
public void beforeInvocation(IInvokedMethod method, ITestResult testResult) {
57-
if (method.getTestMethod().isBeforeMethodConfiguration()) {
58-
createdMethodBeforeInvocation = true;
59-
ExtentTestManager.createMethod(testResult);
60-
}
61-
}
62-
63-
@Override
64-
public void afterInvocation(IInvokedMethod method, ITestResult testResult) {
65-
66-
}
67-
68-
}
47+
}
Lines changed: 7 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
11
package com.aventstack.extentreports.testng.listener;
22

3-
import org.testng.*;
3+
import org.testng.ITestContext;
4+
import org.testng.ITestListener;
5+
import org.testng.ITestResult;
46

57
import com.aventstack.extentreports.AnalysisStrategy;
68
import com.aventstack.extentreports.service.ExtentService;
79
import com.aventstack.extentreports.service.ExtentTestManager;
810

9-
public class ExtentITestListenerClassAdapter implements ITestListener, IInvokedMethodListener {
10-
11-
private Boolean createdMethodBeforeInvocation = false;
11+
public class ExtentITestListenerClassAdapter implements ITestListener {
1212

1313
@Override
1414
public synchronized void onStart(ITestContext context) {
@@ -22,8 +22,7 @@ public synchronized void onFinish(ITestContext context) {
2222

2323
@Override
2424
public synchronized void onTestStart(ITestResult result) {
25-
if (!createdMethodBeforeInvocation)
26-
ExtentTestManager.createMethod(result, true);
25+
ExtentTestManager.createMethod(result, true);
2726
}
2827

2928
@Override
@@ -38,26 +37,11 @@ public synchronized void onTestFailure(ITestResult result) {
3837

3938
@Override
4039
public synchronized void onTestSkipped(ITestResult result) {
41-
if (result.wasRetried()) {
42-
ExtentService.getInstance().removeTest(result.getName());
43-
} else
44-
ExtentTestManager.log(result);
40+
ExtentTestManager.log(result, true);
4541
}
4642

4743
@Override
4844
public synchronized void onTestFailedButWithinSuccessPercentage(ITestResult result) {
4945
}
5046

51-
@Override
52-
public void beforeInvocation(IInvokedMethod method, ITestResult testResult) {
53-
if (method.getTestMethod().isBeforeMethodConfiguration()) {
54-
createdMethodBeforeInvocation = true;
55-
ExtentTestManager.createMethod(testResult, true);
56-
}
57-
}
58-
59-
@Override
60-
public void afterInvocation(IInvokedMethod method, ITestResult testResult) {
61-
62-
}
63-
}
47+
}

0 commit comments

Comments
 (0)