Skip to content

feat: Allow users to configure labels#72

Merged
Skarlso merged 1 commit intoexternal-secrets:mainfrom
brookelew:configurable-labels
Feb 15, 2026
Merged

feat: Allow users to configure labels#72
Skarlso merged 1 commit intoexternal-secrets:mainfrom
brookelew:configurable-labels

Conversation

@brookelew
Copy link
Contributor

@brookelew brookelew commented Feb 13, 2026 •
edited
Loading

Problem Statement

Chart lacks a way to configure labels

Related Issue

#71

Proposed Changes

Allow configuring labels for deployed resources

Checklist

  • I have read the contribution guidelines
  • All commits are signed with git commit --signoff
  • My changes have reasonable test coverage
  • All tests pass with make test
  • I ensured my PR is ready for review with make reviewable

Summary

Adds support for configuring labels and annotations across Helm chart resources. Updates include:

  • values.yaml: Introduces new configuration options for commonLabels, serviceAccount.labels, podLabels, deploymentLabels, podAnnotations, deploymentAnnotations, service.labels, and service.annotations
  • _helpers.tpl: Adds conditional rendering of commonLabels in the bitwarden-sdk-server.labels template
  • deployment.yaml: Adds conditional rendering of deploymentLabels and podLabels
  • service.yaml: Adds conditional rendering of service.labels and service.annotations
  • serviceaccount.yaml: Adds conditional rendering of serviceAccount.labels

All changes are backward compatible and only apply when the corresponding values are provided.

@brookelew
Allow users to configure labels
b3e8b6a 
Signed-off-by: Brooke Lew <contact@brookelew.com>
@coderabbitai
Copy link

coderabbitai bot commented Feb 13, 2026 •
edited
Loading

Walkthrough

The Bitwarden SDK Server Helm chart templates and values were extended to support optional labeling and annotation of Kubernetes resources. Conditional rendering blocks were added across multiple templates to consume label and annotation configurations, with corresponding new fields introduced in the values file.

Changes

Cohort / File(s) Summary
Template Customizations
deploy/charts/bitwarden-sdk-server/templates/_helpers.tpl, deploy/charts/bitwarden-sdk-server/templates/deployment.yaml, deploy/charts/bitwarden-sdk-server/templates/service.yaml, deploy/charts/bitwarden-sdk-server/templates/serviceaccount.yaml		 Added conditional blocks to render optional labels and annotations. Helper template now includes commonLabels; deployment adds deploymentLabels and podLabels; service adds service.labels and service.annotations; service account adds serviceAccount.labels. All use toYaml for proper YAML indentation.
Configuration Values
deploy/charts/bitwarden-sdk-server/values.yaml		 Introduced 8 new configuration sections: commonLabels, serviceAccount.labels, podLabels, deploymentLabels, podAnnotations, deploymentAnnotations, service.labels, and service.annotations to enable resource customization at deployment time.
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Merge Conflict Detection ✅ Passed ✅ No merge conflicts detected when merging into main

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

No actionable comments were generated in the recent review. 🎉

🧹 Recent nitpick comments
deploy/charts/bitwarden-sdk-server/templates/_helpers.tpl (1)

54-56: Minor: extra blank line in rendered output.

Line 55 uses {{ toYaml (no left-trim), while the }} on line 54 preserves its trailing newline. This produces a blank line between the standard labels and commonLabels in the rendered manifest. Not a functional issue (YAML ignores blank lines), but for clean output, trim the left whitespace:

Suggested fix 
 {{- if .Values.commonLabels }}
-{{ toYaml .Values.commonLabels }}
+{{- toYaml .Values.commonLabels }}
 {{- end }}

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Skarlso
Skarlso approved these changes Feb 15, 2026
View reviewed changes
Copy link
Collaborator

@Skarlso Skarlso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvement! :)

@Skarlso Skarlso merged commit b33ab31 into external-secrets:main Feb 15, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Skarlso Skarlso Skarlso approved these changes

Assignees

No one assigned

Labels

None yet

Projects

External Secrets
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@brookelew @Skarlso