fix(core): verify data items with path attribute when using naming conventions. (#800)

* Fixes naming convention permission check for data items with path attribute.

Author: vladlosev

lib/poller.js

@@ -281,6 +281,15 @@ class Poller {
     // Testing data property
     if (namingConvention && externalData) {
       externalData.forEach((secretProperty, index) => {
+        if (secretProperty.path) {
+          if (!reNaming.test(secretProperty.path)) {
+            allowed = false
+            reason = `path ${secretProperty.path} does not match naming convention ${namingConvention}`
+            return {
+              allowed, reason
+            }
+          }
+        }
         if (!reNaming.test(secretProperty.key)) {
           allowed = false
           reason = `key name ${secretProperty.key} does not match naming convention ${namingConvention}`

lib/poller.test.js

@@ -982,6 +982,26 @@ describe('Poller', () => {
           },
           permitted: false
         },
+        {
+          // test regex on path
+          ns: { metadata: { annotations: { [namingPermittedAnnotation]: 'dev/team-a/.*' } } },
+          descriptor: {
+            data: [
+              { path: 'dev/team-b/secret' }
+            ]
+          },
+          permitted: false
+        },
+        {
+          // test regex on path when key is also specified
+          ns: { metadata: { annotations: { [namingPermittedAnnotation]: 'dev/team-a/.*' } } },
+          descriptor: {
+            data: [
+              { path: 'dev/team-b/secret', key: 'dev/team-a/secret' }
+            ]
+          },
+          permitted: false
+        },
         {
           // test regex
           ns: { metadata: { annotations: { [namingPermittedAnnotation]: 'dev/team-a/.*' } } },