Skip to content

Commit 2458733

Browse files
committed
fix(globals)!: disabled $_REQUEST super global function
BREAKING CHANGE: If you used `http_request_vars()` before it will now panic until a proper implementation is found. Refs: #331
1 parent 0d9496b commit 2458733

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

src/zend/globals.rs

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -284,9 +284,10 @@ impl ProcessGlobals {
284284

285285
/// Get the HTTP Request variables. Equivalent of $_REQUEST.
286286
pub fn http_request_vars(&self) -> &ZendHashTable {
287-
self.http_globals[TRACK_VARS_REQUEST as usize]
288-
.array()
289-
.expect("Type is not a ZendArray")
287+
todo!("$_REQUEST super global was erroneously fetched from http_globals which resulted in an out-of-bounds access. A new implementation is needed.");
288+
// self.http_globals[TRACK_VARS_REQUEST as usize]
289+
// .array()
290+
// .expect("Type is not a ZendArray")
290291
}
291292

292293
/// Get the HTTP Environment variables. Equivalent of $_ENV.

0 commit comments

Comments
 (0)