fix: support defaults for calls with named arguments

Signed-off-by: Dmitry Dygalo <[email protected]>
Fixes: #490

Author: Stranger6667

src/args.rs

@@ -168,6 +168,7 @@ impl<'a> Arg<'a> {
             )
             .ok_or(Error::InvalidCString)?,
             default_value: match &self.default_value {
+                Some(val) if val.as_str() == "None" => CString::new("null")?.into_raw(),
                 Some(val) => CString::new(val.as_str())?.into_raw(),
                 None => ptr::null(),
             },

tests/src/integration/defaults/defaults.php

@@ -4,3 +4,6 @@
 assert(test_defaults_integer(12) === 12);
 assert(test_defaults_nullable_string() === null);
 assert(test_defaults_nullable_string('test') === 'test');
+assert(test_defaults_multiple_option_arguments() === 'Default');
+assert(test_defaults_multiple_option_arguments(a: 'a') === 'a');
+assert(test_defaults_multiple_option_arguments(b: 'b') === 'b');

tests/src/integration/defaults/mod.rs

@@ -12,10 +12,20 @@ pub fn test_defaults_nullable_string(a: Option<String>) -> Option<String> {
     a
 }
 
+#[php_function]
+#[php(defaults(a = None, b = None))]
+pub fn test_defaults_multiple_option_arguments(
+    a: Option<String>,
+    b: Option<String>,
+) -> PhpResult<String> {
+    Ok(a.or(b).unwrap_or_else(|| "Default".to_string()))
+}
+
 pub fn build_module(builder: ModuleBuilder) -> ModuleBuilder {
     builder
         .function(wrap_function!(test_defaults_integer))
         .function(wrap_function!(test_defaults_nullable_string))
+        .function(wrap_function!(test_defaults_multiple_option_arguments))
 }
 
 #[cfg(test)]