ci: add musl build step

Author: ptondereau

.cargo/config.toml

@@ -6,3 +6,6 @@ linker = "rust-lld"
 
 [target.i686-pc-windows-msvc]
 linker = "rust-lld"
+
+[target.'cfg(target_env = "musl")']
+rustflags = ["-C", "target-feature=-crt-static"]

.github/action/musl/Dockerfile

@@ -0,0 +1,66 @@
+FROM alpine:3.20
+
+ARG PHP_VERSION=8.4
+ARG TS=ts
+
+RUN apk add --no-cache \
+    autoconf \
+    automake \
+    bison \
+    re2c \
+    gcc \
+    g++ \
+    make \
+    musl-dev \
+    linux-headers \
+    pkgconfig \
+    curl \
+    jq \
+    llvm17 \
+    llvm17-dev \
+    llvm17-libs \
+    llvm17-static \
+    clang17 \
+    clang17-dev \
+    clang17-static \
+    zlib-static \
+    ncurses-static \
+    libffi-dev \
+    libstdc++-dev
+
+WORKDIR /tmp
+RUN FULL_VERSION=$(curl -fsSL "https://www.php.net/releases/index.php?json&version=${PHP_VERSION}" | jq -r '.version') && \
+    echo "Downloading PHP ${FULL_VERSION}..." && \
+    curl -fsSL "https://www.php.net/distributions/php-${FULL_VERSION}.tar.gz" -o php.tar.gz && \
+    tar -xzf php.tar.gz && \
+    rm php.tar.gz && \
+    mv "php-${FULL_VERSION}" php-src
+
+WORKDIR /tmp/php-src
+RUN CONFIGURE_OPTS="--enable-debug --enable-embed=shared --disable-all --disable-cgi" && \
+    if [ "$TS" = "ts" ]; then CONFIGURE_OPTS="$CONFIGURE_OPTS --enable-zts"; fi && \
+    ./configure $CONFIGURE_OPTS --prefix=/usr/local && \
+    make -j$(nproc) && \
+    make install && \
+    rm -rf /tmp/php-src
+
+RUN curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y --default-toolchain stable
+ENV PATH="/root/.cargo/bin:${PATH}"
+
+RUN rustup target add x86_64-unknown-linux-musl
+RUN cargo install cargo-expand --locked
+
+ENV PHP=/usr/local/bin/php
+ENV PHP_CONFIG=/usr/local/bin/php-config
+
+ENV LLVM_CONFIG_PATH=/usr/lib/llvm17/bin/llvm-config
+ENV LIBCLANG_PATH=/usr/lib/llvm17/lib
+ENV LD_LIBRARY_PATH=/usr/local/lib:/usr/lib
+ENV RUSTFLAGS="-C target-feature=-crt-static -C link-arg=-Wl,-rpath,/usr/local/lib -L /usr/local/lib"
+
+WORKDIR /workspace
+
+COPY . .
+
+ENTRYPOINT ["cargo"]
+CMD ["build", "--release", "--no-default-features", "--features", "closure,anyhow,runtime,enum", "--workspace", "--target", "x86_64-unknown-linux-musl"]

.github/workflows/build.yml

@@ -168,7 +168,6 @@ jobs:
         # Macos fails on unstable rust. We skip the inline examples test for now.
         if: "!(contains(matrix.os, 'macos') && matrix.rust == 'nightly')"
         run: cargo test --release --workspace --features closure,anyhow,runtime --no-fail-fast
-
   test-embed:
     name: Test with embed
     runs-on: ubuntu-latest
@@ -226,3 +225,45 @@ jobs:
 
       - name: Test with embed feature
         run: cargo test --workspace --release --features closure,embed,anyhow --no-fail-fast
+
+  build-musl:
+    name: musl
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        php: ["8.1", "8.2", "8.3", "8.4"]
+        phpts: [ts, nts]
+    env:
+      CARGO_TERM_COLOR: always
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v5
+      - name: Setup DockerX 
+        uses: docker/setup-buildx-action@v3
+      - name: Build
+        uses: docker/build-push-action@v6
+        with:
+          context: .github/action/musl
+          file: .github/action/musl/Dockerfile
+          tags: |
+            extphprs/ext-php-rs:musl-${{ matrix.php }}-${{ matrix.phpts }}
+          push: false
+          load: true
+          platforms: linux/amd64
+          build-args: |
+            PHP_VERSION=${{ matrix.php }}
+            TS=${{ matrix.phpts }}
+      - name: Build
+        run: |
+          docker run \
+            -v $(pwd):/workspace \
+            -w /workspace \
+            extphprs/ext-php-rs:musl-${{ matrix.php }}-${{ matrix.phpts }} \
+            build --release --features closure,embed,anyhow,runtime --workspace
+      - name: Run tests
+        run: |
+          docker run \
+            -v $(pwd):/workspace \
+            -w /workspace \
+            extphprs/ext-php-rs:musl-${{ matrix.php }}-${{ matrix.phpts }} \
+            test --workspace --release --features closure,embed,anyhow,runtime --no-fail-fast --lib --bins --test module_tests --test sapi_tests

Dockerfile

@@ -8,14 +8,20 @@ apt update -y
 apt install -y \
   libclang-dev \
   bison \
-  re2c
+  re2c \
+  curl \
+  jq
+
+# Download and extract PHP
+FULL_VERSION=$(curl -fsSL "https://www.php.net/releases/index.php?json&version=${PHP_VERSION}" | jq -r '.version')
+echo "Downloading PHP ${FULL_VERSION}..."
+curl -fsSL "https://www.php.net/distributions/php-${FULL_VERSION}.tar.gz" -o php.tar.gz
+tar -xzf php.tar.gz
+rm php.tar.gz
+mv "php-${FULL_VERSION}" php-src
 
 # Build PHP
-git clone --depth 1 -b PHP-${PHP_VERSION} https://github.com/php/php-src.git
 cd php-src
-# by default you will be on the master branch, which is the current
-# development version. You can check out a stable branch instead:
-./buildconf
 ./configure \
     --enable-debug \
     --disable-all --disable-cgi

README.md

@@ -126,6 +126,16 @@ best resource at the moment. This can be viewed at [docs.rs].
     1.57 at the time of writing.
 - Clang 5.0 or later.
 
+### Alpine Linux (musl)
+
+Building for Alpine Linux (musl libc) is supported on stable Rust with dynamic linking
+thanks to `runtime` feature flag from `bindgen`.
+
+**Note**: Building for musl requires dynamic CRT linking (`-crt-static` flag) to produce
+the `cdylib` output required for PHP extensions.
+If you want to build statically, you'll need full LLVM + Clang toolchain.
+Please read: https://github.com/KyleMayes/clang-sys#static 
+
 ### Windows Requirements
 
 - Extensions can only be compiled for PHP installations sourced from

src/builders/sapi.rs

@@ -428,7 +428,15 @@ pub type SapiRegisterServerVariablesFunc = extern "C" fn(vars: *mut Zval);
 pub type SapiLogMessageFunc = extern "C" fn(message: *const c_char, syslog_type_int: c_int);
 
 /// A function to be called when PHP gets the request time
-pub type SapiRequestTimeFunc = extern "C" fn(time: *mut f64) -> c_int;
+///
+/// Note: Signature changed in PHP 8.2:
+/// - PHP 8.1 and earlier: `unsafe extern "C" fn() -> f64` (returns time directly)
+/// - PHP 8.2+: `unsafe extern "C" fn(time: *mut f64) -> c_int` (writes to pointer)
+#[cfg(not(php82))]
+pub type SapiRequestTimeFunc = unsafe extern "C" fn() -> f64;
+
+#[cfg(php82)]
+pub type SapiRequestTimeFunc = unsafe extern "C" fn(time: *mut f64) -> c_int;
 
 /// A function to be called when PHP terminates the process
 pub type SapiTerminateProcessFunc = extern "C" fn();
@@ -480,9 +488,17 @@ mod test {
     }
     extern "C" fn test_register_server_variables(_vars: *mut Zval) {}
     extern "C" fn test_log_message(_message: *const c_char, _syslog_type_int: c_int) {}
-    extern "C" fn test_get_request_time(_time: *mut f64) -> c_int {
+
+    #[cfg(not(php82))]
+    unsafe extern "C" fn test_get_request_time() -> f64 {
+        0.0
+    }
+
+    #[cfg(php82)]
+    unsafe extern "C" fn test_get_request_time(_time: *mut f64) -> c_int {
         0
     }
+
     extern "C" fn test_terminate_process() {}
     extern "C" fn test_get_target_uid(_uid: *mut uid_t) -> c_int {
         0

src/embed/mod.rs

@@ -105,6 +105,15 @@ impl Embed {
             zend_stream_init_filename(&raw mut file_handle, path.as_ptr());
         }
 
+        // php_execute_script returns different types across PHP versions:
+        // PHP 8.1 and earlier: returns i32 (ZEND_RESULT_CODE: 0 = success, -1 = failure)
+        // PHP 8.2+: returns bool (true = success, false = failure)
+        #[cfg(not(php82))]
+        let exec_result = try_catch(|| unsafe {
+            php_execute_script(&raw mut file_handle) == ZEND_RESULT_CODE_SUCCESS
+        });
+
+        #[cfg(php82)]
         let exec_result = try_catch(|| unsafe { php_execute_script(&raw mut file_handle) });
 
         unsafe { zend_destroy_file_handle(&raw mut file_handle) }

tests/Cargo.toml

@@ -1,16 +1,20 @@
 [package]
 name = "tests"
 version = "0.0.0"
-edition = "2021"
+edition = "2024"
 publish = false
 license = "MIT OR Apache-2.0"
 
 [dependencies]
-ext-php-rs = { path = "../", default-features = false, features = ["closure", "runtime"] }
+ext-php-rs = { path = "../", default-features = false }
 
 [features]
-default = ["enum"]
+default = ["enum", "runtime", "closure"]
 enum = ["ext-php-rs/enum"]
+anyhow = ["ext-php-rs/anyhow"]
+runtime = ["ext-php-rs/runtime"]
+closure = ["ext-php-rs/closure"]
+static = ["ext-php-rs/static"]
 
 [lib]
 crate-type = ["cdylib"]

tests/src/integration/mod.rs

@@ -31,16 +31,41 @@ mod test {
     fn setup() {
         BUILD.call_once(|| {
             let mut command = Command::new("cargo");
-            command.arg("build").arg("--no-default-features");
-            #[cfg(feature = "enum")]
+            command.arg("build");
+
+            #[cfg(not(debug_assertions))]
+            command.arg("--release");
+
+            // Build features list dynamically based on compiled features
+            // Note: Using vec_init_then_push pattern here is intentional due to conditional compilation
+            #[allow(clippy::vec_init_then_push)]
             {
-                command.arg("--features=enum");
+                let mut features = vec![];
+                #[cfg(feature = "enum")]
+                features.push("enum");
+                #[cfg(feature = "closure")]
+                features.push("closure");
+                #[cfg(feature = "anyhow")]
+                features.push("anyhow");
+                #[cfg(feature = "runtime")]
+                features.push("runtime");
+                #[cfg(feature = "static")]
+                features.push("static");
+
+                if !features.is_empty() {
+                    command.arg("--no-default-features");
+                    command.arg("--features").arg(features.join(","));
+                }
             }
-            assert!(command
-                .output()
-                .expect("failed to build extension")
-                .status
-                .success());
+
+            let result = command.output().expect("failed to execute cargo build");
+
+            assert!(
+                result.status.success(),
+                "Extension build failed:\nstdout: {}\nstderr: {}",
+                String::from_utf8_lossy(&result.stdout),
+                String::from_utf8_lossy(&result.stderr)
+            );
         });
     }
 
@@ -99,7 +124,12 @@ mod test {
         let mut path = env::current_dir().expect("Could not get cwd");
         path.pop();
         path.push("target");
+
+        #[cfg(not(debug_assertions))]
+        path.push("release");
+        #[cfg(debug_assertions)]
         path.push("debug");
+
         path.push(if std::env::consts::DLL_EXTENSION == "dll" {
             "tests"
         } else {

tests/src/integration/variadic_args/mod.rs

@@ -79,10 +79,10 @@ pub fn test_variadic_first_last(items: &[&Zval]) -> Vec<Zval> {
     if let Some(first) = items.first() {
         result.push(first.shallow_clone());
     }
-    if let Some(last) = items.last() {
-        if items.len() > 1 {
-            result.push(last.shallow_clone());
-        }
+    if let Some(last) = items.last()
+        && items.len() > 1
+    {
+        result.push(last.shallow_clone());
     }
     result
 }