feat(embed): fix php signature for embed

joelwurtz · joelwurtz · commit 59e6484ad637 · 2025-03-21T11:08:37.000+01:00
diff --git a/src/embed/mod.rs b/src/embed/mod.rs
@@ -96,8 +96,11 @@ impl Embed {
 
         match exec_result {
             Err(_) => Err(EmbedError::CatchError),
+            #[cfg(any(php80, php81))]
+            Ok(0) => Ok(()),
+            #[cfg(any(php82, php83, php84))]
             Ok(true) => Ok(()),
-            Ok(false) => Err(EmbedError::ExecuteScriptError),
+            Ok(_) => Err(EmbedError::ExecuteScriptError),
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -96,8 +96,11 @@ impl Embed {`
`96`	`96`
`97`	`97`	`match exec_result {`
`98`	`98`	`Err(_) => Err(EmbedError::CatchError),`
	`99`	`+ #[cfg(any(php80, php81))]`
	`100`	`+ Ok(0) => Ok(()),`
	`101`	`+ #[cfg(any(php82, php83, php84))]`
`99`	`102`	`Ok(true) => Ok(()),`
`100`		`- Ok(false) => Err(EmbedError::ExecuteScriptError),`
	`103`	`+ Ok(_) => Err(EmbedError::ExecuteScriptError),`
`101`	`104`	`}`
`102`	`105`	`}`
`103`	`106`