Support php 8.4 internal api changes

Author: joehoyle

build.rs

@@ -230,7 +230,9 @@ fn check_php_version(info: &PHPInfo) -> Result<()> {
 
     const PHP_83_API_VER: u32 = 20230831;
 
-    println!("cargo::rustc-check-cfg=cfg(php80, php81, php82, php83, php_zts, php_debug, docs)");
+    const PHP_84_API_VER: u32 = 20240924;
+
+    println!("cargo::rustc-check-cfg=cfg(php80, php81, php82, php83, php84, php_zts, php_debug, docs)");
     println!("cargo:rustc-cfg=php80");
 
     if (PHP_81_API_VER..PHP_82_API_VER).contains(&version) {
@@ -245,6 +247,10 @@ fn check_php_version(info: &PHPInfo) -> Result<()> {
         println!("cargo:rustc-cfg=php83");
     }
 
+    if version >= PHP_84_API_VER {
+        println!("cargo:rustc-cfg=php84");
+    }
+
     Ok(())
 }
 

src/builders/function.rs

@@ -55,6 +55,10 @@ impl<'a> FunctionBuilder<'a> {
                 arg_info: ptr::null(),
                 num_args: 0,
                 flags: 0, // TBD?
+                #[cfg(php84)]
+                doc_comment: ptr::null(),
+                #[cfg(php84)]
+                frameless_function_infos: ptr::null(),
             },
             args: vec![],
             n_req: None,
@@ -79,6 +83,10 @@ impl<'a> FunctionBuilder<'a> {
                 arg_info: ptr::null(),
                 num_args: 0,
                 flags: MethodFlags::Abstract.bits(),
+                #[cfg(php84)]
+                doc_comment: ptr::null(),
+                #[cfg(php84)]
+                frameless_function_infos: ptr::null(),
             },
             args: vec![],
             n_req: None,

src/zend/function.rs

@@ -38,6 +38,10 @@ impl FunctionEntry {
             arg_info: ptr::null(),
             num_args: 0,
             flags: 0,
+            #[cfg(php84)]
+            doc_comment: ptr::null(),
+            #[cfg(php84)]
+            frameless_function_infos: ptr::null(),
         }
     }
 

src/zend/handlers.rs

@@ -238,9 +238,18 @@ impl ZendObjectHandlers {
                         let mut zv = Zval::new();
                         val.get(self_, &mut zv)?;
 
-                        #[allow(clippy::unnecessary_mut_passed)]
-                        if zend_is_true(&mut zv) == 1 {
-                            return Ok(1);
+                        cfg_if::cfg_if! {
+                            if #[cfg(php84)] {
+                                #[allow(clippy::unnecessary_mut_passed)]
+                                if zend_is_true(&mut zv) == true {
+                                    return Ok(1);
+                                }
+                            } else {
+                                #[allow(clippy::unnecessary_mut_passed)]
+                                if zend_is_true(&mut zv) == 1 {
+                                    return Ok(1);
+                                }
+                            }
                         }
                     }
                 }