ci: add musl build step

Author: ptondereau

.cargo/config.toml

@@ -6,3 +6,11 @@ linker = "rust-lld"
 
 [target.i686-pc-windows-msvc]
 linker = "rust-lld"
+
+[target.'cfg(target_env = "musl")']
+rustflags = [
+    "-C",
+    "target-feature=-crt-static",
+    "-C",
+    "link-arg=-Wl,-undefined,dynamic_lookup",
+]

.github/action/musl/Dockerfile

@@ -0,0 +1,64 @@
+FROM alpine:3.20
+
+ARG PHP_VERSION=8.4
+ARG TS=ts
+
+RUN apk add --no-cache \
+    autoconf \
+    automake \
+    bison \
+    re2c \
+    gcc \
+    g++ \
+    make \
+    musl-dev \
+    linux-headers \
+    pkgconfig \
+    curl \
+    jq \
+    llvm17 \
+    llvm17-dev \
+    llvm17-libs \
+    llvm17-static \
+    zlib-static \
+    ncurses-static \
+    libffi-dev \
+    libstdc++-dev
+
+WORKDIR /tmp
+RUN FULL_VERSION=$(curl -fsSL "https://www.php.net/releases/index.php?json&version=${PHP_VERSION}" | jq -r '.version') && \
+    echo "Downloading PHP ${FULL_VERSION}..." && \
+    curl -fsSL "https://www.php.net/distributions/php-${FULL_VERSION}.tar.gz" -o php.tar.gz && \
+    tar -xzf php.tar.gz && \
+    rm php.tar.gz && \
+    mv "php-${FULL_VERSION}" php-src
+
+WORKDIR /tmp/php-src
+RUN CONFIGURE_OPTS="--enable-debug --enable-embed=shared --disable-all --disable-cgi" && \
+    if [ "$TS" = "ts" ]; then CONFIGURE_OPTS="$CONFIGURE_OPTS --enable-zts"; fi && \
+    ./configure $CONFIGURE_OPTS --prefix=/usr/local && \
+    make -j$(nproc) && \
+    make install && \
+    rm -rf /tmp/php-src
+
+RUN curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y --default-toolchain stable
+ENV PATH="/root/.cargo/bin:${PATH}"
+
+RUN rustup target add x86_64-unknown-linux-musl
+
+ENV PHP=/usr/local/bin/php
+ENV PHP_CONFIG=/usr/local/bin/php-config
+
+ENV LLVM_CONFIG_PATH=/usr/lib/llvm17/bin/llvm-config
+ENV LIBCLANG_PATH=/usr/lib/llvm17/lib
+ENV LIBRARY_PATH=/usr/lib/llvm17/lib:$LIBRARY_PATH
+ENV LD_LIBRARY_PATH=/usr/lib/llvm17/lib:$LD_LIBRARY_PATH
+
+ENV RUSTFLAGS="-C link-arg=-L/usr/lib/llvm17/lib -C link-arg=-Wl,--allow-multiple-definition -C target-feature=-crt-static"
+
+WORKDIR /workspace
+
+COPY . .
+
+ENTRYPOINT ["cargo"]
+CMD ["build", "--release", "--no-default-features", "--features", "closure,anyhow,static,enum", "--workspace", "--target", "x86_64-unknown-linux-musl"]

.github/workflows/build.yml

@@ -168,7 +168,6 @@ jobs:
         # Macos fails on unstable rust. We skip the inline examples test for now.
         if: "!(contains(matrix.os, 'macos') && matrix.rust == 'nightly')"
         run: cargo test --release --workspace --features closure,anyhow,runtime --no-fail-fast
-
   test-embed:
     name: Test with embed
     runs-on: ubuntu-latest
@@ -226,3 +225,58 @@ jobs:
 
       - name: Test with embed feature
         run: cargo test --workspace --release --features closure,embed,anyhow --no-fail-fast
+
+  build-musl:
+    name: musl
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        php: ["8.1", "8.2", "8.3", "8.4"]
+        phpts: [ts, nts]
+    env:
+      CARGO_TERM_COLOR: always
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v5
+      - name: Setup PHP
+        uses: shivammathur/setup-php@v2
+        with:
+          php-version: ${{ matrix.php }}
+        env:
+          phpts: ${{ matrix.phpts }}
+          debug: true
+
+      - name: Cache LLVM and Clang
+        id: cache-llvm
+        uses: actions/cache@v4
+        with:
+          path: ${{ runner.temp }}/llvm-17
+          key: ubuntu-latest-llvm-17
+      - name: Setup LLVM & Clang
+        id: clang
+        uses: KyleMayes/install-llvm-action@v2
+        with:
+          version: 17
+          directory: ${{ runner.temp }}/llvm-17
+          cached: ${{ steps.cache-llvm.outputs.cache-hit }}
+      
+      - name: Install libclang.a
+        run: sudo apt-get update && sudo apt-get install --assume-yes --no-install-recommends libclang-17-dev
+
+      - name: Symlink libclang static libraries
+        run: |
+          ln -sf /usr/lib/llvm-17/lib/*.a ${{ runner.temp }}/llvm-17/lib/
+
+      - name: Configure Clang
+        run: |
+          echo "LIBCLANG_PATH=${{ runner.temp }}/llvm-17/lib" >> $GITHUB_ENV
+          echo "LLVM_VERSION=17" >> $GITHUB_ENV
+          echo "LLVM_CONFIG_PATH=${{ runner.temp }}/llvm-17/bin/llvm-config" >> $GITHUB_ENV
+
+      - name: Build
+        uses: houseabsolute/actions-rust-cross@v1
+        with:
+          target: x86_64-unknown-linux-musl
+          use-rust-cache: true
+          command: build
+          args: --release --no-default-features --features closure,anyhow,static,enum --workspace

Dockerfile

@@ -8,14 +8,20 @@ apt update -y
 apt install -y \
   libclang-dev \
   bison \
-  re2c
+  re2c \
+  curl \
+  jq
+
+# Download and extract PHP
+FULL_VERSION=$(curl -fsSL "https://www.php.net/releases/index.php?json&version=${PHP_VERSION}" | jq -r '.version')
+echo "Downloading PHP ${FULL_VERSION}..."
+curl -fsSL "https://www.php.net/distributions/php-${FULL_VERSION}.tar.gz" -o php.tar.gz
+tar -xzf php.tar.gz
+rm php.tar.gz
+mv "php-${FULL_VERSION}" php-src
 
 # Build PHP
-git clone --depth 1 -b PHP-${PHP_VERSION} https://github.com/php/php-src.git
 cd php-src
-# by default you will be on the master branch, which is the current
-# development version. You can check out a stable branch instead:
-./buildconf
 ./configure \
     --enable-debug \
     --disable-all --disable-cgi

README.md

@@ -126,6 +126,22 @@ best resource at the moment. This can be viewed at [docs.rs].
     1.57 at the time of writing.
 - Clang 5.0 or later.
 
+### Alpine Linux (musl) Requirements
+
+Building for Alpine Linux (musl libc) is supported on stable Rust with the following
+requirements:
+
+- Install musl toolchain: `sudo apt-get install musl-tools musl-dev`
+- Add musl target: `rustup target add x86_64-unknown-linux-musl`
+- Build with dynamic linking flag:
+  ```bash
+  RUSTFLAGS="-C target-feature=-crt-static" \
+    cargo build --target x86_64-unknown-linux-musl
+  ```
+
+**Note**: Building for musl requires dynamic CRT linking (`-crt-static` flag) to produce
+the `cdylib` output required for PHP extensions.
+
 ### Windows Requirements
 
 - Extensions can only be compiled for PHP installations sourced from

tests/Cargo.toml

@@ -1,16 +1,20 @@
 [package]
 name = "tests"
 version = "0.0.0"
-edition = "2021"
+edition = "2024"
 publish = false
 license = "MIT OR Apache-2.0"
 
 [dependencies]
-ext-php-rs = { path = "../", default-features = false, features = ["closure", "runtime"] }
+ext-php-rs = { path = "../", default-features = false }
 
 [features]
-default = ["enum"]
+default = ["enum", "runtime", "closure"]
 enum = ["ext-php-rs/enum"]
+anyhow = ["ext-php-rs/anyhow"]
+runtime = ["ext-php-rs/runtime"]
+closure = ["ext-php-rs/closure"]
+static = ["ext-php-rs/static"]
 
 [lib]
 crate-type = ["cdylib"]

tests/src/integration/mod.rs

@@ -36,11 +36,13 @@ mod test {
             {
                 command.arg("--features=enum");
             }
-            assert!(command
-                .output()
-                .expect("failed to build extension")
-                .status
-                .success());
+            assert!(
+                command
+                    .output()
+                    .expect("failed to build extension")
+                    .status
+                    .success()
+            );
         });
     }
 

tests/src/integration/variadic_args/mod.rs

@@ -79,10 +79,10 @@ pub fn test_variadic_first_last(items: &[&Zval]) -> Vec<Zval> {
     if let Some(first) = items.first() {
         result.push(first.shallow_clone());
     }
-    if let Some(last) = items.last() {
-        if items.len() > 1 {
-            result.push(last.shallow_clone());
-        }
+    if let Some(last) = items.last()
+        && items.len() > 1
+    {
+        result.push(last.shallow_clone());
     }
     result
 }