Skip to content

fix(class)!: generate correct stubs for extends and implements #431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 10, 2025
Merged

fix(class)!: generate correct stubs for extends and implements #431

merged 2 commits into from
May 10, 2025

Conversation

@Xenira
Copy link
Member

@Xenira Xenira commented May 7, 2025

BREAKING CHANGE: extends and implements attributes now require the stub property containing the class/interface name to be used in stubs.

Refs: #326

@Xenira Xenira linked an issue May 7, 2025 that may be closed by this pull request
#[implements] doesn't generate the right stubs #326
Closed
@coveralls
Copy link

coveralls commented May 7, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 14942826149

Details

  • 34 of 58 (58.62%) changed or added relevant lines in 7 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+6.8%) to 20.927%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/describe/abi.rs 8 9 88.89%
src/builders/module.rs 0 4 0.0%
src/builders/class.rs 3 9 33.33%
crates/macros/src/class.rs 0 13 0.0%
Files with Coverage Reduction New Missed Lines %
crates/macros/src/class.rs 1 0.0%
Totals Coverage Status
Change from base Build 14847024853: 6.8%
Covered Lines: 822
Relevant Lines: 3928
💛 - Coveralls

@Xenira Xenira self-assigned this May 7, 2025
@Xenira Xenira added this to the macro rework milestone May 7, 2025
@Xenira Xenira force-pushed the 326-implements-doesnt-generate-the-right-stubs branch from d32957c to 40ec3d5 Compare May 9, 2025 16:02
@Xenira
fix(class)!: generate correct stubs for extends and implements
13a74d7 
BREAKING CHANGE: `extends` and `implements` attributes now require the `stub` property containing the class/interface name to be used in stubs.

Refs: #326
@Xenira Xenira force-pushed the 326-implements-doesnt-generate-the-right-stubs branch 5 times, most recently from df54d98 to 80d5db5 Compare May 9, 2025 20:40
@Xenira Xenira force-pushed the 326-implements-doesnt-generate-the-right-stubs branch from 80d5db5 to 4211637 Compare May 10, 2025 06:37
@Xenira Xenira merged commit 8f43b74 into master May 10, 2025
37 checks passed
@Xenira Xenira deleted the 326-implements-doesnt-generate-the-right-stubs branch July 1, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Xenira Xenira

Labels

None yet

Projects

None yet

Milestone

macro rework

Development

Successfully merging this pull request may close these issues.

#[implements] doesn't generate the right stubs

3 participants

@Xenira @coveralls