Skip to content

Conversation

@ptondereau
Copy link
Member

@ptondereau ptondereau commented Nov 20, 2025

Description

Fix #591

TODO

  • Wait for the official Docker image to release PHP 8.5 images for MUSL CI.
  • Test embed codes don't work with 8.5 right now.
  • Windows tests are failing because of intsafe import in zend_compatibility, we need to find a way to tell clang to define them somewhere

@coveralls
Copy link

coveralls commented Nov 20, 2025

Pull Request Test Coverage Report for Build 19771651930

Details

  • 1 of 26 (3.85%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.06%) to 35.308%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/types/array/iterators.rs 1 8 12.5%
src/constant.rs 0 18 0.0%
Totals Coverage Status
Change from base Build 19374695739: -0.06%
Covered Lines: 1603
Relevant Lines: 4540

💛 - Coveralls

@ptondereau ptondereau force-pushed the chore/php-8-5 branch 6 times, most recently from 42b73c5 to 2dbf4b3 Compare November 20, 2025 22:27
@ptondereau ptondereau force-pushed the chore/php-8-5 branch 13 times, most recently from b6fca05 to 63ba824 Compare November 28, 2025 16:53
@ptondereau ptondereau marked this pull request as ready for review November 28, 2025 16:57
@ptondereau ptondereau requested a review from Xenira November 28, 2025 16:57
@ptondereau
Copy link
Member Author

@Xenira I think it is good; the challenging one was the embed tests.

@Xenira
Copy link
Member

Xenira commented Nov 28, 2025

Looks good, thank you. I think there are 2 places where we could use cfg-if.

Not at home atm, so cant do a full review rn.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PHP 8.5

4 participants