Update test & CI scripts

Author: ndaidong

.github/workflows/ci-test.yml

@@ -12,7 +12,7 @@ jobs:
 
     strategy:
       matrix:
-        node_version: [20.x, 22.x, 23.x]
+        node_version: [20.x, 22.x, 24.x]
 
     steps:
     - uses: actions/checkout@v4
@@ -24,38 +24,17 @@ jobs:
 
     - name: run npm scripts
       env:
-        FACEBOOK_APP_ID: ${{ secrets.FACEBOOK_APP_ID }}
-        FACEBOOK_CLIENT_TOKEN: ${{ secrets.FACEBOOK_CLIENT_TOKEN }}
         PROXY_SERVER: ${{ secrets.PROXY_SERVER }}
       run: |
         npm install
         npm run lint
         npm run build --if-present
         npm run test
 
-    - name: Coveralls Parallel
-      uses: coverallsapp/github-action@v2
-      with:
-        flag-name: run-${{ join(matrix.*, '-') }}
-        parallel: true
-        github-token: ${{ secrets.GITHUB_TOKEN }}
-
     - name: cache node modules
       uses: actions/cache@v4
       with:
         path: ~/.npm
         key: ${{ runner.os }}-node-${{ hashFiles('**/package-lock.json') }}
         restore-keys: |
           ${{ runner.os }}-node-
-
-  finish:
-    needs: test
-    if: ${{ always() }}
-    runs-on: ubuntu-latest
-    steps:
-    - name: Coveralls Finished
-      uses: coverallsapp/github-action@v2
-      with:
-        parallel-finished: true
-        carryforward: "run-20.x,run-22.x,run-23.x"
-

README.md

@@ -6,7 +6,6 @@ Extract oEmbed content from given URL.
 [![NPM](https://badge.fury.io/js/@extractus%2Foembed-extractor.svg)](https://badge.fury.io/js/@extractus%2Foembed-extractor)
 ![CodeQL](https://github.com/extractus/oembed-extractor/workflows/CodeQL/badge.svg)
 [![CI test](https://github.com/extractus/oembed-extractor/workflows/ci-test/badge.svg)](https://github.com/extractus/oembed-extractor/actions)
-[![Coverage Status](https://coveralls.io/repos/github/extractus/oembed-extractor/badge.svg)](https://coveralls.io/github/extractus/oembed-extractor)
 
 ## Demo
 
@@ -45,9 +44,6 @@ import { extract } from 'npm:@extractus/oembed-extractor'
 import { extract } from "https://esm.sh/@extractus/oembed-extractor@latest"
 ```
 
-Please check [the examples](examples) for reference.
-
-
 ## APIs
 
 ### `.extract()`

src/main.test.js

@@ -1,5 +1,7 @@
-// main
-/* eslint-env jest */
+// main.test
+
+import { describe, it } from 'node:test'
+import assert from 'node:assert'
 
 import { HttpsProxyAgent } from 'https-proxy-agent'
 
@@ -93,11 +95,11 @@ describe('test extract(bad url)', () => {
   ]
 
   badSamples.forEach((url) => {
-    test(`testing extract bad url "${url}"`, async () => {
+    it(`testing extract bad url "${url}"`, async () => {
       try {
         await extract(url)
       } catch (err) {
-        expect(err).toBeTruthy()
+        assert.ok(err)
       }
     })
   })
@@ -168,7 +170,7 @@ describe('test if extract() with some popular providers', () => {
 
   cases.forEach(({ input, expected, checkFn }) => {
     const { url, file, params = {} } = input
-    test(`check fetchEmbed("${url}")`, async () => {
+    it(`check fetchEmbed("${url}")`, async () => {
       const provider = findProvider(url)
       const { baseUrl, path } = parseUrl(provider.endpoint)
 
@@ -190,15 +192,15 @@ describe('test if extract() with some popular providers', () => {
       } = params
 
       const result = await extract(url, { maxwidth, maxheight })
-      expect(result).toBeTruthy()
-      expect(checkFn(result)).toBe(true)
-      expect(result.provider_name).toEqual(expected.provider_name)
-      expect(result.type).toEqual(expected.type)
+      assert.ok(result)
+      assert.ok(checkFn(result))
+      assert.ok(result.provider_name === expected.provider_name)
+      assert.ok(result.type === expected.type)
       if (maxwidth > 0) {
-        expect(result.width).toBeLessThanOrEqual(expected.maxwidth)
+        assert.ok(result.width <= expected.maxwidth)
       }
       if (maxheight > 0) {
-        expect(result.height).toBeLessThanOrEqual(expected.maxheight)
+        assert.ok(result.height <= expected.maxheight)
       }
       nock.cleanAll()
     })
@@ -207,23 +209,23 @@ describe('test if extract() with some popular providers', () => {
 
 if (PROXY_SERVER !== '') {
   describe('test extract live oembed API via proxy server', () => {
-    test('check if extract method works with proxy server', async () => {
+    it('check if extract method works with proxy server', async () => {
       const url = 'https://codepen.io/ndaidong/pen/LYmLKBw'
       const result = await extract(url, {}, {
         agent: new HttpsProxyAgent(PROXY_SERVER),
       })
       console.log(result)
-      expect(result.success).toBeTruthy()
+      assert.ok(result.success)
     }, 10000)
   })
 }
 
-test('test .hasProvider() method', () => {
-  expect(hasProvider('https://www.youtube.com/watch?v=ciS8aCrX-9s')).toBe(true)
-  expect(hasProvider('https://trello.com/b/BO3bg7yn/notes')).toBe(false)
+it('test .hasProvider() method', () => {
+  assert.ok(hasProvider('https://www.youtube.com/watch?v=ciS8aCrX-9s'))
+  assert.ok(!hasProvider('https://trello.com/b/BO3bg7yn/notes'))
 })
 
-test('test .setProviderList() method', () => {
+it('test .setProviderList() method', () => {
   const customProviderOnly = [
     {
       provider_name: 'Example',
@@ -239,6 +241,6 @@ test('test .setProviderList() method', () => {
     },
   ]
   setProviderList(customProviderOnly)
-  expect(hasProvider('http://www.example.org/media/abcdef')).toBe(true)
-  expect(hasProvider('https://www.youtube.com/watch?v=ciS8aCrX-9s')).toBe(false)
+  assert.ok(hasProvider('http://www.example.org/media/abcdef'))
+  assert.ok(!hasProvider('https://www.youtube.com/watch?v=ciS8aCrX-9s'))
 })

src/utils/autoDiscovery.test.js

@@ -1,5 +1,7 @@
 // autoDiscovery.test
-/* eslint-env jest */
+
+import { describe, it } from 'node:test'
+import assert from 'node:assert'
 
 import nock from 'nock'
 
@@ -15,7 +17,7 @@ const parseUrl = (url) => {
 
 describe('test if autoDiscovery() works correctly', () => {
   const url = 'https://www.bitchute.com/video/8hXWnkvA8Ao/'
-  test(`check fetchEmbed("${url}")`, async () => {
+  it(`check fetchEmbed("${url}")`, async () => {
     const htmlFile = './test-data/bitchute.html'
     const jsonFile = './test-data/bitchute.json'
 
@@ -47,7 +49,7 @@ describe('test if autoDiscovery() works correctly', () => {
       })
 
     const result = await autoDiscovery(url, params)
-    expect(result).toBeTruthy()
+    assert.ok(result)
     nock.cleanAll()
   })
 })

src/utils/fetchEmbed.test.js

@@ -1,5 +1,7 @@
 // fetchEmbed.test
-/* eslint-env jest */
+
+import { describe, it } from 'node:test'
+import assert from 'node:assert'
 
 import nock from 'nock'
 
@@ -91,7 +93,7 @@ describe('test if fetchEmbed() works correctly', () => {
 
   cases.forEach(({ input, expected }) => {
     const { url, file, params = {} } = input
-    test(`check fetchEmbed("${url}")`, async () => {
+    it(`check fetchEmbed("${url}")`, async () => {
       const endpoint = getEndpoint(url)
       const { baseUrl, path } = parseUrl(endpoint)
 
@@ -113,14 +115,14 @@ describe('test if fetchEmbed() works correctly', () => {
       } = params
 
       const result = await fetchEmbed(url, { maxwidth, maxheight }, endpoint)
-      expect(result).toBeTruthy()
-      expect(result.provider_name).toEqual(expected.provider_name)
-      expect(result.type).toEqual(expected.type)
+      assert.ok(result)
+      assert.equal(result.provider_name, expected.provider_name)
+      assert.equal(result.type, expected.type)
       if (maxwidth > 0) {
-        expect(result.width).toBeLessThanOrEqual(expected.maxwidth)
+        assert.ok(result.width <= expected.maxwidth)
       }
       if (maxheight > 0) {
-        expect(result.height).toBeLessThanOrEqual(expected.maxheight)
+        assert.ok(result.height <= expected.maxheight)
       }
       nock.cleanAll()
     })

src/utils/linker.test.js

@@ -1,5 +1,7 @@
 // linker.test
-/* eslint-env jest */
+
+import { describe, it } from 'node:test'
+import assert from 'node:assert'
 
 import { isValid as isValidURL } from './linker.js'
 
@@ -39,9 +41,9 @@ describe('test isValidURL()', () => {
     },
   ]
   cases.forEach(({ url, expected }) => {
-    test(`isValidURL("${url}") must return "${expected}"`, () => {
+    it(`isValidURL("${url}") must return "${expected}"`, () => {
       const result = isValidURL(url)
-      expect(result).toEqual(expected)
+      assert.equal(result, expected)
     })
   })
 })

src/utils/provider.test.js

@@ -1,5 +1,7 @@
 // provider.test
-/* eslint-env jest */
+
+import { describe, it } from 'node:test'
+import assert from 'node:assert'
 
 import provider from './provider.js'
 
@@ -20,22 +22,22 @@ describe('test if provider.find() works correctly', () => {
   ]
 
   cases.forEach(({ url, fetchEndpoint }) => {
-    test(`provider.find("${url}") must return "${fetchEndpoint}"`, () => {
+    it(`provider.find("${url}") must return "${fetchEndpoint}"`, () => {
       const foundedProvider = provider.find(url)
-      expect(foundedProvider.endpoint).toEqual(fetchEndpoint)
+      assert.equal(foundedProvider.endpoint, fetchEndpoint)
     })
   })
 
-  test('provider.find("{}") must return null', () => {
-    expect(provider.find({})).toEqual(null)
+  it('provider.find("{}") must return null', () => {
+    assert.equal(provider.find({}), null)
   })
 
-  test('provider.find("abcdef") must return null', () => {
-    expect(provider.find('abcdef')).toEqual(null)
+  it('provider.find("abcdef") must return null', () => {
+    assert.equal(provider.find('abcdef'), null)
   })
 
-  test('provider.find("https://somethingdoesnotexist.com") must return null', () => {
-    expect(provider.find('https://somethingdoesnotexist.com')).toEqual(null)
+  it('provider.find("https://somethingdoesnotexist.com") must return null', () => {
+    assert.equal(provider.find('https://somethingdoesnotexist.com'), null)
   })
 })
 
@@ -66,10 +68,10 @@ describe('test if provider set/get works correctly', () => {
       ],
     },
   ]
-  test('provider.set() & provider.get()', () => {
-    expect(provider.set(providerList)).toEqual(providerList.length)
+  it('provider.set() & provider.get()', () => {
+    assert.equal(provider.set(providerList), providerList.length)
     const newList = provider.get()
-    expect(newList.length).toEqual(providerList.length)
-    expect(newList[0].schemes[0]).toEqual(/\/\/store.alpha.com\/(.*)/i)
+    assert.equal(newList.length, providerList.length)
+    assert.equal((newList[0].schemes[0]).toString(), (/\/\/store.alpha.com\/(.*)/i).toString())
   })
 })

src/utils/retrieve.test.js

@@ -1,5 +1,7 @@
 // retrieve.test
-/* eslint-env jest */
+
+import { describe, it } from 'node:test'
+import assert from 'node:assert'
 
 import nock from 'nock'
 
@@ -14,18 +16,18 @@ const parseUrl = (url) => {
 }
 
 describe('test getJson() method', () => {
-  test('test getJson from good source', async () => {
+  it('test getJson from good source', async () => {
     const url = 'https://some.where/good/source'
     const { baseUrl, path } = parseUrl(url)
     nock(baseUrl).get(path).reply(200, { data: { name: 'oembed-parser' } }, {
       'Content-Type': 'application/json',
     })
     const result = await getJson(url)
-    expect(result.data.name).toEqual('oembed-parser')
+    assert.equal(result.data.name, 'oembed-parser')
     nock.cleanAll()
   })
 
-  test('test getJson using proxy', async () => {
+  it('test getJson using proxy', async () => {
     const url = 'https://some.where/good/source-with-proxy'
     const { baseUrl, path } = parseUrl(url)
     nock(baseUrl).get(path).reply(200, { data: { name: 'oembed-parser' } }, {
@@ -40,11 +42,11 @@ describe('test getJson() method', () => {
         target: 'https://proxy-server.com/api/proxy?url=',
       },
     })
-    expect(result.data.name).toEqual('oembed-parser')
+    assert.equal(result.data.name, 'oembed-parser')
     nock.cleanAll()
   })
 
-  test('test getJson invalid json reponsse', async () => {
+  it('test getJson invalid json reponsse', async () => {
     const url = 'https://some.where/bad/source'
     const { baseUrl, path } = parseUrl(url)
     nock(baseUrl).get(path).reply(200, 'this is not json string', {
@@ -53,7 +55,7 @@ describe('test getJson() method', () => {
     try {
       await getJson(url)
     } catch (err) {
-      expect(err).toBeTruthy()
+      assert.ok(err)
     }
     nock.cleanAll()
   })