Small fixes

Author: exussum12

src/ArgParser.php

@@ -18,6 +18,7 @@ public function __construct(array $args)
     public function getArg(string $name): string
     {
         if (is_numeric($name)) {
+            $name = (int) $name;
             return $this->numericArg($name);
         }
 

src/FileParser.php

@@ -93,10 +93,7 @@ private function handleNamespace(Namespace_ $node)
         }
     }
 
-    /**
-     * @param $node
-     */
-    protected function handleNode($node)
+    protected function handleNode(Node $node)
     {
         $type = $node->getType();
         if ($type == 'Stmt_Namespace') {

src/Loaders/Buddy.php

@@ -2,6 +2,7 @@
 namespace exussum12\CoverageChecker\Loaders;
 
 use exussum12\CoverageChecker\FileChecker;
+
 /**
  * Class Buddy
  * Used for parsing magic number reports from buddy

src/Loaders/PhanText.php

@@ -2,6 +2,7 @@
 namespace exussum12\CoverageChecker\Loaders;
 
 use exussum12\CoverageChecker\FileChecker;
+
 /**
  * Class PhanText
  * Used for parsing phan text output

src/Loaders/PhpCs.php

@@ -138,11 +138,9 @@ protected function addInvalidLine(string $file, stdClass $message)
     }
 
     /**
-     * @param $message
-     * @param array $list
      * @return bool|string
      */
-    protected function messageStartsWith($message, array $list)
+    protected function messageStartsWith(string $message, array $list)
     {
         foreach ($list as $item) {
             if (strpos($message, $item) === 0) {
@@ -154,10 +152,6 @@ protected function messageStartsWith($message, array $list)
 
     protected function handleLookupError($file, $message, $error)
     {
-        if ($file == '') {
-            return;
-        }
-
         if ($error == 'Squiz.Commenting.FileComment') {
             $this->invalidFiles[$file][] = $message->message;
         }
@@ -167,7 +161,6 @@ protected function handleLookupError($file, $message, $error)
 
             $this->addRangeError($file, $lookup, $message);
         } catch (FileNotFound $exception) {
-            var_dump($file);
             error_log("Can't find file, may have missed an error");
         }
     }

src/Loaders/PhpMdStrict.php

@@ -1,7 +1,6 @@
 <?php
 namespace exussum12\CoverageChecker\Loaders;
 
-
 /**
  * Class PhpMdLoaderStrict
  * Used for parsing phpmd xml output

src/Loaders/PhpStan.php

@@ -96,13 +96,13 @@ protected function getLineNumber(string $line, int $currentLineNumber)
         $matches = [];
         if (!preg_match($this->lineRegex, $line, $matches)) {
             if (preg_match('#^\s{3,}#', $line)) {
-                return (int) $currentLineNumber;
+                return $currentLineNumber;
             }
 
             return false;
         }
 
-        return $matches['lineNumber'];
+        return (int) $matches['lineNumber'];
     }
 
     protected function getMessage($line)
@@ -167,11 +167,7 @@ protected function addError($filename, $lineNumber, $error)
         $this->invalidLines[$filename][$lineNumber][] = $error;
     }
 
-    /**
-     * @param array $matches
-     * @return ReflectionFunctionAbstract
-     */
-    protected function getReflector($matches)
+    protected function getReflector(array $matches):  ReflectionFunctionAbstract
     {
         if ($matches['class']) {
             return $this->getClassReflector($matches);
@@ -187,11 +183,7 @@ private function appendError($filename, $lineNumber, $error)
         $this->invalidLines[$filename][$lineNumber][$key] .= ' ' . $error;
     }
 
-    /**
-     * @param $matches
-     * @return bool|ReflectionMethod
-     */
-    protected function getClassReflector($matches)
+    protected function getClassReflector(array $matches)
     {
         if (!method_exists($matches['class'], $matches['function'])) {
             return false;
@@ -203,10 +195,9 @@ protected function getClassReflector($matches)
     }
 
     /**
-     * @param $matches
      * @return bool|ReflectionFunction
      */
-    protected function getFunctionReflector($matches)
+    protected function getFunctionReflector(array $matches)
     {
         if (!function_exists($matches['function'])) {
             return false;

src/Loaders/PhpUnit.php

@@ -1,7 +1,6 @@
 <?php
 namespace exussum12\CoverageChecker\Loaders;
 
-
 /**
  * Class PhpUnit
  * Used for reading in a phpunit clover XML file

src/Runners/generic.php

@@ -17,15 +17,15 @@
 CoverageChecker\checkCallIsCorrect($args);
 
 try {
-    $minimumPercentCovered = CoverageChecker\getMinPercent($args->getArg(3));
+    $minimumPercentCovered = CoverageChecker\getMinPercent($args->getArg('3'));
 } catch (ArgumentNotFound $exception) {
     $minimumPercentCovered = 100;
 }
 
 $matcher = new CoverageChecker\FileMatchers\EndsWith();
 
 $diff = new CoverageChecker\DiffFileLoader(
-    CoverageChecker\adjustForStdIn($args->getArg(1))
+    CoverageChecker\adjustForStdIn($args->getArg('1'))
 );
 
 try {
@@ -62,7 +62,7 @@
 $fileCheck = CoverageChecker\getFileChecker(
     $args,
     $checkerArray,
-    CoverageChecker\adjustForStdIn($args->getArg(2))
+    CoverageChecker\adjustForStdIn($args->getArg('2'))
 );
 
 $outputArray = [

src/functions.php

@@ -40,8 +40,8 @@ function findAutoLoader()
 function checkCallIsCorrect(ArgParser $args)
 {
     try {
-        $args->getArg(1);
-        $args->getArg(2);
+        $args->getArg('1');
+        $args->getArg('2');
     } catch (ArgumentNotFound $exception) {
         throw new Exception(
             "Missing arguments, please call with diff and check file\n" .