Add buddy (#37)

* Add buddy

* PSR-2

* fix for older php

Author: exussum12

src/BuddyLoader.php

@@ -0,0 +1,17 @@
+<?php
+namespace exussum12\CoverageChecker;
+
+/**
+ * Class BuddyLoader
+ * Used for parsing magic number reports from buddy
+ * @package exussum12\CoverageChecker
+ */
+class BuddyLoader extends Generic implements FileChecker
+{
+    protected $lineMatch = '#^(?P<fileName>.*?):(?P<lineNumber>[0-9]+) \| (?P<message>.*)$#';
+
+    public static function getDescription()
+    {
+        return 'Parses buddy (magic number detection) output';
+    }
+}

src/Generic.php

@@ -0,0 +1,85 @@
+<?php
+namespace exussum12\CoverageChecker;
+
+/**
+ * Class Generic
+ * Used for parsing output on a single line
+ * @package exussum12\CoverageChecker
+ */
+abstract class Generic
+{
+    protected $lineMatch = '';
+
+    /**
+     * @var string
+     */
+    protected $file;
+
+    /**
+     * @var array
+     */
+    protected $errors = [];
+
+    /**
+     * PhanJsonLoader constructor.
+     * @param string $file the path to the file containing phan output
+     */
+    public function __construct($file)
+    {
+        $this->file = $file;
+    }
+
+    /**
+     * {@inheritdoc}
+     */
+    public function parseLines()
+    {
+        $handle = fopen($this->file, 'r');
+        while (($line = fgets($handle)) !== false) {
+            if (!$this->checkForFile($line)) {
+                continue;
+            }
+
+            $this->addError($line);
+        }
+
+        return array_keys($this->errors);
+    }
+
+    /**
+     * {@inheritdoc}
+     */
+    public function getErrorsOnLine($file, $lineNumber)
+    {
+        $errors = [];
+        if (isset($this->errors[$file][$lineNumber])) {
+            $errors = $this->errors[$file][$lineNumber];
+        }
+
+        return $errors;
+    }
+
+    /**
+     * {@inheritdoc}
+     */
+    public function handleNotFoundFile()
+    {
+        return true;
+    }
+
+
+    private function checkForFile($line)
+    {
+        return preg_match($this->lineMatch, $line);
+    }
+
+    private function addError($line)
+    {
+        $matches = [];
+        if (preg_match($this->lineMatch, $line, $matches)) {
+            $this->errors
+                [$matches['fileName']]
+                [$matches['lineNumber']][] = trim($matches['message']);
+        }
+    }
+}

src/PhanTextLoader.php

@@ -6,84 +6,15 @@
  * Used for parsing phan text output
  * @package exussum12\CoverageChecker
  */
-class PhanTextLoader implements FileChecker
+class PhanTextLoader extends Generic implements FileChecker
 {
     protected $lineMatch = '#(?:\./)?(?P<fileName>.*?):(?P<lineNumber>[0-9]+)(?P<message>.*)#';
 
-    /**
-     * @var string
-     */
-    protected $file;
-
-    /**
-     * @var array
-     */
-    protected $errors = [];
-
-    /**
-     * PhanJsonLoader constructor.
-     * @param string $file the path to the file containing phan output
-     */
-    public function __construct($file)
-    {
-        $this->file = $file;
-    }
-
-    /**
-     * {@inheritdoc}
-     */
-    public function parseLines()
-    {
-        $handle = fopen($this->file, 'r');
-        while (($line = fgets($handle)) !== false) {
-            if (!$this->checkForFile($line)) {
-                continue;
-            }
-
-            $this->addError($line);
-        }
-
-        return array_keys($this->errors);
-    }
-
-    /**
-     * {@inheritdoc}
-     */
-    public function getErrorsOnLine($file, $lineNumber)
-    {
-        $errors = [];
-        if (isset($this->errors[$file][$lineNumber])) {
-            $errors = $this->errors[$file][$lineNumber];
-        }
-
-        return $errors;
-    }
-
-    /**
-     * {@inheritdoc}
-     */
-    public function handleNotFoundFile()
-    {
-        return true;
-    }
-
-    /**
-     * {@inheritdoc}
+    /*
+     * @inheritdoc
      */
     public static function getDescription()
     {
         return 'Parse the default phan(static analysis) output';
     }
-
-    private function checkForFile($line)
-    {
-        return preg_match($this->lineMatch, $line);
-    }
-
-    private function addError($line)
-    {
-        $matches = [];
-        preg_match($this->lineMatch, $line, $matches);
-        $this->errors[$matches['fileName']][$matches['lineNumber']][] = trim($matches['message']);
-    }
 }

src/PylintLoader.php

@@ -6,7 +6,7 @@
  * Used for parsing reports in Pylint format
  * @package exussum12\CoverageChecker
  */
-class PylintLoader extends PhanTextLoader
+class PylintLoader extends Generic implements FileChecker
 {
     protected $lineMatch = '#\./(?P<fileName>.*?):(?P<lineNumber>[0-9]+): \[.*?\](?P<message>.*)#';
 

src/Runners/generic.php

@@ -28,6 +28,7 @@
 }
 
 $checkerArray = [
+    'buddy' => 'BuddyLoader',
     'checkstyle' => 'CheckstyleLoader',
     'clover' => 'CloverLoader',
     'codeclimate' => 'CodeClimateLoader',