Add some more type hints

exussum12 · exussum12 · commit d86c44632b20 · 2018-12-18T23:16:38.000Z
diff --git a/src/Loaders/Checkstyle.php b/src/Loaders/Checkstyle.php
@@ -76,11 +76,7 @@ public static function getDescription(): string
         return 'Parses a report in checkstyle format';
     }
 
-    /**
-     * @param XMLReader $reader
-     * @param string $currentFile
-     */
-    protected function handleErrors($reader, $currentFile)
+    protected function handleErrors(XMLReader $reader, string $currentFile)
     {
         if ($reader->name === "error") {
             $this->coveredLines
@@ -90,12 +86,7 @@ protected function handleErrors($reader, $currentFile)
         }
     }
 
-    /**
-     * @param XMLReader $reader
-     * @param string $currentFile
-     * @return string
-     */
-    protected function handleFile($reader, $currentFile)
+    protected function handleFile(XMLReader $reader, string $currentFile): string
     {
         if ((
             $reader->name === "file" &&

Original file line number	Diff line number	Diff line change
`@@ -76,11 +76,7 @@ public static function getDescription(): string`
`76`	`76`	`return 'Parses a report in checkstyle format';`
`77`	`77`	`}`
`78`	`78`
`79`		`- /**`
`80`		`- * @param XMLReader $reader`
`81`		`- * @param string $currentFile`
`82`		`- */`
`83`		`- protected function handleErrors($reader, $currentFile)`
	`79`	`+ protected function handleErrors(XMLReader $reader, string $currentFile)`
`84`	`80`	`{`
`85`	`81`	`if ($reader->name === "error") {`
`86`	`82`	`$this->coveredLines`
`@@ -90,12 +86,7 @@ protected function handleErrors($reader, $currentFile)`
`90`	`86`	`}`
`91`	`87`	`}`
`92`	`88`
`93`		`- /**`
`94`		`- * @param XMLReader $reader`
`95`		`- * @param string $currentFile`
`96`		`- * @return string`
`97`		`- */`
`98`		`- protected function handleFile($reader, $currentFile)`
	`89`	`+ protected function handleFile(XMLReader $reader, string $currentFile): string`
`99`	`90`	`{`
`100`	`91`	`if ((`
`101`	`92`	`$reader->name === "file" &&`