Claude/issue 1614 20260128 1839 #1615
Open
+269
−74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Ralph Khreish <[email protected]>
- Fix ComplexityReportManager to use resolvedTag consistently - Add integration test for complexity enrichment with tags - Ensure cache key and file path use same tag resolution Fixes #1614 Co-authored-by: Ralph Khreish <[email protected]>
🦋 Changeset detectedLatest commit: 43ee902 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
📝 WalkthroughWalkthroughThis PR bumps the version from 0.42.0 to 0.43.0, consolidates pending changeset entries into the CHANGELOG, removes five changeset files, adds a new changeset for a bug fix, and fixes tag resolution in complexity report loading with accompanying integration tests. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In @.changeset/complexity-tag-fix.md:
- Around line 1-3: The changeset frontmatter currently lists an invalid package
("@tm/core") which breaks CI validation; open .changeset/complexity-tag-fix.md
and update the frontmatter package name value to an allowed package (e.g.,
replace "@tm/core" with "task-master-ai") so the top YAML block references a
valid package; ensure the triple-dash YAML block remains intact and save the
file.
In `@packages/tm-core/tests/integration/storage/complexity-enrichment.test.ts`:
- Around line 1-195: The file fails CI formatting; run the project formatter
(e.g., `biome format .` or the repo's configured formatter) and commit the
result so the test file (the describe/it/beforeEach/afterEach blocks that use
FileStorage, saveTasks, loadTasks) matches the repo style; ensure whitespace,
imports, and trailing newlines are fixed and re-run tests to confirm formatting
is clean before merging.
Comment on lines
+1
to
+3
| --- | ||
| "@tm/core": patch | ||
| --- |
Contributor
There was a problem hiding this comment.
Changeset package name breaks validation.
CI reports this changeset references an invalid package. Please switch the frontmatter to an allowed package (likely task-master-ai).
🛠️ Suggested fix
---
-"@tm/core": patch
+"task-master-ai": patch
---📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| --- | |
| "@tm/core": patch | |
| --- | |
| --- | |
| "task-master-ai": patch | |
| --- |
🧰 Tools
🪛 GitHub Actions: CI
[error] 1-1: Changeset validation failed during 'node .github/scripts/validate-changesets.mjs': complexity-tag-fix.md references invalid package '@tm/core'. Only allowed packages: task-master-ai, extension.
🤖 Prompt for AI Agents
In @.changeset/complexity-tag-fix.md around lines 1 - 3, The changeset
frontmatter currently lists an invalid package ("@tm/core") which breaks CI
validation; open .changeset/complexity-tag-fix.md and update the frontmatter
package name value to an allowed package (e.g., replace "@tm/core" with
"task-master-ai") so the top YAML block references a valid package; ensure the
triple-dash YAML block remains intact and save the file.
Comment on lines
+1
to
+195
| /** | ||
| * @fileoverview Integration test for complexity enrichment in list command | ||
| * | ||
| * This test reproduces the bug where task complexity is not shown in `list` | ||
| * after running `analyze-complexity` with a tag. | ||
| * | ||
| * Bug: https://github.com/eyaltoledano/claude-task-master/issues/1614 | ||
| */ | ||
|
|
||
| import { describe, it, expect, beforeEach, afterEach } from 'vitest'; | ||
| import fs from 'node:fs/promises'; | ||
| import path from 'node:path'; | ||
| import os from 'node:os'; | ||
| import { FileStorage } from '../../../src/modules/storage/adapters/file-storage/file-storage.js'; | ||
| import type { Task, ComplexityReport } from '../../../src/common/types/index.js'; | ||
|
|
||
| describe('Complexity Enrichment Integration Test', () => { | ||
| let tempDir: string; | ||
| let storage: FileStorage; | ||
|
|
||
| beforeEach(async () => { | ||
| // Create a temporary directory for testing | ||
| tempDir = await fs.mkdtemp(path.join(os.tmpdir(), 'tm-complexity-test-')); | ||
|
|
||
| // Initialize storage | ||
| storage = new FileStorage(tempDir); | ||
| await storage.initialize(); | ||
| }); | ||
|
|
||
| afterEach(async () => { | ||
| // Cleanup | ||
| await storage.close(); | ||
| await fs.rm(tempDir, { recursive: true, force: true }); | ||
| }); | ||
|
|
||
| it('should enrich tasks with complexity data for tagged tasks', async () => { | ||
| const tag = 'foo'; | ||
|
|
||
| // Step 1: Create tasks with the 'foo' tag | ||
| const tasks: Task[] = [ | ||
| { | ||
| id: '1', | ||
| title: 'Implement authentication', | ||
| description: 'Add JWT-based auth', | ||
| status: 'pending', | ||
| priority: 'high', | ||
| dependencies: [], | ||
| subtasks: [], | ||
| tags: [tag] | ||
| }, | ||
| { | ||
| id: '2', | ||
| title: 'Create API endpoints', | ||
| description: 'Build REST API', | ||
| status: 'pending', | ||
| priority: 'medium', | ||
| dependencies: [], | ||
| subtasks: [], | ||
| tags: [tag] | ||
| } | ||
| ]; | ||
|
|
||
| await storage.saveTasks(tasks, tag); | ||
|
|
||
| // Step 2: Create a complexity report for the 'foo' tag | ||
| const reportsDir = path.join(tempDir, '.taskmaster', 'reports'); | ||
| await fs.mkdir(reportsDir, { recursive: true }); | ||
|
|
||
| const complexityReport: ComplexityReport = { | ||
| meta: { | ||
| generatedAt: new Date().toISOString(), | ||
| tasksAnalyzed: 2, | ||
| thresholdScore: 5, | ||
| usedResearch: false | ||
| }, | ||
| complexityAnalysis: [ | ||
| { | ||
| taskId: '1', | ||
| taskTitle: 'Implement authentication', | ||
| complexityScore: 8, | ||
| recommendedSubtasks: 5, | ||
| complexityReasoning: 'High complexity due to security concerns', | ||
| expansionPrompt: 'Break down auth into smaller tasks' | ||
| }, | ||
| { | ||
| taskId: '2', | ||
| taskTitle: 'Create API endpoints', | ||
| complexityScore: 6, | ||
| recommendedSubtasks: 4, | ||
| complexityReasoning: 'Moderate complexity', | ||
| expansionPrompt: 'Split by endpoint functionality' | ||
| } | ||
| ] | ||
| }; | ||
|
|
||
| const reportPath = path.join(reportsDir, `task-complexity-report_${tag}.json`); | ||
| await fs.writeFile(reportPath, JSON.stringify(complexityReport, null, 2), 'utf-8'); | ||
|
|
||
| // Step 3: Load tasks with the tag - complexity should be enriched | ||
| const loadedTasks = await storage.loadTasks(tag); | ||
|
|
||
| // Verify tasks were loaded | ||
| expect(loadedTasks).toHaveLength(2); | ||
|
|
||
| // Step 4: Verify complexity data was enriched | ||
| const task1 = loadedTasks.find(t => t.id === '1'); | ||
| const task2 = loadedTasks.find(t => t.id === '2'); | ||
|
|
||
| expect(task1).toBeDefined(); | ||
| expect(task2).toBeDefined(); | ||
|
|
||
| // BUG: These assertions should pass but currently fail | ||
| expect(task1!.complexity).toBe(8); | ||
| expect(task1!.recommendedSubtasks).toBe(5); | ||
| expect(task1!.expansionPrompt).toBe('Break down auth into smaller tasks'); | ||
|
|
||
| expect(task2!.complexity).toBe(6); | ||
| expect(task2!.recommendedSubtasks).toBe(4); | ||
| expect(task2!.expansionPrompt).toBe('Split by endpoint functionality'); | ||
| }); | ||
|
|
||
| it('should handle master tag complexity enrichment', async () => { | ||
| // Test with default 'master' tag (no suffix in report filename) | ||
| const tasks: Task[] = [ | ||
| { | ||
| id: '1', | ||
| title: 'Setup project', | ||
| description: 'Initialize project structure', | ||
| status: 'pending', | ||
| priority: 'high', | ||
| dependencies: [], | ||
| subtasks: [], | ||
| tags: [] | ||
| } | ||
| ]; | ||
|
|
||
| await storage.saveTasks(tasks); | ||
|
|
||
| // Create complexity report for master tag (no suffix) | ||
| const reportsDir = path.join(tempDir, '.taskmaster', 'reports'); | ||
| await fs.mkdir(reportsDir, { recursive: true }); | ||
|
|
||
| const complexityReport: ComplexityReport = { | ||
| meta: { | ||
| generatedAt: new Date().toISOString(), | ||
| tasksAnalyzed: 1, | ||
| thresholdScore: 5, | ||
| usedResearch: false | ||
| }, | ||
| complexityAnalysis: [ | ||
| { | ||
| taskId: '1', | ||
| taskTitle: 'Setup project', | ||
| complexityScore: 3, | ||
| recommendedSubtasks: 2, | ||
| complexityReasoning: 'Low complexity', | ||
| expansionPrompt: 'Simple setup tasks' | ||
| } | ||
| ] | ||
| }; | ||
|
|
||
| const reportPath = path.join(reportsDir, 'task-complexity-report.json'); | ||
| await fs.writeFile(reportPath, JSON.stringify(complexityReport, null, 2), 'utf-8'); | ||
|
|
||
| // Load tasks without specifying tag (defaults to master) | ||
| const loadedTasks = await storage.loadTasks(); | ||
|
|
||
| expect(loadedTasks).toHaveLength(1); | ||
| expect(loadedTasks[0].complexity).toBe(3); | ||
| expect(loadedTasks[0].recommendedSubtasks).toBe(2); | ||
| }); | ||
|
|
||
| it('should return tasks without complexity when no report exists', async () => { | ||
| const tag = 'no-report'; | ||
| const tasks: Task[] = [ | ||
| { | ||
| id: '1', | ||
| title: 'Test task', | ||
| description: 'A test', | ||
| status: 'pending', | ||
| priority: 'medium', | ||
| dependencies: [], | ||
| subtasks: [], | ||
| tags: [tag] | ||
| } | ||
| ]; | ||
|
|
||
| await storage.saveTasks(tasks, tag); | ||
| const loadedTasks = await storage.loadTasks(tag); | ||
|
|
||
| expect(loadedTasks).toHaveLength(1); | ||
| expect(loadedTasks[0].complexity).toBeUndefined(); | ||
| expect(loadedTasks[0].recommendedSubtasks).toBeUndefined(); | ||
| }); | ||
| }); |
Contributor
There was a problem hiding this comment.
CI formatting failure needs to be addressed.
The pipeline reports the formatter would change this file; please run the formatter (e.g., biome format .) before merging.
🧰 Tools
🪛 GitHub Actions: CI
[error] 15-18: Formatter would have printed changes for complexity-enrichment.test.ts. Run the format tool (e.g., biome format .) to fix code style issues.
🤖 Prompt for AI Agents
In `@packages/tm-core/tests/integration/storage/complexity-enrichment.test.ts`
around lines 1 - 195, The file fails CI formatting; run the project formatter
(e.g., `biome format .` or the repo's configured formatter) and commit the
result so the test file (the describe/it/beforeEach/afterEach blocks that use
FileStorage, saveTasks, loadTasks) matches the repo style; ensure whitespace,
imports, and trailing newlines are fixed and re-run tests to confirm formatting
is clean before merging.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| expect(task1).toBeDefined(); | ||
| expect(task2).toBeDefined(); | ||
|
|
||
| // BUG: These assertions should pass but currently fail |
There was a problem hiding this comment.
Outdated comment misleadingly describes passing tests as failing
Low Severity
The comment // BUG: These assertions should pass but currently fail is misleading. Since the fix for issue #1614 is included in this same PR, these assertions will pass after the PR merges. The comment reads as if the tests are expected to fail, which could confuse future developers reviewing the test or investigating test failures. The comment documents historical context but is stale by the time this PR lands.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
Related Issues
How to Test This
# Example commands or stepsExpected result:
Contributor Checklist
npm run changesetnpm testnpm run format-check(ornpm run formatto fix)Changelog Entry
For Maintainers
Note
Medium Risk
Touches task complexity report loading/enrichment behavior, which can affect
listoutput for tagged task sets; change is small but in shared core code paths.Overview
Fixes tagged complexity enrichment (Fixes #1614).
ComplexityReportManager.loadReportnow uses the resolved tag (defaulting tomaster) consistently for both cache lookup and report file path resolution, preventing cache/path mismatches whentagis undefined.Adds a new integration test (
complexity-enrichment.test.ts) that reproduces the missing-complexity-in-listscenario for tagged tasks, covers themasterdefault report filename behavior, and verifies the no-report fallback.Also rolls up release bookkeeping: replaces multiple old changesets with a new
@tm/corepatch changeset, updatesCHANGELOG.md, and bumps versions to0.43.0inpackage.json,package-lock.json, andmanifest.json.Written by Cursor Bugbot for commit 43ee902. This will update automatically on new commits. Configure here.
Summary by CodeRabbit
New Features
Bug Fixes
Improvements
✏️ Tip: You can customize this high-level summary in your review settings.