add type hint/updates for code coverage

Author: TheTechsTech

lib/Database.php

@@ -28,7 +28,7 @@ private function __wakeup() {}
      * @param mixed $setting - SQL connection parameters
      * @param mixed $tag - Store the instance for later use
      */
-    public static function initialize(string $vendor = null, $setting = null, string $tag = null)
+    public static function initialize(string $vendor = null, array $setting = null, string $tag = null)
     {
         if (isset(self::$instances[$vendor]))
             return \setInstance(self::$instances[$vendor]) ? self::$instances[$vendor] : false;

lib/ezFunctions.php

@@ -10,7 +10,7 @@
 global $ezInstance;
 
 if (!function_exists('ezFunctions')) {
-    function database(string $sqlDriver = null, $connectionSetting = null, string $instanceTag = null)
+    function database(string $sqlDriver = null, array $connectionSetting = null, string $instanceTag = null)
     {
         return Database::initialize($sqlDriver, $connectionSetting, $instanceTag);
     }
@@ -20,27 +20,27 @@ function tagInstance(string $getTag = null)
         return \database($getTag);
     }
 
-    function mysqlInstance($databaseSetting = null, $instanceTag = null)
+    function mysqlInstance(array $databaseSetting = null, string $instanceTag = null)
     {
         return \database(\MYSQLI, $databaseSetting, $instanceTag);
     }
 
-    function pgsqlInstance($databaseSetting = null, $instanceTag = null)
+    function pgsqlInstance(array $databaseSetting = null, string $instanceTag = null)
     {
         return \database(\PGSQL, $databaseSetting, $instanceTag);
     }
 
-    function mssqlInstance($databaseSetting = null, $instanceTag = null)
+    function mssqlInstance(array $databaseSetting = null, string $instanceTag = null)
     {
         return \database(\MSSQL, $databaseSetting, $instanceTag);
     }
 
-    function pdoInstance($databaseSetting = null, $instanceTag = null)
+    function pdoInstance(array $databaseSetting = null, string $instanceTag = null)
     {
         return \database(\Pdo, $databaseSetting, $instanceTag);
     }
 
-    function sqliteInstance($databaseSetting = null, $instanceTag = null)
+    function sqliteInstance(array $databaseSetting = null, string $instanceTag = null)
     {
         return \database(\SQLITE3, $databaseSetting, $instanceTag);
     }

tests/DatabaseTest.php

@@ -17,6 +17,7 @@ class DatabaseTest extends EZTestCase
     * @covers ezsql\Database::Initialize
     * @covers ezsql\Database::benchmark
     * @covers \setInstance
+    * @covers \tagInstance
     */
     public function testInitialize()
     {
@@ -26,13 +27,14 @@ public function testInitialize()
             );
         }
 
-        $mysqli = Database::initialize(MYSQLI, [self::TEST_DB_USER, self::TEST_DB_PASSWORD, self::TEST_DB_NAME]);
+        $mysqli = Database::initialize(MYSQLI, [self::TEST_DB_USER, self::TEST_DB_PASSWORD, self::TEST_DB_NAME], MYSQLI);
         $this->assertFalse($mysqli instanceof ConfigInterface);
         $this->assertTrue($mysqli->settings() instanceof ConfigInterface);
         $this->assertTrue($mysqli instanceof ez_mysqli);
         $this->assertTrue($mysqli->getShow_Errors());
         $benchmark = Database::benchmark();
         $this->assertNotNull($benchmark['start']);
+        $this->assertSame($mysqli, \tagInstance(MYSQLI));
     }
 
     /**