Added test + some refactoring

Author: mateuszbieniek

eZ/Publish/API/Repository/Tests/SearchServiceLocationTest.php

@@ -101,6 +101,35 @@ protected function createMultipleCountriesContent()
         return $content;
     }
 
+    /**
+     * Create test Content with non-printable characters in name.
+     *
+     * @return \eZ\Publish\API\Repository\Values\Content\Content
+     */
+    protected function createFolderWithNonPrintableUtf8Characters()
+    {
+        $repository = $this->getRepository();
+        $contentTypeService = $repository->getContentTypeService();
+        $contentService = $repository->getContentService();
+
+        $contentType = $contentTypeService->loadContentTypeByIdentifier('folder');
+        $createStruct = $contentService->newContentCreateStruct($contentType, 'eng-GB');
+        $createStruct->remoteId = 'non-printable-char-folder-123';
+        $createStruct->alwaysAvailable = false;
+        $createStruct->setField(
+            'name',
+            utf8_decode("Non\x09Printable\x0EFolder")
+        );
+
+        $locationCreateStruct = $repository->getLocationService()->newLocationCreateStruct(2);
+        $draft = $contentService->createContent($createStruct, [$locationCreateStruct]);
+        $content = $contentService->publishVersion($draft->getVersionInfo());
+
+        $this->refreshSearch($repository);
+
+        return $content;
+    }
+
     /**
      * Test for the findLocations() method.
      *
@@ -157,6 +186,35 @@ public function testFieldCollectionContainsNoMatch()
         $this->assertEquals(0, $result->totalCount);
     }
 
+    /**
+     * Test for the findLocations() method.
+     *
+     * @see \eZ\Publish\API\Repository\SearchService::findLocations()
+     */
+    public function testNonPrintableUtf8Characters()
+    {
+        $folder = $this->createFolderWithNonPrintableUtf8Characters();
+        $query = new LocationQuery(
+            [
+                'query' => new Criterion\Field(
+                    'name',
+                    Criterion\Operator::EQ,
+                    utf8_decode("Non\x09Printable\x0EFolder")
+                ),
+            ]
+        );
+
+        $repository = $this->getRepository();
+        $searchService = $repository->getSearchService();
+        $result = $searchService->findLocations($query);
+
+        $this->assertEquals(1, $result->totalCount);
+        $this->assertEquals(
+            $folder->contentInfo->mainLocationId,
+            $result->searchHits[0]->valueObject->id
+        );
+    }
+
     /**
      * @expectedException \eZ\Publish\API\Repository\Exceptions\InvalidArgumentException
      */

eZ/Publish/Core/Search/Common/FieldValueMapper/StringMapper.php

@@ -17,6 +17,10 @@
  */
 class StringMapper extends FieldValueMapper
 {
+    public const REPLACE_WITH_SPACE_PATTERN = '([\x09\x0B\x0C]+)';
+    public const REMOVE_PATTERN = '([\x00-\x08\x0E-\x1F]+)';
+
+
     /**
      * Check if field can be mapped.
      *
@@ -53,14 +57,14 @@ protected function convert($value)
     {
         // Replace tab, vertical tab, form-feed chars to single space.
         $value = preg_replace(
-            '([\x09\x0B\x0C]+)',
+            self::REPLACE_WITH_SPACE_PATTERN,
             ' ',
             (string)$value
         );
 
-        // Remove non-printable characters (except LF and CR).
+        // Remove non-printable characters.
         return preg_replace(
-            '([\x00-\x08\x0E-\x1F]+)',
+            self::REMOVE_PATTERN,
             '',
             (string)$value
         );