Skip to content

Commit 0926f87

Browse files
committed
refactor
1 parent b96d6a9 commit 0926f87

File tree

8 files changed

+10
-27
lines changed

8 files changed

+10
-27
lines changed

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ build/
44

55
# Local configuration file (sdk path, etc)
66
local.properties
7+
keystore.properties
78

89
# Log/OS Files
910
*.log

core/common/src/main/kotlin/com/espressodev/gptmap/core/common/util/keyboardAsState.kt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
package com.espressodev.gptmap.core.common.util
22

33
import android.graphics.Rect
4-
import android.util.Log
54
import android.view.ViewTreeObserver
65
import androidx.compose.runtime.Composable
76
import androidx.compose.runtime.DisposableEffect
@@ -14,7 +13,6 @@ import androidx.compose.ui.platform.LocalView
1413
fun keyboardAsState(): State<Boolean> {
1514
val keyboardState = remember { mutableStateOf(false) }
1615
val view = LocalView.current
17-
Log.d("keyboardAsState", "view: ${view.hashCode()}")
1816
DisposableEffect(view) {
1917
val onGlobalListener = ViewTreeObserver.OnGlobalLayoutListener {
2018
val rect = Rect()

core/designsystem/src/main/kotlin/com/espressodev/gptmap/core/designsystem/theme/Theme.kt

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,11 @@
11
package com.espressodev.gptmap.core.designsystem.theme
22

3-
import android.app.Activity
43
import androidx.compose.foundation.isSystemInDarkTheme
54
import androidx.compose.material3.MaterialTheme
65
import androidx.compose.material3.darkColorScheme
76
import androidx.compose.material3.lightColorScheme
87
import androidx.compose.runtime.Composable
98
import androidx.compose.runtime.CompositionLocalProvider
10-
import androidx.compose.runtime.SideEffect
11-
import androidx.compose.ui.graphics.toArgb
12-
import androidx.compose.ui.platform.LocalView
13-
import androidx.core.view.WindowCompat
149

1510
private val LightColors = lightColorScheme(
1611
primary = md_theme_light_primary,
@@ -87,15 +82,6 @@ fun GptmapTheme(
8782
}
8883

8984
val gmColorPalette = if (!darkTheme) LightGmColorsPalette else DarkGmColorsPalette
90-
91-
val view = LocalView.current
92-
if (!view.isInEditMode) {
93-
SideEffect {
94-
val window = (view.context as Activity).window
95-
window.statusBarColor = colorScheme.primary.toArgb()
96-
WindowCompat.getInsetsController(window, view).isAppearanceLightStatusBars = darkTheme
97-
}
98-
}
9985
CompositionLocalProvider(LocalGmColorsPalette provides gmColorPalette) {
10086
MaterialTheme(
10187
colorScheme = colorScheme,

core/designsystem/src/main/res/values/strings.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,8 @@
4242
<string name="send">Send</string>
4343
<string name="message">Message</string>
4444
<string name="screenshot_gallery">Screenshot Gallery</string>
45+
<string name="screenshots">Screenshots</string>
46+
<string name="favourites">Favourites</string>
4547
<string name="edit">Edit</string>
4648
<string name="logout">Logout</string>
4749

core/save-screenshot/src/main/kotlin/com/espressodev/gptmap/core/save_screenshot/composable/SaveScreenshot.kt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,13 +22,12 @@ import com.espressodev.gptmap.core.save_screenshot.SaveScreenshotService
2222

2323
@Composable
2424
fun SaveScreenshot(
25-
onConfirm: () -> Unit,
2625
onSuccess: () -> Unit,
2726
modifier: Modifier = Modifier,
27+
onConfirm: () -> Unit = {},
2828
viewModel: ScreenshotViewModel = hiltViewModel(),
2929
) {
3030
val uiState by viewModel.uiState.collectAsStateWithLifecycle()
31-
Log.d("SaveScreenshot", "uiState: $uiState")
3231
LaunchedEffect(key1 = uiState.screenState) {
3332
when (uiState.screenState) {
3433
ScreenState.Finished -> {

feature/profile/src/main/kotlin/com/espressodev/gptmap/feature/profile/ProfileViewModel.kt

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ package com.espressodev.gptmap.feature.profile
22

33
import androidx.lifecycle.viewModelScope
44
import com.espressodev.gptmap.core.common.GmViewModel
5-
import com.espressodev.gptmap.core.common.splash_navigation.SplashNavigationManager
65
import com.espressodev.gptmap.core.data.AccountService
76
import com.espressodev.gptmap.core.data.FirestoreService
87
import com.espressodev.gptmap.core.data.LogService
@@ -27,7 +26,7 @@ import javax.inject.Inject
2726
class ProfileViewModel @Inject constructor(
2827
private val accountService: AccountService,
2928
private val realmAccountService: RealmAccountService,
30-
private val firestoreService: FirestoreService,
29+
firestoreService: FirestoreService,
3130
ioDispatcher: CoroutineDispatcher,
3231
logService: LogService
3332
) : GmViewModel(logService) {
@@ -58,7 +57,6 @@ class ProfileViewModel @Inject constructor(
5857
fun onLogoutClick(navigate: () -> Unit) = launchCatching {
5958
accountService.signOut()
6059
realmAccountService.logOut()
61-
SplashNavigationManager.onLogout()
6260
navigate()
6361
}
6462

feature/screenshot-gallery/src/main/kotlin/com/espressodev/gptmap/feature/screenshot_gallery/ScreenshotGalleryScreen.kt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,6 @@ fun ScreenshotGalleryRoute(
101101
}
102102
}
103103
}
104-
105104
}
106105

107106
@OptIn(ExperimentalFoundationApi::class)
@@ -245,7 +244,7 @@ fun DotsIndicator(
245244
totalDots: Int,
246245
selectedIndex: Int,
247246
modifier: Modifier = Modifier,
248-
activeDotColor: Color = Color.Black,
247+
activeDotColor: Color = Color.White,
249248
inactiveDotColor: Color = Color.LightGray,
250249
spacing: Dp = 8.dp,
251250
selectedDotSize: Dp = 16.dp,

feature/screenshot/src/main/kotlin/com/espressodev/gptmap/feature/screenshot/ScreenshotNavigation.kt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,14 +5,14 @@ import androidx.navigation.NavGraphBuilder
55
import androidx.navigation.NavOptions
66
import androidx.navigation.compose.composable
77

8-
const val SCREENSHOT_ROUTE = "screenshot_route"
8+
const val ScreenshotRoute = "screenshot_route"
99

1010
fun NavController.navigateToScreenshot(navOptions: NavOptions? = null) {
11-
navigate(SCREENSHOT_ROUTE)
11+
navigate(ScreenshotRoute, navOptions)
1212
}
1313

1414
fun NavGraphBuilder.screenshotScreen(popUp: () -> Unit, navigateToMap: () -> Unit) {
15-
composable(SCREENSHOT_ROUTE) {
15+
composable(ScreenshotRoute) {
1616
ScreenshotRoute(popUp = popUp, navigateToMap)
1717
}
18-
}
18+
}

0 commit comments

Comments
 (0)