Skip to content

Commit a816eab

Browse files
committed
Fix NPE bug when viewing about screen
1 parent deff630 commit a816eab

File tree

3 files changed

+7
-6
lines changed

3 files changed

+7
-6
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,10 @@ Change Log
33

44
This is a changelog of the app internals, not just user facing features.
55

6+
Version 1.1.2
7+
----------------------------
8+
* Fix NPE bug when viewing about screen
9+
610
Version 1.1.1
711
----------------------------
812
* Add frames for HTC One

app/src/main/java/com/f2prateek/dfg/DFGModule.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@
3939
injects = {
4040
DFGApplication.class, BaseActivity.class, MainActivity.class, ReceiverActivity.class,
4141
DeviceFragment.class, AboutFragment.class, AbstractGenerateFrameService.class,
42-
GenerateFrameService.class, GenerateMultipleFramesService.class
42+
GenerateFrameService.class, GenerateMultipleFramesService.class, AboutFragment.class
4343
}
4444

4545
)

app/src/main/java/com/f2prateek/dfg/ui/AboutFragment.java

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@
2828
import butterknife.InjectView;
2929
import butterknife.OnClick;
3030
import butterknife.Views;
31+
import com.f2prateek.dfg.DFGApplication;
3132
import com.f2prateek.dfg.R;
3233
import javax.inject.Inject;
3334

@@ -40,6 +41,7 @@ public class AboutFragment extends DialogFragment {
4041
public void onCreate(Bundle savedInstanceState) {
4142
super.onCreate(savedInstanceState);
4243
setStyle(STYLE_NO_TITLE, getTheme());
44+
((DFGApplication) getActivity().getApplication()).inject(this);
4345
}
4446

4547
@Override
@@ -52,11 +54,6 @@ public View onCreateView(LayoutInflater inflater, ViewGroup container,
5254
return v;
5355
}
5456

55-
@Override
56-
public void onViewCreated(View view, Bundle savedInstanceState) {
57-
super.onViewCreated(view, savedInstanceState);
58-
}
59-
6057
@OnClick({
6158
R.id.iv_app_logo, R.id.tv_gplus, R.id.tv_twitter, R.id.tv_designer
6259
})

0 commit comments

Comments
 (0)