Skip to content

Commit ebe4f4f

Browse files
srcejonsrcejon
committed
Fix lint warnings.
1 parent 6f8b5a2 commit ebe4f4f

File tree

9 files changed

+22
-22
lines changed

9 files changed

+22
-22
lines changed

‎plugins/channelrx/demodinmarsat/inmarsatdemod.cpp‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -143,15 +143,15 @@ bool InmarsatDemod::handleMessage(const Message& cmd)
143143
{
144144
if (MsgConfigureInmarsatDemod::match(cmd))
145145
{
146-
MsgConfigureInmarsatDemod& cfg = (MsgConfigureInmarsatDemod&) cmd;
146+
const MsgConfigureInmarsatDemod& cfg = (const MsgConfigureInmarsatDemod&) cmd;
147147
qDebug() << "InmarsatDemod::handleMessage: MsgConfigureInmarsatDemod";
148148
applySettings(cfg.getSettings(), cfg.getSettingsKeys(), cfg.getForce());
149149

150150
return true;
151151
}
152152
else if (DSPSignalNotification::match(cmd))
153153
{
154-
DSPSignalNotification& notif = (DSPSignalNotification&) cmd;
154+
const DSPSignalNotification& notif = (const DSPSignalNotification&) cmd;
155155
m_basebandSampleRate = notif.getSampleRate();
156156
m_centerFrequency = notif.getCenterFrequency();
157157
// Forward to the sink
@@ -168,7 +168,7 @@ bool InmarsatDemod::handleMessage(const Message& cmd)
168168
else if (MainCore::MsgPacket::match(cmd))
169169
{
170170
// Forward to GUI
171-
MainCore::MsgPacket& report = (MainCore::MsgPacket&)cmd;
171+
const MainCore::MsgPacket& report = (const MainCore::MsgPacket&)cmd;
172172
if (getMessageQueueToGUI())
173173
{
174174
MainCore::MsgPacket *msg = new MainCore::MsgPacket(report);

‎plugins/channelrx/demodinmarsat/inmarsatdemod.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ class InmarsatDemod : public BasebandSampleSink, public ChannelAPI {
6868
{ }
6969
};
7070

71-
InmarsatDemod(DeviceAPI *deviceAPI);
71+
explicit InmarsatDemod(DeviceAPI *deviceAPI);
7272
virtual ~InmarsatDemod();
7373
virtual void destroy() { delete this; }
7474
virtual void setDeviceAPI(DeviceAPI *deviceAPI);

‎plugins/channelrx/demodinmarsat/inmarsatdemodbaseband.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ class InmarsatDemodBaseband : public QObject
6464
{ }
6565
};
6666

67-
InmarsatDemodBaseband(InmarsatDemod *packetDemod);
67+
explicit InmarsatDemodBaseband(InmarsatDemod *packetDemod);
6868
~InmarsatDemodBaseband();
6969
void reset();
7070
void startWork();

‎plugins/channelrx/demodinmarsat/inmarsatdemodgui.cpp‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@
4545

4646
#include "inmarsatdemod.h"
4747

48-
MultipartMessage::MultipartMessage(int id, std::map<std::string, std::string> params, const QDateTime& dateTime) :
48+
MultipartMessage::MultipartMessage(int id, std::map<std::string, std::string>& params, const QDateTime& dateTime) :
4949
m_id(id),
5050
m_icon(nullptr),
5151
m_latitude(0.0f),
@@ -54,7 +54,7 @@ MultipartMessage::MultipartMessage(int id, std::map<std::string, std::string> pa
5454
update(params, dateTime);
5555
}
5656

57-
void MultipartMessage::update(std::map<std::string, std::string> params, const QDateTime& dateTime)
57+
void MultipartMessage::update(std::map<std::string, std::string>& params, const QDateTime& dateTime)
5858
{
5959
m_dateTime = dateTime;
6060
m_service = QString::fromStdString(params["serviceCodeAndAddressName"]);
@@ -1324,7 +1324,7 @@ void InmarsatDemodGUI::handleInputMessages()
13241324
{
13251325
Message* message;
13261326

1327-
while ((message = getInputMessageQueue()->pop()) != 0)
1327+
while ((message = getInputMessageQueue()->pop()) != nullptr)
13281328
{
13291329
if (handleMessage(*message))
13301330
{

‎plugins/channelrx/demodinmarsat/inmarsatdemodgui.h‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -62,8 +62,8 @@ struct MessagePart {
6262
class MultipartMessage {
6363
public:
6464

65-
MultipartMessage(int id, std::map<std::string, std::string> params, const QDateTime& dateTime);
66-
void update(std::map<std::string, std::string> params, const QDateTime& dateTime);
65+
explicit MultipartMessage(int id, std::map<std::string, std::string>& params, const QDateTime& dateTime);
66+
void update(std::map<std::string, std::string>& params, const QDateTime& dateTime);
6767
void addPart(const MessagePart& part);
6868
QString getMessage() const;
6969
int getParts() const { return m_parts.size(); }
@@ -157,7 +157,7 @@ public slots:
157157
QRegularExpression m_typeRE;
158158
QRegularExpression m_messageRE;
159159

160-
explicit InmarsatDemodGUI(PluginAPI* pluginAPI, DeviceUISet *deviceUISet, BasebandSampleSink *rxChannel, QWidget* parent = 0);
160+
explicit InmarsatDemodGUI(PluginAPI* pluginAPI, DeviceUISet *deviceUISet, BasebandSampleSink *rxChannel, QWidget* parent = nullptr);
161161
virtual ~InmarsatDemodGUI();
162162

163163
void blockApplySettings(bool block);

‎plugins/channelrx/demodinmarsat/inmarsatdemodplugin.cpp‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ ChannelGUI* InmarsatDemodPlugin::createRxChannelGUI(
7979
{
8080
(void) deviceUISet;
8181
(void) rxChannel;
82-
return 0;
82+
return nullptr;
8383
}
8484
#else
8585
ChannelGUI* InmarsatDemodPlugin::createRxChannelGUI(DeviceUISet *deviceUISet, BasebandSampleSink *rxChannel) const

‎plugins/channelrx/demodinmarsat/inmarsatdemodsettings.cpp‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,14 +41,14 @@ void InmarsatDemodSettings::appendDefaultColumnSettings()
4141
appendDefaultColumnSizes(m_messagesColumnSizes, INMARSATDEMOD_MESSAGES_COLUMNS);
4242
}
4343

44-
void InmarsatDemodSettings::appendDefaultColumnIndexes(QList<int>& list, int size)
44+
void InmarsatDemodSettings::appendDefaultColumnIndexes(QList<int>& list, int size) const
4545
{
4646
while (list.size() < size) {
4747
list.append(list.size());
4848
}
4949
}
5050

51-
void InmarsatDemodSettings::appendDefaultColumnSizes(QList<int>& list, int size)
51+
void InmarsatDemodSettings::appendDefaultColumnSizes(QList<int>& list, int size) const
5252
{
5353
while (list.size() < size) {
5454
list.append(-1);

‎plugins/channelrx/demodinmarsat/inmarsatdemodsettings.h‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -86,8 +86,8 @@ struct InmarsatDemodSettings
8686
void applySettings(const QStringList& settingsKeys, const InmarsatDemodSettings& settings);
8787
QString getDebugString(const QStringList& settingsKeys, bool force = false) const;
8888
void appendDefaultColumnSettings();
89-
void appendDefaultColumnIndexes(QList<int>& list, int size);
90-
void appendDefaultColumnSizes(QList<int>& list, int size);
89+
void appendDefaultColumnIndexes(QList<int>& list, int size) const;
90+
void appendDefaultColumnSizes(QList<int>& list, int size) const;
9191
};
9292

9393
#endif /* INCLUDE_INMARSATDEMODSETTINGS_H */

‎plugins/channelrx/demodinmarsat/inmarsatdemodsink.h‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ class ScopeVis;
4242
// Automatic Gain Control
4343
class AGC {
4444
public:
45-
AGC();
45+
explicit AGC();
4646
Complex processOneSample(const Complex &iq, bool locked);
4747
Real getGain() const { return m_gain; }
4848
Real getAverage() const { return m_agcMovingAverage.instantAverage(); }
@@ -54,7 +54,7 @@ class AGC {
5454

5555
class FrequencyOffsetEstimate {
5656
public:
57-
FrequencyOffsetEstimate();
57+
explicit FrequencyOffsetEstimate();
5858
~FrequencyOffsetEstimate();
5959
void processOneSample(Complex& iq, bool locked);
6060
Real getFreqHz() const { return m_freqOffsetHz; }
@@ -81,7 +81,7 @@ class FrequencyOffsetEstimate {
8181
// Circular symbol/bit buffer for unique word detection, EVM calculation and equalizer training
8282
class SymbolBuffer {
8383
public:
84-
SymbolBuffer(int size=64*162);
84+
explicit SymbolBuffer(int size=64*162);
8585
void push(quint8 bit, Complex symbol);
8686
bool checkUW() const;
8787
Complex getSymbol(int idx) const;
@@ -98,7 +98,7 @@ class SymbolBuffer {
9898

9999
class Equalizer {
100100
public:
101-
Equalizer(int samplesPerSymbol);
101+
explicit Equalizer(int samplesPerSymbol);
102102
virtual ~Equalizer() {}
103103
virtual Complex processOneSample(Complex x, bool update, bool training=false) = 0;
104104
Complex getError() const { return m_error; }
@@ -114,14 +114,14 @@ class Equalizer {
114114
// Constant Modulus Equalizer
115115
class CMAEqualizer : public Equalizer {
116116
public:
117-
CMAEqualizer(int samplesPerSymbol);
117+
explicit CMAEqualizer(int samplesPerSymbol);
118118
Complex processOneSample(Complex x, bool update, bool training=false) override;
119119
};
120120

121121
// Least Mean Square Equalizer
122122
class LMSEqualizer : public Equalizer {
123123
public:
124-
LMSEqualizer(int samplesPerSymbol);
124+
explicit LMSEqualizer(int samplesPerSymbol);
125125
Complex processOneSample(Complex x, bool update, bool training=false) override;
126126
};
127127

0 commit comments

Comments
 (0)