template: Only use JsonTransformStrategy when contentType is 'application/json'

Also make transformStrategies customizable (similar to mergeStrategies).

NOTE: Templates that were relying on this behavior for plain text (the
default contentType) templates will need to be updated to use the
'application/json' contentType, or specify a custom TransformStrategy.

Author: mstokes-f5

index.js

@@ -26,7 +26,9 @@ const {
     CompositeTemplateProvider
 } = require('./lib/template_provider');
 const { GitHubTemplateProvider, GitHubSchemaProvider } = require('./lib/github_provider');
-const { Template, mergeStrategies, postProcessStrategies } = require('./lib/template');
+const {
+    Template, mergeStrategies, postProcessStrategies, transformStrategies
+} = require('./lib/template');
 const guiUtils = require('./lib/gui_utils');
 const TransactionLogger = require('./lib/transaction_logger');
 
@@ -42,6 +44,7 @@ module.exports = {
     Template,
     mergeStrategies,
     postProcessStrategies,
+    transformStrategies,
     guiUtils,
     dataStores,
     TransactionLogger

lib/template.js

@@ -106,6 +106,13 @@ function nodeHttpToAxios(configObj) {
     }
 }
 
+/**
+ * TransformStrategy for plain text output
+ */
+function PlainTextTransformStrategy(_schema, value) {
+    return value;
+}
+
 /**
  * TransformStrategy for JSON output
  */
@@ -133,6 +140,15 @@ function JsonTransformStrategy(schema, value) {
     return value;
 }
 
+/**
+ * Object containing available transform strategy functions.
+ * The property is a Content-Type MIME (e.g., `test/plain`).
+ * The value is a TransformStrategy function that accepts the parameter's schema and current value.
+ */
+const transformStrategies = {
+    'application/json': JsonTransformStrategy
+};
+
 /**
  * MergeStrategy for targeting `test/plain` Content-Type
  */
@@ -1070,7 +1086,7 @@ class Template {
      */
     transformParameters(parameters) {
         const schema = this.getParametersSchema();
-        const transform = JsonTransformStrategy;
+        const transform = transformStrategies[this.contentType] || PlainTextTransformStrategy;
         return Object.keys(parameters).reduce((acc, curr) => {
             const value = parameters[curr];
             const valueSchema = schema.properties && schema.properties[curr];
@@ -1255,5 +1271,6 @@ class Template {
 
 module.exports = {
     Template,
-    mergeStrategies
+    mergeStrategies,
+    transformStrategies
 };

test/template.js

@@ -526,7 +526,7 @@ describe('Template class tests', function () {
                 {{> numbpartial}}
                 {{> arraypartial}}
         `;
-        const reference = 'numb=5\narr=["1","2"]\n';
+        const reference = 'numb=5\narr=1,2\n';
         return Template.loadYaml(ymldata)
             .then((tmpl) => {
                 assert.strictEqual(tmpl.render(), reference);
@@ -604,22 +604,24 @@ describe('Template class tests', function () {
                 assert.strictEqual(schema.properties.virtual_port.type, 'integer');
             });
     });
-    it('render_array', function () {
+    it('render_json_array', function () {
         const mstdata = '{{values::array}}';
         const parameters = { values: ['1', '2', '3'] };
-        const reference = '["1","2","3"]';
+        const reference = '[\n  "1",\n  "2",\n  "3"\n]';
         return Template.loadMst(mstdata)
             .then((tmpl) => {
+                tmpl.contentType = 'application/json';
                 console.log(JSON.stringify(tmpl.getParametersSchema(), null, 2));
                 assert.strictEqual(tmpl.render(parameters), reference);
             });
     });
-    it('render_text', function () {
+    it('render_json_text', function () {
         const mstdata = '{{textvar::text}}';
         const parameters = { textvar: 'multi\nline' };
         const reference = '"multi\\nline"';
         return Template.loadMst(mstdata)
             .then((tmpl) => {
+                tmpl.contentType = 'application/json';
                 console.log(JSON.stringify(tmpl.getParametersSchema(), null, 2));
                 assert.strictEqual(tmpl.render(parameters), reference);
             });