template: Make validation errors from failed enum matches shorter

mstokes-f5 · mstokes-f5 · commit f1372e678756 · 2023-10-03T10:11:22.000-07:00
The list of allowed values has been moved from "messages" to "details".
diff --git a/lib/template.js b/lib/template.js
@@ -1092,8 +1092,8 @@ class Template {
             }
 
             if (error.keyword === 'enum') {
-                const allowedValues = error.params.allowedValues;
-                message = `${message}: ${allowedValues.join(', ')}`;
+                const allowedValues = error.params.allowedValues.join(', ');
+                details = `allowed values are: ${allowedValues}`;
             }
 
             if (error.keyword === 'pattern') {
diff --git a/test/template.js b/test/template.js
@@ -1349,7 +1349,8 @@ describe('Template class tests', function () {
                             message: 'parameter fooArray[1] should be of type string'
                         },
                         {
-                            message: 'parameter fooEnum should be equal to one of the allowed values: foo, bar'
+                            message: 'parameter fooEnum should be equal to one of the allowed values',
+                            details: 'allowed values are: foo, bar'
                         },
                         {
                             message: 'parameter foo should be of type string'

Original file line number	Diff line number	Diff line change
`@@ -1092,8 +1092,8 @@ class Template {`
`1092`	`1092`	`}`
`1093`	`1093`
`1094`	`1094`	`if (error.keyword === 'enum') {`
`1095`		`- const allowedValues = error.params.allowedValues;`
`1096`		- message = `${message}: ${allowedValues.join(', ')}`;
	`1095`	`+ const allowedValues = error.params.allowedValues.join(', ');`
	`1096`	+ details = `allowed values are: ${allowedValues}`;
`1097`	`1097`	`}`
`1098`	`1098`
`1099`	`1099`	`if (error.keyword === 'pattern') {`
Original file line number	Diff line number	Diff line change
`@@ -1349,7 +1349,8 @@ describe('Template class tests', function () {`
`1349`	`1349`	`message: 'parameter fooArray[1] should be of type string'`
`1350`	`1350`	`},`
`1351`	`1351`	`{`
`1352`		`- message: 'parameter fooEnum should be equal to one of the allowed values: foo, bar'`
	`1352`	`+ message: 'parameter fooEnum should be equal to one of the allowed values',`
	`1353`	`+ details: 'allowed values are: foo, bar'`
`1353`	`1354`	`},`
`1354`	`1355`	`{`
`1355`	`1356`	`message: 'parameter foo should be of type string'`