fix error handle

Signed-off-by: ふぁ <yuki@yuki0311.com>

Author: fa0311

DMMGamePlayerFastLauncher/lib/process_manager.py

@@ -15,9 +15,9 @@
 class ProcessManager:
     @staticmethod
     def admin_run(args: list[str], cwd: Optional[str] = None) -> int:
-        file, args = args[0], args[1:]
+        file = args.pop(0)
         logging.info({"cwd": cwd, "args": args, "file": file})
-        return ctypes.windll.shell32.ShellExecuteW(None, "runas", file, " ".join([f"{arg}" for arg in args]), cwd, 1)
+        return ctypes.windll.shell32.ShellExecuteW(None, "runas", str(file), " ".join([f"{arg}" for arg in args]), cwd, 1)
 
     @staticmethod
     def admin_check() -> bool:

DMMGamePlayerFastLauncher/tab/shortcut.py

@@ -1,6 +1,7 @@
 import json
 from pathlib import Path
 from tkinter import Frame, StringVar
+from typing import Callable
 
 import customtkinter as ctk
 import i18n
@@ -105,14 +106,12 @@ def save(self):
         with open(path, "w", encoding="utf-8") as f:
             f.write(json.dumps(self.data.to_dict()))
 
-    def failed_save(self):
-        path = DataPathConfig.SHORTCUT.joinpath(self.filename.get()).with_suffix(".json")
-        path.unlink()
+    def save_handler(self, fn: Callable[[], None]):
+        pass
 
     @error_toast
     def bypass_callback(self):
-        self.save()
-        try:
+        def fn():
             task = Schtasks(self.filename.get())
             if task.check():
                 task.set()
@@ -121,53 +120,52 @@ def bypass_callback(self):
             except Exception:
                 name, icon = self.filename.get(), None
                 self.toast.error(i18n.t("app.shortcut.game_info_error"))
-
             sorce = Env.DESKTOP.joinpath(name).with_suffix(".lnk")
             args = ["/run", "/tn", task.name]
             Shortcut().create(sorce=sorce, target=Env.SCHTASKS, args=args, icon=icon)
             self.toast.info(i18n.t("app.shortcut.save_success"))
-        except Exception:
-            self.failed_save()
-            raise
+
+        self.save_handler(fn)
 
     @error_toast
     def uac_callback(self):
-        self.save()
-        try:
+        def fn():
             try:
-                name, icon, admin = self.get_game_info()
+                try:
+                    name, icon, admin = self.get_game_info()
+                except Exception:
+                    name, icon = self.filename.get(), None
+                    self.toast.error(i18n.t("app.shortcut.game_info_error"))
+                sorce = Env.DESKTOP.joinpath(name).with_suffix(".lnk")
+                args = [self.filename.get()]
+                Shortcut().create(sorce=sorce, args=args, icon=icon)
+                self.toast.info(i18n.t("app.shortcut.save_success"))
             except Exception:
-                name, icon = self.filename.get(), None
-                self.toast.error(i18n.t("app.shortcut.game_info_error"))
+                DataPathConfig.SHORTCUT.joinpath(self.filename.get()).with_suffix(".json").unlink()
+                raise
 
-            sorce = Env.DESKTOP.joinpath(name).with_suffix(".lnk")
-            args = [self.filename.get()]
-            Shortcut().create(sorce=sorce, args=args, icon=icon)
-            self.toast.info(i18n.t("app.shortcut.save_success"))
-        except Exception:
-            self.failed_save()
-            raise
+        self.save_handler(fn)
 
     @error_toast
     def save_callback(self):
-        self.save()
-        try:
+        def fn():
             try:
-                name, icon, admin = self.get_game_info()
+                try:
+                    name, icon, admin = self.get_game_info()
+                except Exception:
+                    name, icon, admin = self.filename.get(), None, False
+                    self.toast.error(i18n.t("app.shortcut.game_info_error"))
+                if admin:
+                    raise Exception(i18n.t("app.shortcut.administrator_error"))
             except Exception:
-                name, icon, admin = self.filename.get(), None, False
-                self.toast.error(i18n.t("app.shortcut.game_info_error"))
-
-            if admin:
-                raise Exception(i18n.t("app.shortcut.administrator_error"))
-
+                DataPathConfig.SHORTCUT.joinpath(self.filename.get()).with_suffix(".json").unlink()
+                raise
             sorce = Env.DESKTOP.joinpath(name).with_suffix(".lnk")
             args = [self.filename.get()]
             Shortcut().create(sorce=sorce, args=args, icon=icon)
             self.toast.info(i18n.t("app.shortcut.save_success"))
-        except Exception:
-            self.failed_save()
-            raise
+
+        self.save_handler(fn)
 
     @error_toast
     def save_only_callback(self):
@@ -207,6 +205,10 @@ def create(self):
         super().create()
         return self
 
+    def save_handler(self, fn: Callable[[], None]):
+        self.save()
+        fn()
+
 
 class ShortcutEdit(ShortcutBase):
     selected: StringVar
@@ -231,23 +233,23 @@ def create(self):
 
         return self
 
-    def save(self):
-        selected = DataPathConfig.SHORTCUT.joinpath(self.selected.get()).with_suffix(".json")
-        selected.rename(selected.with_suffix(".json.bak"))
+    def save_handler(self, fn: Callable[[], None]):
+        selected = DataPathConfig.SHORTCUT.joinpath(self.selected.get())
+        selected.with_suffix(".json").rename(selected.with_suffix(".json.bak"))
         try:
-            super().save()
-            selected.with_suffix(".json.bak").unlink()
-            self.values.remove(self.selected.get())
-            self.values.append(self.filename.get())
-            self.selected.set(self.filename.get())
-            self.option_callback("_")
+            self.save()
+            try:
+                fn()
+            except Exception:
+                DataPathConfig.SHORTCUT.joinpath(self.filename.get()).with_suffix(".json").unlink()
         except Exception:
-            self.failed_save()
+            selected.with_suffix(".json.bak").rename(selected.with_suffix(".json"))
             raise
-
-    def failed_save(self):
-        selected = DataPathConfig.SHORTCUT.joinpath(self.selected.get()).with_suffix(".json")
-        selected.with_suffix(".json.bak").rename(selected.with_suffix(".json"))
+        selected.with_suffix(".json.bak").unlink()
+        self.values.remove(self.selected.get())
+        self.values.append(self.filename.get())
+        self.selected.set(self.filename.get())
+        self.option_callback("_")
 
     @error_toast
     def delete_callback(self):