Skip to content

Commit 3cd09e9

Browse files
authored
chore: bump cpp-sysroot (#55)
* chore: bump cpp-sysroot to 0.8.0 * fix tensorflow compilation * docker: remove trailing backslash * gha: remove rabe and jwt * nits from gemini * bump faasmctl * fix: bump faasm version
1 parent 59d4d2c commit 3cd09e9

File tree

9 files changed

+21
-41
lines changed

9 files changed

+21
-41
lines changed

.github/workflows/tests.yml

Lines changed: 2 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -61,18 +61,12 @@ jobs:
6161
if: ${{ needs.needs-build.outputs.needs-wasm == 'true' }}
6262
runs-on: ubuntu-latest
6363
container:
64-
image: ghcr.io/faasm/examples-build:0.6.0_0.4.0
64+
image: ghcr.io/faasm/examples-build:0.8.0_0.4.0
6565
steps:
6666
- name: "Checkout code"
6767
uses: actions/checkout@v4
6868
with:
6969
submodules: true
70-
- name: "Build Rabe and JWT"
71-
run: |
72-
export PATH=$PATH:/root/.cargo/env
73-
rustup default stable
74-
rustup target add wasm32-wasip1
75-
./bin/inv_wrapper.sh rabe jwt
7670
- name: "Build OpenCV"
7771
run: ./bin/inv_wrapper.sh opencv
7872
- name: "Build FFmpeg"
@@ -138,7 +132,7 @@ jobs:
138132
shell: bash
139133
env:
140134
FAASM_INI_FILE: ./faasm.ini
141-
FAASM_VERSION: 0.29.0
135+
FAASM_VERSION: 0.33.0
142136
FAASM_WASM_VM: ${{ matrix.faasm_wasm_vm }}
143137
steps:
144138
- uses: csegarragonz/set-compose-version-action@main
@@ -312,14 +306,6 @@ jobs:
312306
- name: "Run FFmpeg check"
313307
timeout-minutes: 1
314308
run: faasmctl invoke ffmpeg check
315-
- name: "Run Rabe test"
316-
if: "contains(env.FAASM_WASM_VM, 'wamr')"
317-
timeout-minutes: 1
318-
run: faasmctl invoke rabe test
319-
# - name: "Run JWT test"
320-
# if: "contains(env.FAASM_WASM_VM, 'wamr')"
321-
# timeout-minutes: 1
322-
# run: faasmctl invoke jwt test
323309
- name: "Print upload logs in case of failure"
324310
if: failure()
325311
run: faasmctl logs -s upload

docker/base.dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM ubuntu:22.04 AS base
1+
FROM ubuntu:24.04 AS base
22

33
RUN apt update \
44
&& apt install -y \

docker/build.dockerfile

Lines changed: 12 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
ARG CPP_VERSION
22
ARG EXAMPLES_VERSION
33
# Base image is not re-built often and tag may lag behind
4-
FROM ghcr.io/faasm/examples-base:0.6.0_0.4.0 AS base
4+
FROM ghcr.io/faasm/examples-base:0.8.0_0.4.0 AS base
55
FROM ghcr.io/faasm/cpp-sysroot:${CPP_VERSION:-dead}
66

77
SHELL ["/bin/bash", "-c"]
@@ -10,23 +10,27 @@ ENV IN_DOCKER="on"
1010
# Copy built OpenMPI from previous step
1111
COPY --from=base /tmp/openmpi-4.1.0/ /tmp/openmpi-4.1.0/
1212

13+
# Install OpenMP
14+
ARG DEBIAN_FRONTEND=noninteractive
15+
RUN apt update \
16+
&& apt install -y --no-install-recommends \
17+
build-essential \
18+
curl \
19+
libomp-17-dev \
20+
unzip \
21+
&& rm -rf /var/lib/apt/lists/*
22+
1323
# Install OpenMPI
1424
RUN cd /tmp/openmpi-4.1.0 \
1525
&& make install \
1626
&& cd /tmp \
1727
&& rm -rf /tmp/openmpi-4.1.0 /tmp/openmpi-4.1.0.tar.bz2
1828

19-
# Install OpenMP
20-
ARG DEBIAN_FRONTEND=noninteractive
21-
RUN apt update \
22-
&& apt install -y libomp-17-dev
23-
2429
# Install rust
2530
RUN curl --proto '=https' --tlsv1.3 https://sh.rustup.rs -sSf | sh -s -- -y \
2631
&& source ~/.cargo/env \
2732
&& rustup target add wasm32-wasip1
2833

29-
3034
# Fetch the code and update submodules
3135
ARG EXAMPLES_VERSION
3236
RUN mkdir -p code \
@@ -46,9 +50,7 @@ RUN mkdir -p code \
4650
&& git submodule update --init -f examples/LULESH \
4751
&& git submodule update --init -f examples/libpng \
4852
&& git submodule update --init -f examples/polybench \
49-
&& git submodule update --init -f examples/rabe \
50-
&& git submodule update --init -f examples/tensorflow \
51-
&& git submodule update --init -f examples/tless-jwt
53+
&& git submodule update --init -f examples/tensorflow
5254

5355
# Build the examples and demo functions
5456
ENV PATH=${PATH}:/root/.cargo/bin
@@ -64,7 +66,6 @@ RUN cd /code/examples \
6466
&& inv polybench --native \
6567
# Build the WASM applications
6668
&& inv ffmpeg \
67-
&& inv jwt \
6869
# ImageMagick needs libpng
6970
&& inv libpng imagemagick \
7071
&& inv kernels \
@@ -73,14 +74,11 @@ RUN cd /code/examples \
7374
&& inv lammps --migration-net \
7475
&& inv lulesh \
7576
&& inv polybench \
76-
&& inv rabe \
7777
&& inv tensorflow \
7878
# These demo functions link with the cross-compiled static libraries
7979
&& inv func ffmpeg check \
80-
&& inv func jwt test \
8180
&& inv func lammps chain \
8281
&& inv func mpi migrate \
83-
&& inv func rabe test \
8482
&& inv func tf check
8583

8684
# Prepare bashrc

requirements.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
black>=22.3.0
2-
faasmctl>=0.32.0
2+
faasmctl>=0.51.0
33
flake8>=4.0.1
44
invoke>=1.7.1
55
python-lsp-server[all]>=1.12.0

tasks/docker.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -55,9 +55,6 @@ def build(ctx, ctr, nocache=False, push=False):
5555
build_args=build_args,
5656
)
5757

58-
if push:
59-
push(ctx, [c])
60-
6158

6259
@task(iterable=["ctr"])
6360
def push(ctx, ctr):

tasks/env.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
from faasmtools.build import FAASM_LOCAL_DIR
2-
from faasmtools.docker import ACR_NAME
2+
from faasmtools.docker import CR_NAME
33
from faasmtools.env import get_version as get_cpp_version
44
from os import environ
55
from os.path import dirname, abspath, join
@@ -14,9 +14,9 @@
1414

1515
# Docker variables
1616
EXAMPLES_BUILD_IMAGE_CTR = "examples-build-workon"
17-
EXAMPLES_BUILD_IMAGE_NAME = "{}/examples-build".format(ACR_NAME)
17+
EXAMPLES_BUILD_IMAGE_NAME = "{}/examples-build".format(CR_NAME)
1818
EXAMPLES_BUILD_DOCKERFILE = join(DOCKER_ROOT, "build.dockerfile")
19-
EXAMPLES_BASE_IMAGE_NAME = "{}/examples-base".format(ACR_NAME)
19+
EXAMPLES_BASE_IMAGE_NAME = "{}/examples-base".format(CR_NAME)
2020
EXAMPLES_BASE_DOCKERFILE = join(DOCKER_ROOT, "base.dockerfile")
2121

2222
# Shared files data

tasks/func.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@ def tests(ctx, clean=False):
4444
["ffmpeg", "check"],
4545
["opencv", "check"],
4646
["opencv", "pca"],
47-
["rabe", "test"],
4847
["tf", "check"],
4948
# TODO: this two functions are not used in the tests, as they are used
5049
# to exercise migration, for what we need a distributed test setting

0 commit comments

Comments
 (0)