Skip to content

Commit 0cd0ac4

Browse files
committed
avoid using key from other props
1 parent 0afdc69 commit 0cd0ac4

File tree

1 file changed

+1
-5
lines changed

1 file changed

+1
-5
lines changed

ReactCommon/react/renderer/attributedstring/conversions.h

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -567,7 +567,6 @@ inline std::string toString(const TextDecorationStyle &textDecorationStyle) {
567567
}
568568

569569
inline std::string toString(const AccessibilityUnit &accessibilityUnit) {
570-
LOG(ERROR) << "TESTING:: some test";
571570
switch (accessibilityUnit) {
572571
case AccessibilityUnit::None:
573572
return "none";
@@ -580,7 +579,6 @@ inline std::string toString(const AccessibilityUnit &accessibilityUnit) {
580579
}
581580

582581
inline std::string toString(const AccessibilityRole &accessibilityRole) {
583-
LOG(ERROR) << "TESTING:: some test";
584582
switch (accessibilityRole) {
585583
case AccessibilityRole::None:
586584
return "none";
@@ -996,7 +994,6 @@ inline folly::dynamic toDynamic(const TextAttributes &textAttributes) {
996994
_textAttributes(
997995
"layoutDirection", toString(*textAttributes.layoutDirection));
998996
}
999-
LOG(ERROR) << "TESTING:: triggered ";
1000997
if (textAttributes.accessibilityRole.has_value()) {
1001998
_textAttributes(
1002999
"accessibilityRole", toString(*textAttributes.accessibilityRole));
@@ -1079,7 +1076,7 @@ constexpr static MapBuffer::Key TA_KEY_IS_HIGHLIGHTED = 20;
10791076
constexpr static MapBuffer::Key TA_KEY_LAYOUT_DIRECTION = 21;
10801077
constexpr static MapBuffer::Key TA_KEY_ACCESSIBILITY_ROLE = 22;
10811078
constexpr static MapBuffer::Key TA_KEY_LINE_BREAK_STRATEGY = 23;
1082-
constexpr static MapBuffer::Key TA_KEY_ACCESSIBILITY_UNIT = 24;
1079+
constexpr static MapBuffer::Key TA_KEY_ACCESSIBILITY_UNIT = 99;
10831080

10841081
// constants for ParagraphAttributes serialization
10851082
constexpr static MapBuffer::Key PA_KEY_MAX_NUMBER_OF_LINES = 0;
@@ -1226,7 +1223,6 @@ inline MapBuffer toMapBuffer(const TextAttributes &textAttributes) {
12261223
builder.putString(
12271224
TA_KEY_ACCESSIBILITY_ROLE, toString(*textAttributes.accessibilityRole));
12281225
}
1229-
LOG(ERROR) << "TESTING:: triggered ";
12301226
if (textAttributes.accessibilityUnit.has_value()) {
12311227
builder.putString(
12321228
TA_KEY_ACCESSIBILITY_UNIT, toString(*textAttributes.accessibilityUnit));

0 commit comments

Comments
 (0)