Skip to content

Commit 1453ef1

Browse files
hoxyqfacebook-github-bot
authored andcommitted
refactor(react-native-github): move ProgressViewIOS to internal (facebook#35277)
Summary: Pull Request resolved: facebook#35277 # Changelog: [JS][Removed] - removed ProgressViewIOS module [iOS][Removed] - removed native iOS sources of ProgressViewIOS Reviewed By: lunaleaps Differential Revision: D40937475 fbshipit-source-id: 9060adf3c99727af4eeffc767ccfd0a70574859d
1 parent ff4a3c2 commit 1453ef1

File tree

13 files changed

+63
-404
lines changed

13 files changed

+63
-404
lines changed

Libraries/Components/ProgressViewIOS/ProgressViewIOS.android.js

Lines changed: 0 additions & 45 deletions
This file was deleted.

Libraries/Components/ProgressViewIOS/ProgressViewIOS.d.ts

Lines changed: 0 additions & 62 deletions
This file was deleted.

Libraries/Components/ProgressViewIOS/ProgressViewIOS.ios.js

Lines changed: 0 additions & 75 deletions
This file was deleted.

Libraries/Components/ProgressViewIOS/RCTProgressViewNativeComponent.js

Lines changed: 0 additions & 33 deletions
This file was deleted.

Libraries/Components/ProgressViewIOS/__tests__/ProgressViewIOS-test.js

Lines changed: 0 additions & 28 deletions
This file was deleted.

Libraries/Components/ProgressViewIOS/__tests__/__snapshots__/ProgressViewIOS-test.js.snap

Lines changed: 0 additions & 41 deletions
This file was deleted.

React/Views/RCTProgressViewManager.h

Lines changed: 0 additions & 12 deletions
This file was deleted.

React/Views/RCTProgressViewManager.m

Lines changed: 0 additions & 45 deletions
This file was deleted.

index.js

Lines changed: 15 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ import typeof KeyboardAvoidingView from './Libraries/Components/Keyboard/Keyboar
2424
import typeof Modal from './Libraries/Modal/Modal';
2525
import typeof Pressable from './Libraries/Components/Pressable/Pressable';
2626
import typeof ProgressBarAndroid from './Libraries/Components/ProgressBarAndroid/ProgressBarAndroid';
27-
import typeof ProgressViewIOS from './Libraries/Components/ProgressViewIOS/ProgressViewIOS';
2827
import typeof RefreshControl from './Libraries/Components/RefreshControl/RefreshControl';
2928
import typeof SafeAreaView from './Libraries/Components/SafeAreaView/SafeAreaView';
3029
import typeof ScrollView from './Libraries/Components/ScrollView/ScrollView';
@@ -160,16 +159,6 @@ module.exports = {
160159
);
161160
return require('./Libraries/Components/ProgressBarAndroid/ProgressBarAndroid');
162161
},
163-
// $FlowFixMe[value-as-type]
164-
get ProgressViewIOS(): ProgressViewIOS {
165-
warnOnce(
166-
'progress-view-ios-moved',
167-
'ProgressViewIOS has been extracted from react-native core and will be removed in a future release. ' +
168-
"It can now be installed and imported from '@react-native-community/progress-view' instead of 'react-native'. " +
169-
'See https://github.com/react-native-progress-view/progress-view',
170-
);
171-
return require('./Libraries/Components/ProgressViewIOS/ProgressViewIOS');
172-
},
173162
get RefreshControl(): RefreshControl {
174163
return require('./Libraries/Components/RefreshControl/RefreshControl');
175164
},
@@ -770,4 +759,19 @@ if (__DEV__) {
770759
);
771760
},
772761
});
762+
/* $FlowFixMe[prop-missing] This is intentional: Flow will error when
763+
* attempting to access ProgressViewIOS. */
764+
/* $FlowFixMe[invalid-export] This is intentional: Flow will error when
765+
* attempting to access ProgressViewIOS. */
766+
Object.defineProperty(module.exports, 'ProgressViewIOS', {
767+
configurable: true,
768+
get() {
769+
invariant(
770+
false,
771+
'ProgressViewIOS has been removed from react-native core. ' +
772+
"It can now be installed and imported from '@react-native-community/progress-view' instead of 'react-native'. " +
773+
'See https://github.com/react-native-progress-view/progress-view',
774+
);
775+
},
776+
});
773777
}

0 commit comments

Comments
 (0)