Revert D51346658: Multisect successfully blamed "D51346658: [RN][Android] Handle all incoming Inspector messages on main thread, downgrade some errors to logs" for otest failure

Summary:
This diff is reverting D51346658
D51346658: [RN][Android] Handle all incoming Inspector messages on main thread, downgrade some errors to logs by motiz88 has been identified to be causing the following test failure:

Tests affected:
- [xplat/endtoend/jest-e2e/apps/facebook_xplat/ReactNativeTTRCTester/__tests__/ReactNativeTTRCTester-storeOrNetworkWithoutCachedContent-android-e2e.js](https://www.internalfb.com/intern/test/281475019301167/)

Here's the Multisect link:
https://www.internalfb.com/multisect/3539088
Here are the tasks that are relevant to this breakage:

We're generating a revert to back out the changes in this diff, please note the backout may land if someone accepts it.

If you believe this diff has been generated in error you may Commandeer and Abandon it.

bypass-github-export-checks

Changelog: [Internal]

Reviewed By: motiz88

Differential Revision: D51512872

fbshipit-source-id: 8bc8e12b651f91a6f74243a0a85fca7fd1953bdb

Author: Dark Knight

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/DevServerHelper.java

@@ -210,10 +210,16 @@ public void openInspectorConnection() {
       FLog.w(ReactConstants.TAG, "Inspector connection already open, nooping.");
       return;
     }
-    mInspectorPackagerConnection =
-        new InspectorPackagerConnection(
-            getInspectorDeviceUrl(), mPackageName, mBundlerStatusProvider);
-    mInspectorPackagerConnection.connect();
+    new AsyncTask<Void, Void, Void>() {
+      @Override
+      protected Void doInBackground(Void... params) {
+        mInspectorPackagerConnection =
+            new InspectorPackagerConnection(
+                getInspectorDeviceUrl(), mPackageName, mBundlerStatusProvider);
+        mInspectorPackagerConnection.connect();
+        return null;
+      }
+    }.executeOnExecutor(AsyncTask.THREAD_POOL_EXECUTOR);
   }
 
   public void disableDebugger() {
@@ -223,10 +229,16 @@ public void disableDebugger() {
   }
 
   public void closeInspectorConnection() {
-    if (mInspectorPackagerConnection != null) {
-      mInspectorPackagerConnection.closeQuietly();
-      mInspectorPackagerConnection = null;
-    }
+    new AsyncTask<Void, Void, Void>() {
+      @Override
+      protected Void doInBackground(Void... params) {
+        if (mInspectorPackagerConnection != null) {
+          mInspectorPackagerConnection.closeQuietly();
+          mInspectorPackagerConnection = null;
+        }
+        return null;
+      }
+    }.executeOnExecutor(AsyncTask.THREAD_POOL_EXECUTOR);
   }
 
   public String getWebsocketProxyURL() {

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/DevSupportManagerBase.java

@@ -942,15 +942,13 @@ private void reportBundleLoadingFailure(final Exception cause) {
 
   @Override
   public void startInspector() {
-    UiThreadUtil.assertOnUiThread();
     if (mIsDevSupportEnabled) {
       mDevServerHelper.openInspectorConnection();
     }
   }
 
   @Override
   public void stopInspector() {
-    UiThreadUtil.assertOnUiThread();
     mDevServerHelper.closeInspectorConnection();
   }
 
@@ -1047,12 +1045,9 @@ public void onPackagerDisconnected() {
 
             @Override
             public void onPackagerReloadCommand() {
-              UiThreadUtil.runOnUiThread(
-                  () -> {
-                    // Disable debugger to resume the JsVM & avoid thread locks while reloading
-                    mDevServerHelper.disableDebugger();
-                    handleReloadJS();
-                  });
+              // Disable debugger to resume the JsVM & avoid thread locks while reloading
+              mDevServerHelper.disableDebugger();
+              UiThreadUtil.runOnUiThread(() -> handleReloadJS());
             }
 
             @Override

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/InspectorPackagerConnection.java

@@ -8,10 +8,12 @@
 package com.facebook.react.devsupport;
 
 import android.os.AsyncTask;
+import android.os.Handler;
+import android.os.Looper;
 import androidx.annotation.Nullable;
 import com.facebook.common.logging.FLog;
 import com.facebook.react.bridge.Inspector;
-import com.facebook.react.bridge.UiThreadUtil;
+import java.io.IOException;
 import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
@@ -35,20 +37,17 @@ public class InspectorPackagerConnection {
 
   public InspectorPackagerConnection(
       String url, String packageName, BundleStatusProvider bundleStatusProvider) {
-    UiThreadUtil.assertOnUiThread();
     mConnection = new Connection(url);
     mInspectorConnections = new HashMap<>();
     mPackageName = packageName;
     mBundleStatusProvider = bundleStatusProvider;
   }
 
   public void connect() {
-    UiThreadUtil.assertOnUiThread();
     mConnection.connect();
   }
 
   public void closeQuietly() {
-    UiThreadUtil.assertOnUiThread();
     mConnection.close();
   }
 
@@ -60,7 +59,7 @@ public void sendEventToAllConnections(String event) {
     }
   }
 
-  void handleProxyMessage(JSONObject message) throws JSONException {
+  void handleProxyMessage(JSONObject message) throws JSONException, IOException {
     String event = message.getString("event");
     switch (event) {
       case "getPages":
@@ -76,8 +75,7 @@ void handleProxyMessage(JSONObject message) throws JSONException {
         handleDisconnect(message.getJSONObject("payload"));
         break;
       default:
-        FLog.e(TAG, "Unknown event: " + event);
-        break;
+        throw new IllegalArgumentException("Unknown event: " + event);
     }
   }
 
@@ -92,8 +90,7 @@ private void handleConnect(JSONObject payload) throws JSONException {
     final String pageId = payload.getString("pageId");
     Inspector.LocalConnection inspectorConnection = mInspectorConnections.remove(pageId);
     if (inspectorConnection != null) {
-      FLog.w(TAG, "Already connected: " + pageId);
-      return;
+      throw new IllegalStateException("Already connected: " + pageId);
     }
 
     try {
@@ -194,65 +191,49 @@ private class Connection extends WebSocketListener {
 
     private OkHttpClient mHttpClient;
     private @Nullable WebSocket mWebSocket;
+    private final Handler mHandler;
     private boolean mClosed;
     private boolean mSuppressConnectionErrors;
 
     public Connection(String url) {
       mUrl = url;
+      mHandler = new Handler(Looper.getMainLooper());
     }
 
     @Override
     public void onOpen(WebSocket webSocket, Response response) {
-      UiThreadUtil.runOnUiThread(
-          () -> {
-            mWebSocket = webSocket;
-          });
+      mWebSocket = webSocket;
     }
 
     @Override
     public void onFailure(WebSocket webSocket, Throwable t, Response response) {
-      UiThreadUtil.runOnUiThread(
-          () -> {
-            if (mWebSocket != null) {
-              abort("Websocket exception", t);
-            }
-            if (!mClosed) {
-              reconnect();
-            }
-          });
+      if (mWebSocket != null) {
+        abort("Websocket exception", t);
+      }
+      if (!mClosed) {
+        reconnect();
+      }
     }
 
     @Override
     public void onMessage(WebSocket webSocket, String text) {
       try {
-        JSONObject parsed = new JSONObject(text);
-        UiThreadUtil.runOnUiThread(
-            () -> {
-              try {
-                handleProxyMessage(parsed);
-              } catch (JSONException e) {
-                FLog.w(TAG, "Error handling inspector message", e);
-              }
-            });
-      } catch (JSONException e) {
-        FLog.w(TAG, "Unrecognized inspector message, string was not valid JSON: " + text, e);
+        handleProxyMessage(new JSONObject(text));
+      } catch (Exception e) {
+        throw new RuntimeException(e);
       }
     }
 
     @Override
     public void onClosed(WebSocket webSocket, int code, String reason) {
-      UiThreadUtil.runOnUiThread(
-          () -> {
-            mWebSocket = null;
-            closeAllConnections();
-            if (!mClosed) {
-              reconnect();
-            }
-          });
+      mWebSocket = null;
+      closeAllConnections();
+      if (!mClosed) {
+        reconnect();
+      }
     }
 
     public void connect() {
-      UiThreadUtil.assertOnUiThread();
       if (mClosed) {
         throw new IllegalStateException("Can't connect closed client");
       }
@@ -277,18 +258,20 @@ private void reconnect() {
         FLog.w(TAG, "Couldn't connect to packager, will silently retry");
         mSuppressConnectionErrors = true;
       }
-      UiThreadUtil.runOnUiThread(
-          () -> {
-            // check that we haven't been closed in the meantime
-            if (!mClosed) {
-              connect();
+      mHandler.postDelayed(
+          new Runnable() {
+            @Override
+            public void run() {
+              // check that we haven't been closed in the meantime
+              if (!mClosed) {
+                connect();
+              }
             }
           },
           RECONNECT_DELAY_MS);
     }
 
     public void close() {
-      UiThreadUtil.assertOnUiThread();
       mClosed = true;
       if (mWebSocket != null) {
         try {