Skip to content

Commit 7e5a266

Browse files
yungstersfacebook-github-bot
authored andcommitted
RN: Simplify createAnimatedPropsHook-test.js (facebook#51234)
Summary: Pull Request resolved: facebook#51234 Since `createAnimatedPropsHook-test.js` no longer needs to override feature flags, clean up some of the extra logic. Changelog: [Internal] Reviewed By: javache Differential Revision: D74535116 fbshipit-source-id: 09dd4c5085f6ee1cbf7d87ab2b7c320119e69651
1 parent 0925ee8 commit 7e5a266

File tree

1 file changed

+2
-28
lines changed

1 file changed

+2
-28
lines changed

packages/react-native/src/private/animated/__tests__/createAnimatedPropsHook-test.js

Lines changed: 2 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -9,37 +9,13 @@
99
* @oncall react_native
1010
*/
1111

12-
import type {ReactNativeFeatureFlagsJsOnlyOverrides} from '../../featureflags/ReactNativeFeatureFlags';
13-
1412
import {create, update} from '../../../../jest/renderer';
13+
import {AnimatedEvent} from '../../../../Libraries/Animated/AnimatedEvent';
14+
import createAnimatedPropsHook from '../createAnimatedPropsHook';
1515
import {useLayoutEffect} from 'react';
1616

1717
describe('useAnimatedProps', () => {
18-
function importModules(overrides: ReactNativeFeatureFlagsJsOnlyOverrides) {
19-
const ReactNativeFeatureFlags = require('../../featureflags/ReactNativeFeatureFlags');
20-
21-
// Make sure to setup overrides before importing any modules.
22-
ReactNativeFeatureFlags.override(overrides);
23-
24-
return {
25-
// $FlowIgnore[unsafe-getters-setters]
26-
get AnimatedEvent() {
27-
return require('../../../../Libraries/Animated/AnimatedEvent')
28-
.AnimatedEvent;
29-
},
30-
// $FlowIgnore[unsafe-getters-setters]
31-
get createAnimatedPropsHook() {
32-
return require('../createAnimatedPropsHook').default;
33-
},
34-
};
35-
}
36-
37-
beforeEach(() => {
38-
jest.resetModules();
39-
});
40-
4118
it('returns the same ref callback when `props` changes', async () => {
42-
const {createAnimatedPropsHook} = importModules({});
4319
const useAnimatedProps = createAnimatedPropsHook(null);
4420

4521
const refs = [];
@@ -60,7 +36,6 @@ describe('useAnimatedProps', () => {
6036
});
6137

6238
it('returns the same ref callback when `AnimatedEvent` is the same', async () => {
63-
const {AnimatedEvent, createAnimatedPropsHook} = importModules({});
6439
const useAnimatedProps = createAnimatedPropsHook(null);
6540

6641
const refs = [];
@@ -83,7 +58,6 @@ describe('useAnimatedProps', () => {
8358
});
8459

8560
it('returns a new ref callback when `AnimatedEvent` changes', async () => {
86-
const {AnimatedEvent, createAnimatedPropsHook} = importModules({});
8761
const useAnimatedProps = createAnimatedPropsHook(null);
8862

8963
const refs = [];

0 commit comments

Comments
 (0)