Fabric cpp settings trigger runtime error

terminating with uncaught exception of type std::length_error: vector (screenshot1, screenshot2)
https://www.icloud.com/iclouddrive/0a4Urx1Av554xzHH1hh3YHy9A#first_screenshot
https://stackoverflow.com/a/1183709/7295772

Author: fabOnReact

Libraries/Components/View/ViewAccessibility.js

@@ -12,6 +12,7 @@
 
 import type {SyntheticEvent} from '../../Types/CoreEventTypes';
 
+export type AccessibilityUnit = 'none' | 'verbatim';
 // This must be kept in sync with the AccessibilityRolesMask in RCTViewManager.m
 export type AccessibilityRole =
   | 'none'

Libraries/Text/TextProps.js

@@ -15,6 +15,7 @@ import type {
   AccessibilityActionInfo,
   AccessibilityRole,
   AccessibilityState,
+  AccessibilityUnit,
   Role,
 } from '../Components/View/ViewAccessibility';
 import type {TextStyleProp} from '../StyleSheet/StyleSheet';
@@ -57,6 +58,7 @@ export type TextProps = $ReadOnly<{|
   accessibilityLanguage?: ?Stringish,
   accessibilityLabel?: ?Stringish,
   accessibilityRole?: ?AccessibilityRole,
+  accessibilityUnit?: ?AccessibilityUnit,
   accessibilityState?: ?AccessibilityState,
   'aria-label'?: ?string,
 

ReactAndroid/src/main/java/com/facebook/react/uimanager/BaseViewManager.java

@@ -26,6 +26,7 @@
 import com.facebook.react.common.MapBuilder;
 import com.facebook.react.common.ReactConstants;
 import com.facebook.react.uimanager.ReactAccessibilityDelegate.AccessibilityRole;
+import com.facebook.react.uimanager.ReactAccessibilityDelegate.AccessibilityUnit;
 import com.facebook.react.uimanager.annotations.ReactProp;
 import com.facebook.react.uimanager.events.PointerEventHelper;
 import com.facebook.react.uimanager.util.ReactFindViewUtil;
@@ -250,6 +251,14 @@ public void setAccessibilityRole(@NonNull T view, @Nullable String accessibility
     view.setTag(R.id.accessibility_role, AccessibilityRole.fromValue(accessibilityRole));
   }
 
+  @ReactProp(name = ViewProps.ACCESSIBILITY_UNIT)
+  public void setAccessibilityUnit(@NonNull T view, @Nullable String accessibilityUnit) {
+    if (accessibilityUnit == null) {
+      return;
+    }
+    view.setTag(R.id.accessibility_unit, AccessibilityUnit.fromValue(accessibilityUnit));
+  }
+
   @Override
   @ReactProp(name = ViewProps.ACCESSIBILITY_COLLECTION)
   public void setAccessibilityCollection(

ReactAndroid/src/main/java/com/facebook/react/uimanager/ReactAccessibilityDelegate.java

@@ -90,6 +90,36 @@ private void scheduleAccessibilityEventSender(View host) {
     Message msg = mHandler.obtainMessage(SEND_EVENT, host);
     mHandler.sendMessageDelayed(msg, TIMEOUT_SEND_ACCESSIBILITY_EVENT);
   }
+  /**
+   * These roles are defined by Google's TalkBack screen reader, and this list should be kept up to
+   * date with their implementation. Details can be seen in their source code here:
+   *
+   * <p>https://github.com/google/talkback/blob/master/utils/src/main/java/Unit.java
+   */
+  public enum AccessibilityUnit {
+    NONE,
+    VERBATIM;
+
+    public static String getValue(AccessibilityUnit role) {
+      switch (role) {
+        case VERBATIM:
+          return "android.type.verbatim";
+        case NONE:
+          return "android.type.text";
+        default:
+          throw new IllegalArgumentException("Invalid accessibility role value: " + role);
+      }
+    }
+
+    public static AccessibilityUnit fromValue(@Nullable String value) {
+      for (AccessibilityUnit unit : AccessibilityUnit.values()) {
+        if (unit.name().equalsIgnoreCase(value)) {
+          return unit;
+        }
+      }
+      throw new IllegalArgumentException("Invalid accessibility unit value: " + value);
+    }
+  }
 
   /**
    * These roles are defined by Google's TalkBack screen reader, and this list should be kept up to

ReactAndroid/src/main/java/com/facebook/react/views/text/TextAttributeProps.java

@@ -104,7 +104,7 @@ public class TextAttributeProps {
   protected @Nullable ReactAccessibilityDelegate.AccessibilityRole mAccessibilityRole = null;
   protected boolean mIsAccessibilityRoleSet = false;
   protected boolean mIsAccessibilityUnitSet = false;
-  protected String mAccessibilityUnit = "";
+  protected @Nullable ReactAccessibilityDelegate.AccessibilityUnit mAccessibilityUnit = "";
   protected boolean mIsAccessibilityLink = false;
 
   protected int mFontStyle = UNSET;
@@ -609,7 +609,8 @@ private void setTextTransform(@Nullable String textTransform) {
   private void setAccessibilityUnit(@Nullable String accessibilityUnit) {
     if (accessibilityUnit != null) {
       mIsAccessibilityUnitSet = true;
-      mAccessibilityUnit = accessibilityUnit;
+      mAccessibilityUnit =
+          ReactAccessibilityDelegate.AccessibilityUnit.fromValue(accessibilityUnit);
     }
   }
 

ReactAndroid/src/main/res/views/uimanager/values/ids.xml

@@ -14,6 +14,7 @@
 
   <!-- tag is used to store accessibilityRole tag-->
   <item type="id" name="accessibility_role"/>
+  <item type="id" name="accessibility_unit"/>
 
   <!-- tag is used to store accessibilityCollection -->
   <item type="id" name="accessibility_collection"/>

ReactCommon/react/renderer/attributedstring/TextAttributes.cpp

@@ -99,8 +99,8 @@ void TextAttributes::apply(TextAttributes textAttributes) {
       ? textAttributes.accessibilityRole
       : accessibilityRole;
   accessibilityUnit = textAttributes.accessibilityUnit.has_value()
-      ? "first value"
-      : "second value";
+      ? textAttributes.accessibilityUnit
+      : accessibilityUnit;
 }
 
 #pragma mark - Operators

ReactCommon/react/renderer/attributedstring/TextAttributes.h

@@ -79,7 +79,7 @@ class TextAttributes : public DebugStringConvertible {
   // construction.
   std::optional<LayoutDirection> layoutDirection{};
   std::optional<AccessibilityRole> accessibilityRole{};
-  std::optional<std::string> accessibilityUnit{""};
+  std::optional<AccessibilityUnit> accessibilityUnit{};
 
 #pragma mark - Operations
 

ReactCommon/react/renderer/attributedstring/conversions.h

@@ -22,6 +22,7 @@
 #include <react/renderer/core/propsConversions.h>
 #include <react/renderer/graphics/Geometry.h>
 #include <react/renderer/graphics/conversions.h>
+#include <sys/errno.h>
 #include <cmath>
 
 #ifdef ANDROID
@@ -565,7 +566,21 @@ inline std::string toString(const TextDecorationStyle &textDecorationStyle) {
   return "solid";
 }
 
+inline std::string toString(const AccessibilityUnit &accessibilityUnit) {
+  LOG(ERROR) << "TESTING:: some test";
+  switch (accessibilityUnit) {
+    case AccessibilityUnit::None:
+      return "none";
+    case AccessibilityUnit::Verbatim:
+      return "verbatim";
+  }
+  LOG(ERROR) << "Unsupported AccessibilityUnit value";
+  react_native_assert(false);
+  return "none";
+}
+
 inline std::string toString(const AccessibilityRole &accessibilityRole) {
+  LOG(ERROR) << "TESTING:: some test";
   switch (accessibilityRole) {
     case AccessibilityRole::None:
       return "none";
@@ -631,6 +646,32 @@ inline std::string toString(const AccessibilityRole &accessibilityRole) {
   return "none";
 }
 
+inline void fromRawValue(
+    const PropsParserContext &context,
+    const RawValue &value,
+    AccessibilityUnit &result) {
+  react_native_assert(value.hasType<std::string>());
+  if (value.hasType<std::string>()) {
+    auto string = (std::string)value;
+    if (string == "none") {
+      result = AccessibilityUnit::None;
+    } else if (string == "verbatim") {
+      result = AccessibilityUnit::Verbatim;
+    } else {
+      LOG(ERROR) << "Unsupported AccessibilityUnit value: " << string;
+      react_native_assert(false);
+      // sane default for prod
+      result = AccessibilityUnit::None;
+    }
+    return;
+  }
+
+  LOG(ERROR) << "Unsupported AccessibilityUnit type";
+  react_native_assert(false);
+  // sane default for prod
+  result = AccessibilityUnit::None;
+}
+
 inline void fromRawValue(
     const PropsParserContext &context,
     const RawValue &value,
@@ -955,13 +996,14 @@ inline folly::dynamic toDynamic(const TextAttributes &textAttributes) {
     _textAttributes(
         "layoutDirection", toString(*textAttributes.layoutDirection));
   }
+  LOG(ERROR) << "TESTING:: triggered ";
   if (textAttributes.accessibilityRole.has_value()) {
     _textAttributes(
         "accessibilityRole", toString(*textAttributes.accessibilityRole));
   }
   if (textAttributes.accessibilityUnit.has_value()) {
     _textAttributes(
-        "accessibilityUnit", "random value");
+        "accessibilityUnit", toString(*textAttributes.accessibilityUnit));
   }
   return _textAttributes;
 }
@@ -1184,9 +1226,10 @@ inline MapBuffer toMapBuffer(const TextAttributes &textAttributes) {
     builder.putString(
         TA_KEY_ACCESSIBILITY_ROLE, toString(*textAttributes.accessibilityRole));
   }
+  LOG(ERROR) << "TESTING:: triggered ";
   if (textAttributes.accessibilityUnit.has_value()) {
     builder.putString(
-        TA_KEY_ACCESSIBILITY_UNIT, "random string value");
+        TA_KEY_ACCESSIBILITY_UNIT, toString(*textAttributes.accessibilityUnit));
   }
   return builder.build();
 }

ReactCommon/react/renderer/attributedstring/primitives.h

@@ -92,6 +92,11 @@ enum class TextDecorationLineType {
 
 enum class TextDecorationStyle { Solid, Double, Dotted, Dashed };
 
+enum class AccessibilityUnit {
+  None,
+  Verbatim,
+};
+
 enum class AccessibilityRole {
   None,
   Button,
@@ -211,6 +216,13 @@ struct hash<facebook::react::AccessibilityRole> {
   }
 };
 
+template <>
+struct hash<facebook::react::AccessibilityUnit> {
+  size_t operator()(const facebook::react::AccessibilityUnit &v) const {
+    return hash<int>()(static_cast<int>(v));
+  }
+};
+
 template <>
 struct hash<facebook::react::TextTransform> {
   size_t operator()(const facebook::react::TextTransform &v) const {